[Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
See attached patch. Previously a NPE would be generated, but since the stack trace is not very useful as it can only go back until run(), it only polluted test outputs. I think that logging the error makes more sense in this case. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Tomas Lestach
: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect See attached patch. Previously a NPE would be generated, but since the stack trace is not very useful as it can only go back until run(), it only polluted test outputs. I think that logging

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Silvio Moioli
On 09/09/2013 10:03 AM, Tomas Lestach wrote: So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) I think that is exactly the

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Grant Gainey
] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect See attached patch. Previously a NPE would be generated, but since the stack trace is not very useful as it can only go back until run(), it only polluted test outputs. I think that logging the error makes more

Re: [Spacewalk-devel] [PATCH] UpdateErrataCacheCommand: log an error when orgId is incorrect

2013-09-09 Thread Tomas Lestach
- Original Message - So, what is the motivation of this change? (The only scenario I can imagine is, that the errata cache event will be queued and its organization gets deleted before the background errata cache action gets executed.) Exactly so. Because of the way the