Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-04 Thread Tomas Lestach
-devel@redhat.com Sent: Tuesday, July 2, 2013 9:33:08 AM Subject: Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate On 07/01/2013 05:14 PM, Tomas Lestach wrote: All right, so in case the bug does not evince in current Spacewalk, will it be visible when we upgrade

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-02 Thread Silvio Moioli
On 07/01/2013 05:14 PM, Tomas Lestach wrote: All right, so in case the bug does not evince in current Spacewalk, will it be visible when we upgrade to newer hibernate (which version) or any other component? As far as I know, patched code is fragile regardless of Hibernate version (we

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-01 Thread Tomas Lestach
Hello Silvio, - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Monday, June 10, 2013 3:31:07 PM Subject: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate Hi, we had a downstream bug that boiled down

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-07-01 Thread Silvio Moioli
On 07/01/2013 01:12 PM, Tomas Lestach wrote: Could you point me to the appropriate bugzilla? I'd like to check the reproducer. Unfortunately our Bugzilla component is closed for outside view at the moment, and the bug only affected SUSE-specific code. If you need any further details, just let

Re: [Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-06-13 Thread Tomáš Kašpárek
Hello Silvio, thank you for your patch, it will be committed somewhere in the next week. Thank you for your contribution! On 06/10/2013 03:31 PM, Silvio Moioli wrote: Hi, we had a downstream bug that boiled down to a failing Channel to ClonedChannel cast. The cast was failing because

[Spacewalk-devel] [PATCH] avoid relying on types returned by Hibernate

2013-06-10 Thread Silvio Moioli
Hi, we had a downstream bug that boiled down to a failing Channel to ClonedChannel cast. The cast was failing because Hibernate proxy objects for subclasses are guaranteed to implement all properties and methods, so that isClone() correctly returned true, but do not necessarily respect the