Re: [Spacewalk-devel] [PATCH] perl List port to new css/markup

2014-01-10 Thread Duncan Mac-Vicar P.
On 09/01/14 15:40, Duncan Mac-Vicar P. wrote: Attached patch with all mentioned issues corrected. Now attached for real. diff --git a/branding/templates/header.pxt b/branding/templates/header.pxt index d90e605..c567b3a 100644 --- a/branding/templates/header.pxt +++

Re: [Spacewalk-devel] [PATCH] perl List port to new css/markup

2014-01-10 Thread Michael Mraka
Duncan Mac-Vicar P. wrote: % Attached patch with all mentioned issues corrected. % % Now attached for real. This one works fine, I've commited it as 02a0a6549b97a7851a52e4a262f1704548545a83. Thanks, -- Michael Mráka Satellite Engineering, Red Hat

Re: [Spacewalk-devel] [PATCH] perl List port to new css/markup

2014-01-09 Thread Duncan Mac-Vicar P.
On 06/01/14 17:13, Michael Mraka wrote: I've reviewed your patch and found couple of issues: Attached patch with all mentioned issues corrected. It's a legacy code and I'm afraid no current spacewalk developer knows correct answer. Ok, I will need to check if this causes some list to be

[Spacewalk-devel] [PATCH] perl List port to new css/markup

2013-12-20 Thread Duncan Mac-Vicar P.
Attached is a first port of the list view to the new CSS markup. I still have a question though. https://git.fedorahosted.org/cgit/spacewalk.git/tree/web/modules/sniglets/Sniglets/ListView/Style.pm The way the styles work is by defining Style:standard with the default methods and then other