Re: [PATCH] spi/ep93xx: clean probe/remove routines

2012-04-19 Thread Mika Westerberg
On Wed, Apr 18, 2012 at 03:36:11PM +0300, Hannu Heikkinen wrote: Use devm_* functions for managing devres resources. Also use local espi_irq and remove irq variable from struct ep93xx_spi. Cc: mika.westerb...@iki.fi Cc: grant.lik...@secretlab.ca Signed-off-by: Hannu Heikkinen

Re: [PATCH] spi/ep93xx: clean probe/remove routines

2012-04-19 Thread Mika Westerberg
On Wed, Apr 18, 2012 at 11:09:18AM -0500, H Hartley Sweeten wrote: But, I really don't think we actually gain anything by displaying the memory and irq. Maybe this would be more useful: dev_info(pdev-dev, EP93xx SPI Controller using %s\n, espi-dma_tx ? DMA : PIO);

[PATCH] spi/ep93xx: clean probe/remove routines

2012-04-18 Thread Hannu Heikkinen
Use devm_* functions for managing devres resources. Also use local espi_irq and remove irq variable from struct ep93xx_spi. Cc: mika.westerb...@iki.fi Cc: grant.lik...@secretlab.ca Signed-off-by: Hannu Heikkinen hann...@iki.fi --- drivers/spi/spi-ep93xx.c | 36