[Spice-devel] [PATCH] server: clean glz drawables when reseting qxl

2010-08-25 Thread Yonit Halperin
When the we reset qxl, we destroy all srufaces. Since surfaces and glz drawables are no longer dependent, we need to call red_display_clear_glz_drawables explicitly in order to clear all our drawables references in the server. --- server/red_worker.c |3 +++ 1 files changed, 3 insertions(+),

[Spice-devel] [PATCH 0/2] Fix #28817 - vlc sends data when paused

2010-08-25 Thread alexl
From: Alexander Larsson al...@redhat.com VLC sends silent audio and repeats the same frame continuosly while paused. This is fixed by silence detection and same-frame detection. Alexander Larsson (2): server: Don't send stream frames that are identical to the last one Detect played silence

[Spice-devel] [PATCH 2/2] Detect played silence and stop audio stream after 1 second

2010-08-25 Thread alexl
From: Alexander Larsson al...@redhat.com VLC sends silence when paused (bug #28817), which causes a lot of unnecessary network traffic. We detect such silence and shut down the clients audio stream (even though the audio is still active in the server), re-enabling it when we get non-silent data

[Spice-devel] [PATCH 1/1] client: Handle async errors from xshm setup

2010-08-25 Thread alexl
From: Alexander Larsson al...@redhat.com XShmAttach can fail asynchronously, so we need to check the errors in the x error handler during the XSync. --- client/x11/platform.cpp | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git

[Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Alon Levy
SpiceCharDevice{Interface,Instance} replaces SpiceVDIPort*. This gives nothing right now, but lets us support smartcard and other interfaces that rely on a char device without having to introduce further patches to qemu. The changes are: * spice_server_add_interface delegates to

[Spice-devel] [RFC 2/2] qemu, spice-vmc, vdi: update to use SpiceCharDevice* instead of SpiceVDIPort*

2010-08-25 Thread Alon Levy
--- hw/spice-vdi.c | 22 ++ hw/spice-vmc.c | 39 --- 2 files changed, 42 insertions(+), 19 deletions(-) diff --git a/hw/spice-vdi.c b/hw/spice-vdi.c index 23cbbe1..b2ea54a 100644 --- a/hw/spice-vdi.c +++ b/hw/spice-vdi.c @@ -104,7

[Spice-devel] [PATCH 1/1] server: Add missing break in switch case

2010-08-25 Thread alexl
From: Alexander Larsson al...@redhat.com --- server/red_worker.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 2ce15f5..043aa36 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -5212,6 +5212,7 @@ static

Re: [Spice-devel] [PATCH] server: clean glz drawables when reseting qxl

2010-08-25 Thread Alexander Larsson
On Wed, 2010-08-25 at 10:06 +0300, Yonit Halperin wrote: When the we reset qxl, we destroy all srufaces. Since surfaces and glz drawables are no longer dependent, we need to call red_display_clear_glz_drawables explicitly in order to clear all our drawables references in the server. --- Ack

Re: [Spice-devel] Fwd: [PATCH 2/3] server: fix race when data arrives from guest through vdi interface

2010-08-25 Thread Alexander Larsson
On Wed, 2010-08-25 at 06:28 -0400, Alon Levy wrote: - Forwarded Message - From: Alon Levy al...@redhat.com To: al...@redhat.com Sent: Sunday, August 22, 2010 10:28:37 PM (GMT+0200) Auto-Detected Subject: [PATCH 2/3] server: fix race when data arrives from guest through vdi interface

Re: [Spice-devel] Fwd: [PATCH 2/3] server: fix race when data arrives from guest through vdi interface

2010-08-25 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Wed, 2010-08-25 at 06:28 -0400, Alon Levy wrote: - Forwarded Message - From: Alon Levy al...@redhat.com To: al...@redhat.com Sent: Sunday, August 22, 2010 10:28:37 PM (GMT+0200) Auto-Detected Subject: [PATCH 2/3] server: fix

Re: [Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Gerd Hoffmann
Hi, -__visible__ void spice_server_vdi_port_wakeup(SpiceVDIPortInstance *sin) +__visible__ void spice_server_vdi_port_wakeup(SpiceCharDeviceInstance *sin) This should be renamed too. Also please make a separate patch which does the pure vdiport - chardevice renaming. +__visible__ int

[Spice-devel] [PATCH 0/1] Fix 16bpp lz encoded images

2010-08-25 Thread alexl
From: Alexander Larsson al...@redhat.com We were using the wrong stride for 16bpp lz_encoded images, fix is to look at the type to get the right stride when allocating the lz surfaces to decode into. Alexander Larsson (1): server: Fix alloc_lz_image_surface stride allocations

[Spice-devel] [PATCH 1/1] server: Fix alloc_lz_image_surface stride allocations

2010-08-25 Thread alexl
From: Alexander Larsson al...@redhat.com All lz surfaces are not 4 bytes per pixel, calculate the right stride based on the pixman format. --- common/canvas_utils.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/canvas_utils.c b/common/canvas_utils.c index

Re: [Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Wed, 2010-08-25 at 06:53 -0400, Alon Levy wrote: index aede4ce..6c02afb 100644 --- a/server/spice-experimental.h +++ b/server/spice-experimental.h @@ -1,26 +1,31 @@ -/* vdi port interface */ +/* char device interfaces */