[Spice-devel] Problem about qxl and vmc

2012-03-06 Thread wangfeng wangfeng
Hi, I have created a Win7 VM by libvirt. Then I installed only qxl driver but no virtio-serial driver, and vdservice is also not running. But the mouse can move smoothly without SHIFT+F12. Isn't this vdagent's function? After that I installed virtio-serial driver, vdservice and vdagent.

Re: [Spice-devel] Problem about qxl and vmc

2012-03-06 Thread Arnon Gilboa
wangfeng wangfeng wrote: Hi, I have created a Win7 VM by libvirt. Then I installed only qxl driver but no virtio-serial driver, and vdservice is also not running. But the mouse can move smoothly without SHIFT+F12. Isn't this vdagent's function? After that I installed virtio-serial

Re: [Spice-devel] Problem about qxl and vmc

2012-03-06 Thread Gerd Hoffmann
On 03/06/12 09:53, wangfeng wangfeng wrote: Hi, I have created a Win7 VM by libvirt. Then I installed only qxl driver but no virtio-serial driver, and vdservice is also not running. But the mouse can move smoothly without SHIFT+F12. Isn't this vdagent's function? usb-tablet handles this

[Spice-devel] [PATCH spice-gtk] Fix semi-seamless migration handling

2012-03-06 Thread Marc-André Lureau
SPICE_MSGC_MAIN_MIGRATE_END was dropped because the main channel was xmit_queue_blocked. When we swap the channels, we should also swap xmit_queue. --- gtk/spice-channel.c | 67 +++ 1 files changed, 25 insertions(+), 42 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice-gtk] Fix semi-seamless migration handling

2012-03-06 Thread Hans de Goede
ACK. On 03/06/2012 01:00 PM, Marc-André Lureau wrote: SPICE_MSGC_MAIN_MIGRATE_END was dropped because the main channel was xmit_queue_blocked. When we swap the channels, we should also swap xmit_queue. --- gtk/spice-channel.c | 67 +++ 1

[Spice-devel] [PATCH] server/red_worker: fix use after free for listeners

2012-03-06 Thread Alon Levy
This fixes a core dumped observed once by repeated migration. So far 100 migrations and no recurrence. Core was generated by `/home/alon/spice/upstream/bin/qemu-system-x86_64 --enable-kvm -qmp unix:/tmp/mi'. Program terminated with signal 11, Segmentation fault. 11197 if

Re: [Spice-devel] [PATCH] server/red_worker: fix use after free for listeners

2012-03-06 Thread Hans de Goede
ACK! On 03/06/2012 03:50 PM, Alon Levy wrote: This fixes a core dumped observed once by repeated migration. So far 100 migrations and no recurrence. Core was generated by `/home/alon/spice/upstream/bin/qemu-system-x86_64 --enable-kvm -qmp unix:/tmp/mi'. Program terminated with signal 11,

[Spice-devel] Announcing usbredir-0.4.2

2012-03-06 Thread Hans de Goede
Hi All, I'm happy to announce usbredir-0.4.2 usbredir-0.4.2 6 March 2012 --- -Add usb_redir_babble status code -usbredirparser: -extend the usb_redir_ep_info packet header with a max_packet_size field This new field is only send / received if both sides have the

Re: [Spice-devel] [PATCH] server/red_worker: fix use after free for listeners

2012-03-06 Thread Alon Levy
On Tue, Mar 06, 2012 at 03:56:30PM +0100, Hans de Goede wrote: ACK! otoh I'm not too happy with perf top: (this accounts for 5% of samples, i.e. cpu): :for (i = 0; i MAX_EVENT_SOURCES; i++) { 0.21 : 3fc49: movl $0x0,-0x4(%rbp) 0.28 :

Re: [Spice-devel] [PATCH] server/red_worker: fix use after free for listeners

2012-03-06 Thread Alon Levy
On Tue, Mar 06, 2012 at 06:07:06PM +0200, Alon Levy wrote: On Tue, Mar 06, 2012 at 03:56:30PM +0100, Hans de Goede wrote: ACK! otoh I'm not too happy with perf top: but it isn't introduced by this commit, so I'll push. (this accounts for 5% of samples, i.e. cpu): :

[Spice-devel] [PATCH spice-gtk] channel-usbredir: Handle some more usbredirhost_read_guest_data errors

2012-03-06 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- configure.ac |2 +- gtk/channel-usbredir.c | 23 --- gtk/spice-client.h |2 ++ 3 files changed, 23 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 1d24773..13f33e6 100644

Re: [Spice-devel] [PATCH spice-gtk] channel-usbredir: Handle some more usbredirhost_read_guest_data errors

2012-03-06 Thread Alon Levy
On Tue, Mar 06, 2012 at 07:30:55PM +0100, Hans de Goede wrote: Signed-off-by: Hans de Goede hdego...@redhat.com Looks good. ACK. --- configure.ac |2 +- gtk/channel-usbredir.c | 23 --- gtk/spice-client.h |2 ++ 3 files changed, 23

Re: [Spice-devel] Cross-device access in SPICE server

2012-03-06 Thread Yonit Halperin
On 03/05/2012 06:40 PM, Noel Van Hook wrote: On Sun, Mar 4, 2012 at 12:29 PM, Yonit Halperinyhalp...@redhat.com wrote: On 03/02/2012 09:06 PM, Noel Van Hook wrote: I was wondering if anyone had any experience or insight into a way for a worker in the server to get access to data from the

Re: [Spice-devel] Cross-device access in SPICE server

2012-03-06 Thread Noel Van Hook
On Tue, Mar 6, 2012 at 2:33 PM, Yonit Halperin yhalp...@redhat.com wrote: On 03/05/2012 06:40 PM, Noel Van Hook wrote: On Sun, Mar 4, 2012 at 12:29 PM, Yonit Halperinyhalp...@redhat.com  wrote: On 03/02/2012 09:06 PM, Noel Van Hook wrote: I was wondering if anyone had any experience or

Re: [Spice-devel] Cross-device access in SPICE server

2012-03-06 Thread Noel Van Hook
oooh except each head still uses it's own command queue. So even if they go into the various queues in the right order, they may come out in different orders, if one queue is backed up or has very large operations in it. Gotta think about that for a bit. Thanks for the heads up. Noel On