Re: [Spice-devel] [PATCH spice-protocol] Add QXL_ESCAPE_SET_CUSTOM_DISPLAY

2012-05-13 Thread Alon Levy
On Fri, May 11, 2012 at 06:35:29PM +0200, Marc-André Lureau wrote: QXL_ESCAPE_SET_CUSTOM_DISPLAY is Windows specific message to tell the display miniport driver to update the mode table with a custom resolution. The mode table needs to be forcefully refreshed after setting a custom

Re: [Spice-devel] [PATCH win-qxl 2/2] Implement custom display resolution

2012-05-13 Thread Alon Levy
On Fri, May 11, 2012 at 06:36:44PM +0200, Marc-André Lureau wrote: Looks good, some comments below. --- display/driver.c | 32 +++ include/qxl_driver.h |8 +++- miniport/qxl.c | 108 +- 3 files changed, 144

Re: [Spice-devel] [PATCH win-agent 7/9] Quit if RegisterServiceCtrlHandler failed

2012-05-13 Thread Alon Levy
On Fri, May 11, 2012 at 06:39:16PM +0200, Marc-André Lureau wrote: --- vdservice/vdservice.cpp |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 9c057bb..9fafc7c 100644 --- a/vdservice/vdservice.cpp +++

Re: [Spice-devel] [PATCH win-agent 9/9] Resize to arbitrary resolution

2012-05-13 Thread Alon Levy
On Fri, May 11, 2012 at 06:39:18PM +0200, Marc-André Lureau wrote: Use QXL_ESCAPE_SET_CUSTOM_DISPLAY to update custom mode, and switch to it. --- vdagent/desktop_layout.cpp | 26 ++ 1 file changed, 26 insertions(+) diff --git a/vdagent/desktop_layout.cpp

Re: [Spice-devel] [PATCH win-agent 9/9] Resize to arbitrary resolution

2012-05-13 Thread Arnon Gilboa
Alon Levy wrote: On Fri, May 11, 2012 at 06:39:18PM +0200, Marc-André Lureau wrote: Use QXL_ESCAPE_SET_CUSTOM_DISPLAY to update custom mode, and switch to it. --- vdagent/desktop_layout.cpp | 26 ++ 1 file changed, 26 insertions(+) diff --git

Re: [Spice-devel] [PATCH win-agent 2/9] Revert Revert mingw: remove tMain use

2012-05-13 Thread Arnon Gilboa
breaks vs build 1LIBCMT.lib(wincrt0.obj) : error LNK2001: unresolved external symbol _WinMain@16 1Release\vdagent.exe : fatal error LNK1120: 1 unresolved externals we may patch vsproj || ifdef || add this line to vdagent.cpp: #pragma comment (linker, /ENTRY:mainCRTStartup) Marc-André Lureau

Re: [Spice-devel] [PATCH win-agent 1/9] build-sys: fix autoreconf -vfi

2012-05-13 Thread Arnon Gilboa
(except #2) ACK series Acked-by: Arnon Gilboa agil...@redhat.com Marc-André Lureau wrote: --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 77d5c25..28c9d23 100644 --- a/configure.ac +++ b/configure.ac @@ -14,7 +14,7 @@

[Spice-devel] [PATCH] server/red_worker: don't release self_bitmap unless refcount is 0

2012-05-13 Thread Alon Levy
From: Yonit Halperin yhalp...@redhat.com RHBZ: 808936 --- server/red_worker.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 473d0d6..60f30d3 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1695,13

Re: [Spice-devel] [PATCH 1/2] server/mjpeg_encoder: Fix memory leak for the inital output buffer given for each frame

2012-05-13 Thread Alon Levy
On Thu, May 10, 2012 at 02:09:04PM +0300, Yonit Halperin wrote: --- Good catch! ACK both. server/mjpeg_encoder.c | 11 +++ server/mjpeg_encoder.h |5 + 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/mjpeg_encoder.c b/server/mjpeg_encoder.c index

Re: [Spice-devel] Javascript client update, next steps

2012-05-13 Thread Alon Levy
On Fri, May 11, 2012 at 12:21:33PM -0500, Jeremy White wrote: Attached is a first pass implementation of a Javascript client for Spice. It's really only good as a proof of concept right now, and it currently only works 'reliably' in Firefox. The enclosed README discusses how to get it up

Re: [Spice-devel] Javascript client update, next steps

2012-05-13 Thread Jeremy White
Some usage notes: - linux works nicely. [intentional cut] /me plugs ears and just sticks with that response grin. [uncut] Speed is an issue - I haven't done any benchmarking. I'd be happy to try some myself if you had any advice on realistic ones. I also

Re: [Spice-devel] spice-gtk 0.12 and virt-manager

2012-05-13 Thread Marc-André Lureau
Hi - Mensaje original - Hi, List, After upgrading spice-gtk to 0.12, I cannot use virt-manager to view the virtual machine graphical console, When I select the virtual machine and click Open button, I get: Connecting to graphical console for guest. How can I debug this