Re: [Spice-devel] [Spice-commits] 5 commits - client/display_channel.cpp server/red_worker.c server/spice.h

2012-09-11 Thread Alon Levy
Alon Levy al...@redhat.com writes: The solution is the SPICE_INTERFACE_QXL_MAJOR SPICE_INTERFACE_QXL_MINOR versions which are stored in the compiled qemu binary in hw/qxl.c:qxl_interface Any change to the QXLInterface must be accompanied by a change to those two constants, in the

Re: [Spice-devel] [PATCH] Bump SPICE_INTERFACE_QXL_VERSION_MINOR

2012-09-11 Thread Alon Levy
From: Søren Sandmann Pedersen s...@redhat.com Ignore the mail I sent you about bumping to 3.2 regardless - I forgot you need to actually check the fields. So ack, I'll respin my 3.2 patch to use 3.3. Then check that we have the right version before accessing the set_client_capabilities()

Re: [Spice-devel] [PATCH 2/3] vdagent: don't stop due to UIPI blocking

2012-09-11 Thread Arnon Gilboa
Alon Levy wrote: ACK with one question. User Interface Privilege Isolation is usually used only for specific windows of system security applications (anti-viruses etc.), so with this patch mouse will be irresponsive for these windows but keep working for the rest. A complete solution might

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-11 Thread Christophe Fergeau
On Mon, Sep 10, 2012 at 10:57:15AM -0400, Alon Levy wrote: On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: Confirmed, great and thanks. I'd be happy if we could avoid such situations in the future. I know we (used to?) have a build-bot for Spice. Is it alive and working?

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-11 Thread Alon Levy
On Mon, Sep 10, 2012 at 10:57:15AM -0400, Alon Levy wrote: On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: Confirmed, great and thanks. I'd be happy if we could avoid such situations in the future. I know we (used to?) have a build-bot for Spice. Is it alive and

[Spice-devel] [PATCH] Enable build on armv6+

2012-09-11 Thread Christophe Fergeau
From: Peter Robinson pbrobin...@gmail.com The following patch enables it to build on ARM platforms that support atomics. Tested on an armv7hl on an ARMv7 device running Fedora 18. Using firefox connecting to a RHEV-M instance I could launch consoles in spice-xpi and login so basic support works!

Re: [Spice-devel] [PATCH] Enable build on armv6+

2012-09-11 Thread Hans de Goede
ACK! On 09/11/2012 02:14 PM, Christophe Fergeau wrote: From: Peter Robinson pbrobin...@gmail.com The following patch enables it to build on ARM platforms that support atomics. Tested on an armv7hl on an ARMv7 device running Fedora 18. Using firefox connecting to a RHEV-M instance I could

[Spice-devel] remove unsubscribe

2012-09-11 Thread Robert Rawlinson
___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-11 Thread Alon Levy
So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request, similarly to how physical hardware notifies the driver. To

[Spice-devel] [spice-protocol PATCH v2 0.12.2 2/2] Release 0.12.2

2012-09-11 Thread Alon Levy
New in this release: display channel: A8 surface capability qxl: client present, client capabilities, client monitors configuration and guest capabilities. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

Re: [Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-11 Thread Hans de Goede
Hi, On 09/11/2012 04:35 PM, Alon Levy wrote: So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request, similarly to

[Spice-devel] New client capabilities code and multi-client support

2012-09-11 Thread Hans de Goede
Hi, $Subject says it all really, I'm not sure if this is already taken into account, but in multi-client mode, each capabilities bit should only be one if all clients support it. Likewise we should not report a disconnect if only a client goes away, and we still have others connected, or a

Re: [Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-11 Thread Alon Levy
Hi, On 09/11/2012 04:35 PM, Alon Levy wrote: So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new

Re: [Spice-devel] [PATCH xf86-video-qxl] src/qxl_driver: use the new dixScreenSpecificPrivatesSize

2012-09-11 Thread Jeremy White
Hey Alon (and all), Could this patch be done instead with an #ifdef on XORG_VERSION_CURRENT? It'd be nice if the tip of spice could continue to be useful with older Xorgs (said a guy who's focused on RHEL development... :-/). If that would be okay, I can spin up a patch for it. Cheers, Jeremy

Re: [Spice-devel] [PATCH xf86-video-qxl] src/qxl_driver: use the new dixScreenSpecificPrivatesSize

2012-09-11 Thread Søren Sandmann
Jeremy White jwh...@codeweavers.com writes: Hey Alon (and all), Could this patch be done instead with an #ifdef on XORG_VERSION_CURRENT? It'd be nice if the tip of spice could continue to be useful with older Xorgs (said a guy who's focused on RHEL development... :-/). If that would be

Re: [Spice-devel] [warning reduction 00/11] Eliminating warnings in xf86-video-qxl

2012-09-11 Thread Søren Sandmann
Jeremy White jwh...@codeweavers.com writes: The following patch series remove nearly all warnings from xf86-video-qxl. Some general comments: - You have this pattern where you assign a string to a global variable and then you assign that variable to a field instead of the string itself.

Re: [Spice-devel] [PATCH] Enable build on armv6+

2012-09-11 Thread Peter Robinson
On 11 Sep 2012 15:19, Hans de Goede hdego...@redhat.com wrote: ACK! On 09/11/2012 02:14 PM, Christophe Fergeau wrote: From: Peter Robinson pbrobin...@gmail.com Can I have this committed as pbrobin...@redhat.com if its not too late? Peter The following patch enables it to build on ARM

Re: [Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-11 Thread Gerd Hoffmann
On 09/11/12 17:32, Alon Levy wrote: Hi, On 09/11/2012 04:35 PM, Alon Levy wrote: So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the