Re: [Spice-devel] govirt 0.30 plans

2013-11-06 Thread Christophe Fergeau
On Tue, Nov 05, 2013 at 12:27:11PM -0500, i iordanov wrote: Hi Christophe, I am now using the libgovirt 0.30 release. As a preliminary test with self-signed certificates, I re-enabled fetching the ssl cert with ovirt_proxy_fetch_ca_certificate(). However, at the point

Re: [Spice-devel] govirt 0.30 plans

2013-11-06 Thread Christophe Fergeau
On Tue, Nov 05, 2013 at 06:03:21PM -0600, i iordanov wrote: What I have done is manually navigated to https://FQDN/api/vms in order to attach the output I get there for you to see if you can spot why libgovirt fails to look up the VMs. The call failed with name set to both win and winbak.

Re: [Spice-devel] patch[1/1] fix a memory leak in qxl_screen_init

2013-11-06 Thread bigclouds
it is needed to detect the return of qxl_uxa_init in qxl_screen_init . At 2013-11-06 21:59:58,Jeremy White jwh...@codeweavers.com wrote: Nice catch! On 11/06/2013 03:37 AM, bigclouds wrote: hi, it allocate twice memory for qxl-uxa in function qxl_screen_init and qxl_uxa_init

Re: [Spice-devel] Questions about Spice pv domUs

2013-11-06 Thread Stefano Stabellini
On Tue, 5 Nov 2013, Fabio Fantoni wrote: Il 30/09/2013 16:56, Fabio Fantoni ha scritto: I'm trying to implement basic spice support on xen pv domUs. Test seems ok on Ubuntu 12.04 pv domU except mouse which is not visible. I also tried agent-mouse=off on qemu spice options but is not

[Spice-devel] [PATCH 1/2] Mark VD_AGENT_CLIPBOARD_MAX as deprecated

2013-11-06 Thread Marc-André Lureau
There is no use for those 2 values, and the default limit would be quite wrong. Let's just but then in a deprecated block. If someone really uses them, they will have to add -DSPICE_DEPRECATED, or just fix their code. --- spice/vd_agent.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Spice-devel] [PATCH 1/2] Mark VD_AGENT_CLIPBOARD_MAX as deprecated

2013-11-06 Thread Marc-André Lureau
too bad I don't run spelling correcter in my git workflow ;) On Wed, Nov 6, 2013 at 9:07 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: There is no use for those 2 values, and the default limit would be quite wrong. Let's just but then in a deprecated block. If someone really uses

[Spice-devel] [PATCH spice-gtk 1/5] Block sending clipboard data max-clipboard

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Attempt to send very large clipboard data may easy cause OOM abort, either in gdk - some patch are proposed to improve the situation, or in spice-gtk itself. Let's have a property that blocks unreasonably big clipboard data from being

[Spice-devel] [PATCH spice-gtk 0/5] RFC: Improve handling of large clipboard data

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Hi, It's quite easy to crash a spice-gtk client when a clipboard operation take large data buffers. There are several ways this can go wrong (2 ways client side, 2 ways guest side), from what I have found, gdk glib are mostly safe (at least on

[Spice-devel] [PATCH spice-gtk 4/5] main: simplify usage of VD_AGENT_HAS_CAPABILITY

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Introduce a helper function test_agent_cap() to clear the code a little bit. --- gtk/channel-main.c | 60 -- 1 file changed, 27 insertions(+), 33 deletions(-) diff --git a/gtk/channel-main.c

[Spice-devel] [PATCH spice-gtk 3/5] main: use self for main channel variable

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com This simplifies the following commit which uses even more SPICE_MAIN_CHANNEL macro, and makes the code unnecessarily heavy. --- gtk/channel-main.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git

[Spice-devel] [PATCH spice-gtk 2/5] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Allow to easily override default max-clipboard value with environment variable. --- gtk/channel-main.c | 12 1 file changed, 12 insertions(+) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index dbcaff8..75d0281 100644 ---

[Spice-devel] [PATCH spice-gtk 5/5] main: send max-clipboard to agent

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau marcandre.lur...@redhat.com Send configured max-clipboard size to the agent, after receiving agent capabilities. See also spice-protocol patch description: http://lists.freedesktop.org/archives/spice-devel/2013-November/015254.html --- gtk/channel-main.c | 19

Re: [Spice-devel] [PATCH spice-gtk 5/5] main: send max-clipboard to agent

2013-11-06 Thread Jonathon Jongsma
Is this meant to be a one-time-only configuration value? Or should we also send it down whenever the 'max-clipboard' property changes? - Original Message - From: Marc-André Lureau marcandre.lur...@gmail.com To: spice-de...@freedesktop.org Sent: Wednesday, November 6, 2013 3:25:12 PM

[Spice-devel] [PATCH] Make sure property notifications are done in the main context

2013-11-06 Thread Jonathon Jongsma
Modify g_object_notify_main_conetxt() to work whether it's called from the main context or a coroutine context. Change object notify calls in SpiceSession to use g_object_notify_main_context() instead of g_object_notify(). --- gtk/gio-coroutine.c | 37 -

[Spice-devel] [PATCH spice-gtk] main: send max-clipboard to agent

2013-11-06 Thread Marc-André Lureau
Send configured max-clipboard size to the agent, after receiving agent capabilities. See also spice-protocol patch description: http://lists.freedesktop.org/archives/spice-devel/2013-November/015254.html --- gtk/channel-main.c | 42 +++--- 1 file changed, 39

Re: [Spice-devel] [PATCH] Make sure property notifications are done in the main context

2013-11-06 Thread Marc-André Lureau
- Original Message - Modify g_object_notify_main_conetxt() to work whether it's called from the main context or a coroutine context. Change object notify calls in SpiceSession to use g_object_notify_main_context() instead of g_object_notify(). ack --- gtk/gio-coroutine.c | 37

Re: [Spice-devel] govirt 0.30 plans

2013-11-06 Thread i iordanov
Hi Christophe, This one may turn out to not be an actual issue. I had gotten used to the functionality offered by oVirt Live 0.8 (I think it bundles oVirt 3.0) where I was able to attach as user admin@internal to virtual machines created in the Administrative Console (rather than in the User