[Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

2012-03-01 Thread Arnon Gilboa
MSDN says the following about SetClipboardViewer(): If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL. Seems like the buggy case was no other windows in the clipboard viewer chain, which explains the 3rd party clipboard manager workaround

Re: [Spice-devel] [PATCH 00/20] vdagent mingw compilation

2012-03-01 Thread Arnon Gilboa
ACK series, with Alon's min/max fix. Needs some more testing of both VC++ mingw builds. Christophe Fergeau wrote: Hi, This patch series fixes most of the issues I had when trying to compile vdagent-win with mingw. It also adds an autotools-based build system since as a more convenient way of

Re: [Spice-devel] [PATCH spicec windows 1/1] client/windows: fix SetClipboardViewer error handling rhbz#786554

2012-03-01 Thread Arnon Gilboa
Alon Levy wrote: On Thu, Mar 01, 2012 at 01:10:51PM +0200, Arnon Gilboa wrote: MSDN says the following about SetClipboardViewer(): If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL. Seems like the buggy case was no other windows

Re: [Spice-devel] keyboard and Mouse Fails....

2012-02-08 Thread Arnon Gilboa
. why this happens and how to make sure Spice client is launched from linux machine after VDAgent starts? Appreciated your help. Thanks\Naga. From: Arnon Gilboa agil...@redhat.com To: Naga Mohan Pothula nagamohan.poth...@yahoo.com Cc: Alon Levy al

Re: [Spice-devel] spice inside spice mouse problem

2012-02-07 Thread Arnon Gilboa
Hi Anil, Is vdservice (vdagent) running on both xp guests? Are the vms launched with usbtablet? Regards, Arnon Anil Vettathu wrote: Hi I have a windowsXP VM installed using virt-manager (KVM) on Fedora 16 with spice as the display. Everything is working smooth. The problem is that if I open an

Re: [Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-02-01 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Feb 01, 2012 at 10:48:29AM +0200, Arnon Gilboa wrote: Thanks Alon, adding these lines to the comment: In VDAgent::handle_mouse_event(), mouse event is generated by scaling the received (x,y, display_id) to normalized absolute coordinates (0..0x) on the entire

[Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-01-23 Thread Arnon Gilboa
On any change of the display settings, driven by client message or guest user, normalize all display positions to non-negative coordinates, and update total width and height of the virtual desktop. The bug was due to wrong handling of (non-primary) displays positioned on negative coordinates. ---

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-19 Thread Arnon Gilboa
Gianluca Cecchi wrote: Just to inform that as the host is a laptop, this morning I booted it again and now the w7 vm works, even if not so stably (sometimes in minutes I have to restart agent because it is seen as running by windows but copy/paste doesn't work any more). Please send the

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Thanks for the update. Few questions: 1. Looking at windows device manager, is there any error reported for the virtio-serial driver? 2. Is the error reproduced only on startup, or also when you start the vdservice (RHEV Spice Agent) manually when the machine is up? 3. Is it reproduced for

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Vadim, I think you have reproduced the same (VirtioVDIPort::init::CreateFile() failed: 2). Do you have any idea? it is not repro on linux guests. Thanks, Arnon Gianluca Cecchi wrote: After today updates on my F16 host it seems I'm not able to start vdagent inside my 32bit windows 7. One

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Vadim, I think you have reproduced the same (VirtioVDIPort::init::CreateFile() failed: 2). Do you have any idea? it is not repro on linux guests. Thanks, Arnon Gianluca Cecchi wrote: After today updates on my F16 host it seems I'm not able to start vdagent inside my 32bit windows 7. One

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
Hi Gianluca, Can you please try to reproduce on win xp guest? CC'ing Vadim (virtio-serial windows driver) to the thread. On Wed, Jan 18, 2012 at 2:21 PM, Arnon Gilboa wrote: Thanks for the update. Few questions: 1. Looking at windows device manager, is there any error reported

Re: [Spice-devel] spice vdagent in windows 7 32bit doesn't start on f16 after today update

2012-01-18 Thread Arnon Gilboa
This seems like a different bug, which was already encountered by others in the list. I will continue trying to repro/fix both bugs, and update you accordingly. Vadim - please update regarding the driver. Gianluca Cecchi wrote: On Wed, Jan 18, 2012 at 3:41 PM, Arnon Gilboa wrote: Hi

Re: [Spice-devel] keyboard and Mouse Fails....

2012-01-11 Thread Arnon Gilboa
. Thanks, Mohan. From: Arnon Gilboa agil...@redhat.com To: Naga Mohan Pothula nagamohan.poth...@yahoo.com Cc: Alon Levy al...@redhat.com; David Jaša dj...@redhat.com; spice-devel@lists.freedesktop.org spice-devel@lists.freedesktop.org; Christophe Fergeau cferg

Re: [Spice-devel] keyboard and Mouse Fails....

2012-01-09 Thread Arnon Gilboa
: Naga Mohan Pothula nagamohan.poth...@yahoo.com To: Naga Mohan Pothula nagamohan.poth...@yahoo.com; Arnon Gilboa agil...@redhat.com Cc: David Jaša dj...@redhat.com; spice-devel@lists.freedesktop.org spice-devel@lists.freedesktop.org; Christophe Fergeau cferg...@redhat.com Sent: Thursday, January 5

[Spice-devel] [PATCH vdagent-win] vdagent: fix cursor position sync on multimon rhbz#757819

2012-01-04 Thread Arnon Gilboa
On any change of the display settings, driven by client message or guest user, normalize all display positions to non-negative coordinates, and update total width and height of the virtual desktop. The bug was due to wrong handling of (non-primary) displays positioned on negative coordinates. ---

Re: [Spice-devel] [spice-xpi PATCH 0/3] logging: add various log messages (#753155)

2012-01-02 Thread Arnon Gilboa
ACK series Acked-by: Arnon Gilboa agil...@redhat.com Uri Lublin wrote: Mostly debug messages to log variable values coming in (from java-script) and going out (to spice-client). Uri Lublin (3): logging: add logging of variable setting (#753155) logging: add logging of messages sent

Re: [Spice-devel] keyboard and Mouse Fails....

2011-12-29 Thread Arnon Gilboa
Hi Mohan, see below. Naga Mohan Pothula wrote: Hi Alon, Please refer my inline comments. Thanks/Mohan. From: Alon Levy al...@redhat.com To: Naga Mohan Pothula nagamohan.poth...@yahoo.com Cc: David Jaša dj...@redhat.com; spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH vdagent-win 1/1] vdservice: fix vdagent first launch (during startup) failure handling rhbz#750037

2011-12-27 Thread Arnon Gilboa
Thanks Uri;) I couldn't explain it better. Uri Lublin wrote: On 12/26/2011 12:58 PM, Arnon Gilboa wrote: In case of agent launch failure: if connection state is not active(*), wait for agent launch on the next session connection. Otherwise, the service is stopped. (*) The failure was due

[Spice-devel] [PATCH vdagent-win 1/1] vdservice: fix vdagent first launch (during startup) failure handling rhbz#750037

2011-12-26 Thread Arnon Gilboa
In case of agent launch failure: if connection state is not active(*), wait for agent launch on the next session connection. Otherwise, the service is stopped. (*) The failure was due to system startup timings and logon settings, causing the first agent instance lifetime (before session connect)

Re: [Spice-devel] vdagent-win32 update

2011-11-28 Thread Arnon Gilboa
me at irc.gimp.net #spice to debug the issue online. Waiting for your update, Arnon Mike Hinz wrote: On Thu, 2011-11-24 at 14:56 +0200, Arnon Gilboa wrote: Hi there, No updates for some time. Have you tried using the debug vdagent I posted a while ago? A newer version with several fixes can

Re: [Spice-devel] vdagent supported only for XP?

2011-11-24 Thread Arnon Gilboa
Manual is not updated. It also supports W7, W2k8, W2k3. Todd And Margo Chester wrote: Hi All, Is this still the case? From the spice_uses_manual, page 15, 6.1.2: Note: ▪ The service currently supports only Windows XP. Is there a work around for W7? (Not a real big issue, I hardly ever use

Re: [Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date time rhbz#672828

2011-11-21 Thread Arnon Gilboa
10x, see below. Uri Lublin wrote: On 11/21/2011 09:50 AM, Arnon Gilboa wrote: -use RHEV log format -add log levels macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 common/vdlog.h | 54 +++--- 2 files changed, 39

[Spice-devel] [PATCH v3 vdagent-win] vdlog: change log times to human readable date time rhbz#672828

2011-11-21 Thread Arnon Gilboa
-use RHEV log format -add log levels macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 --- common/vdlog.h | 62 - 2 files changed, 47 insertions(+), 19 deletions(-) diff --git a/common/vdlog.cpp b/common/vdlog.cpp index

[Spice-devel] [PATCH v2 vdagent-win] vdlog: change log times to human readable date time rhbz#672828

2011-11-20 Thread Arnon Gilboa
-use RHEV log format -add log levels macros -remove LOG_ENABLED ifdefs --- common/vdlog.cpp |4 common/vdlog.h | 54 +++--- 2 files changed, 39 insertions(+), 19 deletions(-) diff --git a/common/vdlog.cpp b/common/vdlog.cpp index

[Spice-devel] [PATCH vdagent-win 0/3] fix 3 annoying vdagent issues

2011-11-16 Thread Arnon Gilboa
Arnon Gilboa (3): vdservice: fix vdagent connection termination handling rhbz#750037 vdagent: release clipboard ownership on agent stop desktop switch rhbz#731628 vdlog: change log times to human readable date time rhbz#672828 common/vdlog.h | 23 +++-- vdagent

[Spice-devel] [PATCH vdagent-win 2/3] vdagent: release clipboard ownership on agent stop desktop switch rhbz#731628

2011-11-16 Thread Arnon Gilboa
-use event queue for agent stop desktop switch -exit gracefully on session end --- vdagent/vdagent.cpp | 86 ++ 1 files changed, 65 insertions(+), 21 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 646afed..f0f5243

[Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection termination handling rhbz#750037

2011-11-16 Thread Arnon Gilboa
-extend vdagent wait timeouts -timeout occured when connecting during windows startup, using wan emulator with 1Mbps bandwith, and only when qxl driver is installed. It might be due to spice commands window control which in this case indirectly affects windows startup timings (needs further

[Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date time rhbz#672828

2011-11-16 Thread Arnon Gilboa
ifndef USE_DATE_TIME, use system time instead of secs from system startup --- common/vdlog.h | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/common/vdlog.h b/common/vdlog.h index bb2eb28..995e9d3 100644 --- a/common/vdlog.h +++ b/common/vdlog.h @@

Re: [Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection termination handling rhbz#750037

2011-11-16 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:35PM +0200, Arnon Gilboa wrote: ACK A few comments / questions below. -#define VD_AGENT_TIMEOUT3000 +#define VD_AGENT_TIMEOUT1 Is this required? Do we want to make it configurable? It's way above what

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date time rhbz#672828

2011-11-16 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: ifndef USE_DATE_TIME, use system time instead of secs from system startup Why do we want to keep the old behavior? For users qa, human readable date time (hh:mm:ss) is nicer. For debugging, having

Re: [Spice-devel] Spice agent oddities

2011-10-18 Thread Arnon Gilboa
Hi Damien, Seems like for some reason vdservice closed (handle of) the virtio serial device. Can you please send the relevant qemu output. You should see something like: spice_server_char_device_add_interface: CHAR_DEVICE vdagent handle_dev_input: mouse mode 2 reds_main_handle_message: agent

Re: [Spice-devel] problems with cut n paste - WinXP VM specificall

2011-10-02 Thread Arnon Gilboa
Hi Mike, Can you please: 1. net stop vdservice 2. delete vdservice.log vdagent.log from %windir%\temp 3. net start vdservice 4. copy a text in the guest, paste in host vice versa 5. send us the logs Thanks, Arnon Mike Hinz wrote: On Fri, 2011-09-30 at 22:32 +0300, Alon Levy wrote: Can

Re: [Spice-devel] vdagent\vdservice W 2008R2 guest under Fedora 15

2011-09-25 Thread Arnon Gilboa
Hi Sean, Remember to run cmd as Administrator. Is Z a network drive? put vdservice vdagent on local drive. If it still fails, please send %windir\temp\vdservice.log vdagent.log. Regarding the qxl driver, refer to the installing section in http://spice-space.org/page/WinQXL. Thanks, Arnon

Re: [Spice-devel] problem for vdagent

2011-08-09 Thread Arnon Gilboa
I guess you are forking vdagent ;) Do you call CreateProcess() from vdagent? or vdservice? upon receiving specific msg? what's the GetLastError()? if used from vdagent, why not just use MessageBox()? what OS are you using? Please provide all the details + relevant patch. 王耀峰 wrote: Hi Arnon:

Re: [Spice-devel] [PATCH] qxl: allowing the command rings to be not empty when spice worker is stopped RHBZ #728984

2011-08-09 Thread Arnon Gilboa
Acked-by: Arnon Gilboa agil...@redhat.com Yonit Halperin wrote: same as 8927cfbba232e28304734f7afd463c1b84134031, but for qxl_check_state, that was triggered by qxl_pre_load (which calls qxl_hard_reset, which calls qxl_soft_reset), and caused the migration target to crash. --- hw/qxl.c

Re: [Spice-devel] Problems building 0.9.0

2011-08-04 Thread Arnon Gilboa
updated installed spice-protocol accordingly? Damien Churchill wrote: Trying to package up 0.9.0 I'm encountering the following issues: 1. I'm having to replace all use of INLINE with inline 2. I'm having to force disabling -Werror by patching configure I imagine I'm doing something wrong so

Re: [Spice-devel] Spice Windows 7 display driver?

2011-08-02 Thread Arnon Gilboa
Updated the zip with RedHat signed drivers. Enjoy, Arnon Arnon Gilboa wrote: Hi Nathan, Get the updated test-signed driver from the download page, or directly: http://www.spice-space.org/download/binaries/qxl-win_20110802.zip Arnon Nathan Lager wrote: -BEGIN PGP SIGNED MESSAGE- Hash

Re: [Spice-devel] [PATCH vdagent-win] virtio_vdi_port: if async read returns with ERROR_OPERATION_ABORTED, cancel pending (rhbz#725734)

2011-08-01 Thread Arnon Gilboa
Uri Lublin wrote: On 08/01/2011 11:27 AM, Arnon Gilboa wrote: Therefore in case of virtio-serial ReadFile timeout (new driver behavior), the next VirtioVDIPort::read() call by the service will be performed, since it is now (!_read.pending). Ack. Do we need something similar

Re: [Spice-devel] [PATCH] common/backtrace.h: disable for WIN32

2011-07-31 Thread Arnon Gilboa
ack Alon Levy wrote: This also catches mingw32 which is probably fine, but at least it fixes the build on visual studio. --- common/backtrace.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/common/backtrace.h b/common/backtrace.h index 3b0c132..21b6b67 100644 ---

Re: [Spice-devel] [PATCH v2] server/red_dispatcher: fix wrong resolution set for tablet

2011-07-31 Thread Arnon Gilboa
ack, although I did not really get why the ref got broken. Alon Levy wrote: when changing resolutions due to the new async code paths the surface creation command was kept by reference, and later, when the red_worker signaled completion by calling async_complete the mouse mode was updated using

Re: [Spice-devel] [PATCH] client: fix 30s timeout regression

2011-07-30 Thread Arnon Gilboa
ack Christophe Fergeau wrote: Changelog from Arnon Gilboa, patch from me: Commit eb6f55409412 caused the following regression: When client runs without the auto-conf or disable-effects options (either from CLI or controller), which is the case when using Spice from Admin Portal, the client

Re: [Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-24 Thread Arnon Gilboa
Naga Mohan Pothula wrote: Hi, Launched windows7 Guest image with Spice v0.8 in fullscreen mode with auto-config from windows client. Spice window hangs frequently while doing shutdown or restart. if it doesn't hang then shutdown process is slow. This issue doesn't happen if we don't launch in

[Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
Arnon Gilboa (6): vdservice: add control events RHBZ #719140 #722980 vdservice: use overlap ConnectNamedPipe() in launch_agent() vdservice: clean agent proc handle in kill_agent() vdservice: extract init_vdi_port() vdagent: remove whitespaces vdagent: add casting vdagent

[Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
prevent race between service control manager (SCM) the service main thread. use events for stop, logon, agent restart. --- vdservice/vdservice.cpp | 70 +- 1 files changed, 44 insertions(+), 26 deletions(-) diff --git a/vdservice/vdservice.cpp

[Spice-devel] [PATCH vdagent-win 2/6] vdservice: use overlap ConnectNamedPipe() in launch_agent()

2011-07-24 Thread Arnon Gilboa
passing NULL is buggy when pipe opened with FILE_FLAG_OVERLAPPED --- vdservice/vdservice.cpp | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 4d4937f..7ca9db8 100644 ---

[Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
prevent usage of a dead proc handle in the WaitFor() --- vdservice/vdservice.cpp | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 7ca9db8..f61c318 100644 --- a/vdservice/vdservice.cpp +++

[Spice-devel] [PATCH vdagent-win 4/6] vdservice: extract init_vdi_port()

2011-07-24 Thread Arnon Gilboa
--- vdservice/vdservice.cpp | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index f61c318..3abc146 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -77,6 +77,7 @@ private:

[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

2011-07-24 Thread Arnon Gilboa
--- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index 9bd1852..0eada52 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -67,7 +67,7 @@ void

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
Alon Levy wrote: On Sun, Jul 24, 2011 at 01:48:13PM +0300, Arnon Gilboa wrote: prevent race between service control manager (SCM) the service main thread. use events for stop, logon, agent restart. --- vdservice/vdservice.cpp | 70 +- 1 files

Re: [Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
Alon Levy wrote: On Sun, Jul 24, 2011 at 01:48:15PM +0300, Arnon Gilboa wrote: prevent usage of a dead proc handle in the WaitFor() Is this usage in fill_agent_event? can you make a note of that in the commit message? Otherwise ACK. Right, will add a note

[Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
use thread-safe control command queue Arnon Gilboa (6): vdservice: add control events RHBZ #719140 #722980 (v2) vdservice: use overlap ConnectNamedPipe() in launch_agent() vdservice: clean agent proc handle in kill_agent() vdservice: extract init_vdi_port() vdagent: remove whitespaces

[Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
-prevent race between service control manager (SCM) the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue --- vdservice/vdservice.cpp | 85 +++--- 1 files changed, 57 insertions(+), 28 deletions(-) diff

[Spice-devel] [PATCH vdagent-win 2/6] vdservice: use overlap ConnectNamedPipe() in launch_agent()

2011-07-24 Thread Arnon Gilboa
passing NULL is buggy when pipe opened with FILE_FLAG_OVERLAPPED --- vdservice/vdservice.cpp | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 009f949..8c34f59 100644 ---

[Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
fill_agent_events() will not add it to the events used by WaitFor(), preventing usage of a dead process handle. --- vdservice/vdservice.cpp | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 8c34f59..e09828a

[Spice-devel] [PATCH vdagent-win 4/6] vdservice: extract init_vdi_port()

2011-07-24 Thread Arnon Gilboa
--- vdservice/vdservice.cpp | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index e09828a..bc7ec41 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -80,6 +80,7 @@ private:

[Spice-devel] [PATCH vdagent-win 5/6] vdagent: remove whitespaces

2011-07-24 Thread Arnon Gilboa
--- vdagent/vdagent.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 1ebf1e4..646afed 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -565,11 +565,11 @@ bool

[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

2011-07-24 Thread Arnon Gilboa
--- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index 9bd1852..0eada52 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -67,7 +67,7 @@ void

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
Arnon Gilboa wrote: NAK -prevent race between service control manager (SCM) the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH vdagent-win v3 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
-prevent race between service control manager (SCM) the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue --- vdservice/vdservice.cpp | 83 +++ 1 files changed, 55 insertions(+), 28 deletions(-) diff

Re: [Spice-devel] Problems compiling SPICE Windows client SDK 7.1

2011-07-06 Thread Arnon Gilboa
John A. Sullivan III wrote: snip We've made considerable progress. We do not have VS2008 as we are not a Windows shop and I assume in my Windows ignorance that that's a paid licensed product so we'd have track which of us could work on it and which couldn't so we've tried to make due with just

Re: [Spice-devel] Problems compiling SPICE Windows client SDK 7.1

2011-07-05 Thread Arnon Gilboa
Hi John, See my comments below. Arnon John A. Sullivan III wrote: Hello, all. Being a Windows ignoramus, I am having a nightmare of a time compiling the Windows client on our Windows 7 build system. I'll recount them for other ignorami and to ask for help for the things I could not figure

Re: [Spice-devel] Possible Windows vdagent problems

2011-07-05 Thread Arnon Gilboa
John A. Sullivan III wrote: On Tue, 2011-07-05 at 09:44 +0300, Arnon Gilboa wrote: Hi John, See my comments below. Arnon John A. Sullivan III wrote: Hello, all. I'm spinning this off of the Unfair Comparisons with RDP thread as that one is getting a bit long. However, in it, Yaniv

Re: [Spice-devel] Building Windows Client?

2011-06-21 Thread Arnon Gilboa
1. get latest spice spice-protocol from git 2. get extract latest wspice libs - currently wspice-x86_20110308.zip wspice-x64_20110308.zip from http://www.spice-space.org/download.html 3. assuming you have spice-dir, spice-protocol-dir, wspice-dir, build-dir: set REDC_BUILD_DIR=build-dir set

Re: [Spice-devel] [PATCH qxl-win v3 0/8] cleanups and allow checked builds of qxl driver

2011-06-20 Thread Arnon Gilboa
ack series Alon Levy wrote: v1-v2: remove #if 0'd code and merge WAIT_FOR_EVENT fixes to first patch. v2-v3: added #if DBG around FreeMem verbose debug and EngDebugBreak. This is part 1 of 4 for the S3 support: 1. cleanup + checked build (this one) + FreeSurface bugfix (Yonit). 2. QXL_IO_LOG

Re: [Spice-devel] windows CBE

2011-06-13 Thread Arnon Gilboa
Lubos Kocman wrote: Hello, does anybody have working windows build environment for spice-client/vdagent? of course, most of us at the spice team (me, Yonit, Alon, Red Hat brew etc...) I've tried to set it up by using VC seems like I got rid of most of #include errors but I'm not sure if

Re: [Spice-devel] QXL driver under Win7/X86_64

2011-06-12 Thread Arnon Gilboa
Try putting the signed drivers inf file in a temp folder, and install it from Device Manager - Display adapters. I am working with the driver in Win7x64 but never tried just copying the files as written in the wikipage. Arnon Dyweni - Spice-Devel wrote: Hi List/Phil! I need help setting up

[Spice-devel] [PATCH 1/1] client/windows: enable image randomization (ASLR) rhbz#701111

2011-05-29 Thread Arnon Gilboa
Enable image randomized base address, hindering some types of security attacks by making it more difficult for an attacker to predict target addresses. --- client/windows/redc.vcproj |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/windows/redc.vcproj

[Spice-devel] [PATCH 1/2] client/windows: remove slash from x64 build dir

2011-05-24 Thread Arnon Gilboa
otherwise x64 is built in root if REDC_BUILD_DIR is not defined --- client/windows/redc.vcproj |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/windows/redc.vcproj b/client/windows/redc.vcproj index 38bcb36..519c96e 100644 --- a/client/windows/redc.vcproj +++

Re: [Spice-devel] Why doesn't qxl 64bit windows binary driver upload to spice download page?

2011-05-23 Thread Arnon Gilboa
I can build upload the updated upstream x64/x86 windows qxl, but not Red Hat signed. In order to use the driver on Win7x64 you will need to hack it a bit. http://www.ngohq.com/home.php?page=dseo Seems reasonable? mi.u...@gmail.com wrote: Hi, everyone. I have a question about 64bit qxl windows

Re: [Spice-devel] Why doesn't qxl 64bit windows binary driver upload to spice download page?

2011-05-23 Thread Arnon Gilboa
David Jaša wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dne 23.5.2011 17:12, Arnon Gilboa napsal(a): In order to use the driver on Win7x64 you will need to hack it a bit. These sort of steps worked for me on 2008 R2 and 7 x64: 1. download unpacked drivers (e.g. .cat, .sys

[Spice-devel] [PATCH 0/2] client/windows: fix broken build

2011-05-22 Thread Arnon Gilboa
Arnon Gilboa (2): common: add WIN64 ifdef for spice_bit_find_msb (fix broken windows x64 build) client/windows: remove precompiled header for common.h (fix broken windows debug build) client/windows/redc.vcproj |8 common/bitops.h|4 ++-- 2 files changed

[Spice-devel] [PATCH 2/2] client/windows: remove precompiled header for common.h (fix broken windows debug build)

2011-05-22 Thread Arnon Gilboa
-Release currently doesn't use precompiled headers at all -Debug is broken since common/*.c files don't include common.h -PCH can be enabled for all but specifically-chosen c-files --- client/windows/redc.vcproj |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Spice-devel] Windows 7 64bit QXL driver not digitally signed

2011-05-12 Thread Arnon Gilboa
As I know, we currently don't sign the upstream windows driver. However, this tool will do what you need. http://www.ngohq.com/home.php?page=dseo John Daily wrote: Hi All, I've successfully built the 64bit driver for my Windows 7 64 bit VM. However, Windows will not use the driver after

Re: [Spice-devel] Clipboard sharing...

2011-05-12 Thread Arnon Gilboa
Andrew Cathrow wrote: - Original Message - From: Naga Mohan Pothula nagamohan.poth...@yahoo.com To: spice-devel@lists.freedesktop.org Sent: Wednesday, May 11, 2011 6:35:13 PM Subject: [Spice-devel] Clipboard sharing... Hi, I downloaded Spice v0.8.1/v0.8.0 and tested for Clipboard

[Spice-devel] [PATCH spice-protocol] macros: define INLINE

2011-05-12 Thread Arnon Gilboa
needed for spice/common files used by the client, server qxl driver. in windows _inline works for both c/c++, while inline is c++ only. compiling the client with mixed c/c++ code required this define. --- spice/macros.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

[Spice-devel] [PATCH 0/6] client: fix broken windows build

2011-05-12 Thread Arnon Gilboa
Arnon Gilboa (6): client/windows: init PACKAGE_VERSION client/windows: inc version to 0,9,0,0 client/windows: add common\ssl_verify.c/h to project common: fix ssl_verify windows build errors client/windows: undef SIZE_MAX in stdint.h common: use INLINE instead of inline client

[Spice-devel] [PATCH 1/6] client/windows: init PACKAGE_VERSION

2011-05-12 Thread Arnon Gilboa
in windows, we set PACKAGE_VERSION to the binary version since we don't have config.h as generated by linux configure --- client/common.h |2 ++ client/windows/main.cpp |6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/client/common.h b/client/common.h

[Spice-devel] [PATCH 2/6] client/windows: inc version to 0,9,0,0

2011-05-12 Thread Arnon Gilboa
--- client/windows/redc.rc | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/client/windows/redc.rc b/client/windows/redc.rc index 6c717df..e6780cc 100644 --- a/client/windows/redc.rc +++ b/client/windows/redc.rc @@ -60,8 +60,8 @@ ALT_IMAGE_RES_IDBITMAP

[Spice-devel] [PATCH 3/6] client/windows: add common\ssl_verify.c/h to project

2011-05-12 Thread Arnon Gilboa
disable WarnAsError, due to c/c++ warnings --- client/windows/redc.vcproj | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/client/windows/redc.vcproj b/client/windows/redc.vcproj index 87d018c..17032f7 100644 --- a/client/windows/redc.vcproj +++

Re: [Spice-devel] [PATCH] client: fix return code when missing host

2011-05-12 Thread Arnon Gilboa
ack Alon Levy wrote: --- client/application.cpp |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index e308ad1..606f7e2 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2437,6 +2437,7 @@ bool

Re: [Spice-devel] [PATCH 2/6] client/windows: inc version to 0, 9, 0, 0

2011-05-12 Thread Arnon Gilboa
Christophe Fergeau wrote: On Thu, May 12, 2011 at 12:37:27PM +0300, Arnon Gilboa wrote: @@ -111,7 +111,7 @@ RED_ICON_RES_ID ICONspice.ico #if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_NEUSD) #ifdef _WIN32 LANGUAGE LANG_NEUTRAL, SUBLANG_SYS_DEFAULT -#pragma

Re: [Spice-devel] [PATCH 6/6] common: use INLINE instead of inline

2011-05-12 Thread Arnon Gilboa
Christophe Fergeau wrote: On Thu, May 12, 2011 at 12:37:31PM +0300, Arnon Gilboa wrote: needed for spice/common files used by the client, server qxl driver. in windows _inline works for both c/c++, while inline is c++ only. compiling the client with mixed c/c++ code required this define

[Spice-devel] [PATCH] common: add WIN64 ifdef for spice_bit_find_msb

2011-05-12 Thread Arnon Gilboa
inline __asm is not supported in x64 --- common/bitops.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/bitops.h b/common/bitops.h index 4823662..449409b 100644 --- a/common/bitops.h +++ b/common/bitops.h @@ -27,7 +27,7 @@ extern C { #endif -#ifdef WIN32

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-05-01 Thread Arnon Gilboa
Emre Erenoglu wrote: snap The previous version didn't work. I've just tested the new one from today in w7 sp1 guest 32bit and it works there too ;-) Thanks! Tested only copy/paste from/to guest/host with notepad and putty @guest and gedit @host Well done new vdagent works for me in 32

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Arnon Gilboa
Yep, I will send a patch exactly for that update the zip - today. Sorry about the delay, Arnon Emre Erenoglu wrote: Dear Developers, I'm trying to install the vdagent vdservice to an up to date Windows 2003 Server. The OS version is 5.2.3790. The current vdagent vdservice distributed from

[Spice-devel] [PATCH 1/3] vdservice: don't close pipe if overlapped I/O event is not in signaled state (rhbz#667777)

2011-04-28 Thread Arnon Gilboa
which is beacuse ReadFile completed successfully without pending and the data was already consumed --- vdservice/vdservice.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 175587c..85fa182 100644 ---

[Spice-devel] [PATCH 3/3] vdagent: remove dependency on qxl driver (rhbz#683166)

2011-04-28 Thread Arnon Gilboa
-don't fail to start when no qxl driver installed -if qxls found use them, otherwise just use enumerated non-mirror devices -currently qxl/non-qxl multimon mix is not supported --- vdagent/desktop_layout.cpp | 104 ++- vdagent/desktop_layout.h |1 +

Re: [Spice-devel] [PATCH 1/3] vdservice: don't close pipe if overlapped I/O event is not in signaled state (rhbz#667777)

2011-04-28 Thread Arnon Gilboa
Alon Levy wrote: ACK series. A better comment for the third patch would be to specify what inconsistent means - that there are some devices with a QXL driver and some without. 10x, you are absolutely right. ___ Spice-devel mailing list

Re: [Spice-devel] vdagent vdservice and windows 2003 server

2011-04-28 Thread Arnon Gilboa
Gianluca Cecchi wrote: On Thu, Apr 28, 2011 at 12:34 PM, Gianluca Cecchi gianluca.cec...@gmail.com wrote: On Thu, Apr 28, 2011 at 11:54 AM, Arnon Gilboa agil...@redhat.com wrote: Hi Emre, Please try the updated binaries at: http://www.spice-space.org/download/binaries/vdagent

Re: [Spice-devel] win2k support

2011-04-10 Thread Arnon Gilboa
Hi, As I know qxl drivers were never really tested on Win2K. What do you see under the device manager display adapters? any error notification? Can you choose from the display setting? Regards, Arnon Konstantin Svist wrote: Hi, I have a stupid question: do spice video drivers exist that work

Re: [Spice-devel] [PATCH] driver: allowed modes: remove limit of 480 = {X, Y} = 2000

2011-03-24 Thread Arnon Gilboa
NAK, patch seems ok but missing version bump in miniport rc file as well Alon Levy wrote: Later todo is to check that there is available video memory for this, but that requires either access to PDev or probably dynamically checking anyway to make sure we actually fit. Another option is to

Re: [Spice-devel] [PATCH spice-win-qxl] spice: windows qxl drivers: support x64 build

2011-03-16 Thread Arnon Gilboa
The Ha wrote: Hi Alon Test setup: Windows 7 64 bit guest, run on RHEL 6 KVM Linux guests using xserver-xorg-video-qxl almost work. YouTube flash inverted when using Windows Spice Client but that is another thread. QXL drivers tested and all fail to load. It uses generic vga driver. *

[Spice-devel] [PATCH] client/windows: cleanup vcproj based on updated libs

2011-03-08 Thread Arnon Gilboa
using updated windows libraries: http://www.spice-space.org/download/stable/wspice-x86_08032011.zip http://www.spice-space.org/download/stable/wspice-x64_08032011.zip -remove IgnoreDefaultLibraryNames=MSVCRT.lib, since pixman is now compiled using MT threading model similar to other libraries. It

Re: [Spice-devel] vdagent on Windows 7

2011-02-12 Thread Arnon Gilboa
Hi Júlíus, Next time don't spend too much time on such issues, but ping in the irc channel. Are you using Win7x64? Do you have the qxl virtio-serial drivers installed and working? Please send the vdservice/vdagent logs from %WINDIR%\temp. Regards, Arnon Júlíus Bess wrote: Hello, Does

[Spice-devel] [PATCH spice 1/1] client/windows: use SPICE_COMMON_DIR instead of ..\..\..\spice-protocol in project include dirs

2011-02-09 Thread Arnon Gilboa
relative path to another git tree is a bit ugly, since it requires spice-protocol to be in a specific location. SPICE_COMMON_DIR is also used in windows qxl and vdagent, so it's netural using it here as well. --- client/windows/redc.vcproj |8 1 files changed, 4 insertions(+), 4

[Spice-devel] [PATCH spice-win-qxl] qxl: support device surprise removal

2011-02-03 Thread Arnon Gilboa
Part of the WHQL generic device qualification tests is the Surprise Removal, a case which is unrealistic for the qxl display device in the real world. However, in surprise removal the cursor and display events are not set, so we need to wait with a timeout in order not to wait forever. ---

[Spice-devel] [PATCH spice-protocol] define spice_mb MemoryBarrier for WIN64

2011-02-02 Thread Arnon Gilboa
__asm is not supported on _WIN64, so use macro instead required for Windows x64 guest display driver (qxldd.dll) --- spice/barrier.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/spice/barrier.h b/spice/barrier.h index 8c81c86..710da09 100644 ---

Re: [Spice-devel] [PATCH] Add build script for qxl using the given DDK, configuration and platform

2011-01-27 Thread Arnon Gilboa
NACK, better scripts already found :) Arnon Gilboa wrote: Necessary for build scripting (e.g. from Cygwin) --- make.bat | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 make.bat diff --git a/make.bat b/make.bat new file mode 100644 index 000

Re: [Spice-devel] [PATCH 1/3] client: --help should not need platform initialization

2011-01-27 Thread Arnon Gilboa
Ack, although see comments below Alon Levy wrote: separate initialization into before command line parsing and after, call later only if command line parsing succeeds (in particular, it fails if --help is given). --- client/application.cpp | 90

<    1   2   3   >