[Spice-devel] libcacard: src/link_test.c in the git tree

2015-10-10 Thread Michael Tokarev
Hi. I noticed an extra file in the git tree in libcacard source directory, src/link_test.c, which is not present in the source tarball. Is it really needed there? Thanks, /mjt ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] libcacard: linking with too many libs

2015-10-09 Thread Michael Tokarev
Hello. I tried to package libcacard, and come across a small thing. The library is uselessly linked with too many libs from the nss family, namely, the following libs are not needed: libplds4.so libplc4.so libssl3.so libsmime3.so libnssutil3.so (only libnss3.so is actually needed, it seems,

Re: [Spice-devel] [PATCH 2/2] do not link spice with libcacard

2015-10-09 Thread Michael Tokarev
09.10.2015 16:36, Christophe Fergeau wrote: >> --- a/spice-common/m4/spice-deps.m4 >> +++ b/spice-common/m4/spice-deps.m4 >> @@ -58,7 +58,8 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [ >>fi >> fi >> AS_VAR_APPEND([$1_CFLAGS], [' $(SMARTCARD_CFLAGS)']) >> -AS_VAR_APPEND([$1_LIBS],

[Spice-devel] [PATCH 2/2] do not link spice with libcacard

2015-10-08 Thread Michael Tokarev
None of the libcacard symbols are actually used by the library, only the header files, so there's no need to link with libcacard. Signed-off-by: Michael Tokarev <m...@tls.msk.ru> --- spice-common/m4/spice-deps.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spice-

[Spice-devel] [PATCH 1/2] use variables foo_LIBS and foo_CFLAGS in deps, not their values

2015-10-08 Thread Michael Tokarev
these variables during make time. So instead of AC_VAR_APPEND([$1_CFLAGS], [" $foo_CFLAGS"]) which adds _contents_ of $foo_CFLAGS, use AC_VAR_APPEND([$1_CFLAGS], [' $(foo_CFLAGS)']) which adds reference to foo_CFLAGS variable instead. Signed-off-by: Michael Tokarev <m...@tls.msk.ru> -

Re: [Spice-devel] [PATCH (v2)] Small cleanups to address compiler warnings

2013-02-11 Thread Michael Tokarev
11.02.2013 18:49, Serge Hallyn wrote: Changelog: Feb 11: Address feedback by Marc-André: Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Signed-off-By: Michael Tokarev m...@tls.msk.ru (Or you can use Reviewed-by, whatever). server/tests/basic_event_loop.c | 4 ++-- server/tests

Re: [Spice-devel] Disappearing mouse cursor in Autocad 2006 drawing window in WinXP VM with Spice+QXL video driver

2013-02-10 Thread Michael Tokarev
10.02.2013 11:51, Giuseppe Bilotta wrote: Hello all, I've been addressed to this mailing list after reporting the issue mentioned in the topic on #spice. Here are the details of the issue I'm seeing. This machine has a Virtual Machine with Windows XP installed to be able to run AutoCAD 2006.

[Spice-devel] [PATCH] spice-common: remove version construction

2013-02-07 Thread Michael Tokarev
-version-gen from AC_INIT and replaces it with a string noversion, to stop these scary messages from being produced. Signed-off-by: Michael Tokarev m...@tls.msk.ru --- spice-common/configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common/configure.ac b/spice

[Spice-devel] Address a compilation warning due to missing typecast

2013-02-07 Thread Michael Tokarev
Author: Serge Hallyn serge.hal...@ubuntu.com This is a trivial typecast fix, -- all surrounding lines cast lines_end to PIXEL* but one is apparently forgotten. This fixes a compiler warning about incompatible types in assignment. --- a/spice-common/common/lz_compress_tmpl.c +++

[Spice-devel] [PATCH] Fix numerous compiler warnings due to wrong types and remove useless typecasts

2013-02-07 Thread Michael Tokarev
This is a cleanup/fix patch that addresses numerous small defects all around the code. Author: Serge Hallyn serge.hal...@ubuntu.com Signed-off-By: Serge Hallyn serge.hal...@ubuntu.com Signed-off-By: Michael Tokarev m...@tls.msk.ru --- a/server/tests/basic_event_loop.c +++ b/server/tests

Re: [Spice-devel] [PATCH] spice-common: remove version construction

2013-02-07 Thread Michael Tokarev
07.02.2013 21:02, Marc-André Lureau wrote: - Mensaje original - Version string isn't used anywhere in spice-common, and there's no version for spice-common module per se, either. Hoever, configure.ac has this: AC_INIT([spice-common], [m4_esyscmd(build-aux/git-version-gen

Re: [Spice-devel] Bug with qxl vga memory settings

2013-01-25 Thread Michael Tokarev
[Adding spice-devel@ back - I don't think we should drop this list, even if it will be a repost there.] I've just a small comment below, -- I haven't gotten to testing it myself yet, was too busy today to do anything useful. 25.01.2013 18:37, Fabio Fantoni wrote: Debugging qxl problem with xen

Re: [Spice-devel] Bug with qxl vga memory settings

2013-01-25 Thread Michael Tokarev
25.01.2013 18:51, Michael Tokarev wrote: I saw also that qemu 1.3 debian package use vgabios from vgabios 0.7 package instead of seabios 1.7.2 package. Can be a problem with qxl? This is wrong. qemu-1.3, and current qemu git tree, uses vgabios 0.7a from http://www.nongnu.org/vgabios

Re: [Spice-devel] [spice] configure: fix cp from network to smartcard

2013-01-22 Thread Michael Tokarev
22.01.2013 16:13, Christophe Fergeau wrote: Hey Fidencio, On Sat, Jan 12, 2013 at 07:03:46PM -0200, Fabiano Fidêncio wrote: --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index fc0216f..cfa0cbf 100644 --- a/configure.ac

Re: [Spice-devel] change the Monitor refresh rate of VM

2012-08-16 Thread Michael Tokarev
2012/8/15 flooding Controlled flooding2...@gmail.com mailto:flooding2...@gmail.com Hi all: I am now using spice now, but stucked by some problems. My vm is XP, and I can the monitor refresh rate! It is always 100HZ, and it it too high, How can I decrease it ? What

Re: [Spice-devel] change the Monitor refresh rate of VM

2012-08-16 Thread Michael Tokarev
On 16.08.2012 11:51, flooding Controlled wrote: I just want to make sure that is could be changed or not. And, I think 100HZ is too high, normally 75~85HZ is OK for PC, and 60HZ for laptop. Too high for what? The refresh rate is how often a (physical) video card sends information to a

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 12:48, Alexander Larsson wrote: On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote: I plan to use this patch in the upcoming Debian release, codename wheezy, to get rid of celt codec library there, since we decided celt051 is not going to be included, but it is obviously

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 13:15, Alexander Larsson wrote: [] Its not incompatible, like I i said in my (Well, .. part above. But what it means is that it will send audio as PCM instead of compressing it. This is much larger, and will cause anyone using the debian spice client to connect to a spice server

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 14:27, Marc-André Lureau wrote: On Mon, Jun 4, 2012 at 11:33 AM, Christophe Fergeau cferg...@redhat.com wrote: Makes sense to me though I've only looked quickly through it. Since it works for you, I'm in favour of committing it if noone disagrees. I also don't like these

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 12.06.2012 15:35, Alexander Larsson wrote: On Tue, 2012-06-12 at 14:31 +0400, Michael Tokarev wrote: On 12.06.2012 13:15, Alexander Larsson wrote: [] Its not incompatible, like I i said in my (Well, .. part above. But what it means is that it will send audio as PCM instead of compressing

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-12 Thread Michael Tokarev
On 13.06.2012 04:57, Brian Vetter wrote: As an outside observer with nothing really at stake here, it would seem that rather than Debian providing a hobbled version of the spice client that uses raw audio (disables Celt), they offer up a patch for both the server and the client that

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-05 Thread Michael Tokarev
On 04.06.2012 16:28, Alon Levy wrote: On Mon, Jun 04, 2012 at 11:33:22AM +0200, Christophe Fergeau wrote: Makes sense to me though I've only looked quickly through it. Since it works for you, I'm in favour of committing it if noone disagrees. I agree. Would you do a review and ack? Please

[Spice-devel] [PATCH] make celt to be optional

2012-06-02 Thread Michael Tokarev
server. I didn't check old clients and servers, however. In all cases, raw audio stream is being choosen and used. But since I don't really know how spice works internally, maybe I didn't perform correct testing. Please consider applying. Signed-off-By: Michael Tokarev m...@tls.msk.ru Cc: Ron Lee

[Spice-devel] [PATCH] link libspice server with libm libpthread

2012-06-02 Thread Michael Tokarev
/Makefile.am, to libspice_server_la_LIBADD variable. Signed-off-By: Michael Tokarev m...@tls.msk.ru --- server/Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/server/Makefile.am b/server/Makefile.am index 97e7dfe..14e5694 100644 --- a/server/Makefile.am +++ b/server/Makefile.am