[Spice-devel] [PATCH] smartcard: add channel

2010-10-06 Thread Alon Levy
--- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h index 3317536..76fec0c 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -327,6 +327,7 @@ enum { SPICE_CHANNEL_PLAYBACK, SPICE_CHANNEL_RECORD,

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-16 Thread Alexander Larsson
On Tue, 2010-09-14 at 14:50 -0400, Alon Levy wrote: - Gerd Hoffmann kra...@redhat.com wrote: I don't think this is a good idea. This is just a chardev passthrough, right? If so, then we should just make it that. Name it 'chardev' or 'datapipe' or something simliar. Have a

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Gerd Hoffmann
Hi, +enum { +SPICE_MSG_SMARTCARD_DATA = 1, + +SPICE_MSG_END_SMARTCARD +}; + +enum { +SPICE_MSGC_SMARTCARD_DATA = 1, + +SPICE_MSGC_END_SMARTCARD +}; I don't think this is a good idea. This is just a chardev passthrough, right? If so, then we should just make it that. Name

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Alexander Larsson
On Mon, 2010-09-13 at 13:58 -0400, Alon Levy wrote: --- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h Is this change generated? If not, just update the spice.proto and run ./spice_codegen.py -e spice.proto

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Mon, 2010-09-13 at 13:58 -0400, Alon Levy wrote: --- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h Is this change generated? If not, just update

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: Hi, +enum { +SPICE_MSG_SMARTCARD_DATA = 1, + +SPICE_MSG_END_SMARTCARD +}; + +enum { +SPICE_MSGC_SMARTCARD_DATA = 1, + +SPICE_MSGC_END_SMARTCARD +}; I don't think this is a good idea. This is just a chardev

[Spice-devel] [PATCH] smartcard: add channel

2010-09-13 Thread Alon Levy
--- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h index 3317536..6c65d61 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -327,6 +327,7 @@ enum { SPICE_CHANNEL_PLAYBACK, SPICE_CHANNEL_RECORD,