On 05/22/2012 01:29 AM, Marc-André Lureau wrote:
Hi Marc-Andre,
Thanks for the review.
I'll fix all your comments that are not mentioned below.
+void spice_usb_drv_install_finished(SpiceUsbDeviceManager *self,
+ libusb_device *device, int status)
nitpick, It's a bit better to keep same
Hi Hans,
Thanks for your review and comments.
On 05/22/2012 11:24 AM, Hans de Goede wrote:
On 05/20/2012 06:34 PM, Uri Lublin wrote:
- Added win-usb-driver-install.[ch]
- Added usbclerk.h
if OS_WIN32
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index 2b6ce28..c373447
On Tue, May 22, 2012 at 12:29:42AM +0200, Marc-André Lureau wrote:
Hi
+void spice_usb_drv_install_finished(SpiceUsbDeviceManager *self,
+ libusb_device *device, int status)
nitpick, It's a bit better to keep same prefix for function name:
perhaps
Hi,
Comments inline.
On 05/20/2012 06:34 PM, Uri Lublin wrote:
- Added win-usb-driver-install.[ch]
- Added usbclerk.h
Operation (on Windows, spice-gtk point of view):
- After some sanity checks, just before redir'ing a USB device
a libusb driver needs to be installed (before libusb can
Hi
+void spice_usb_drv_install_finished(SpiceUsbDeviceManager *self,
+ libusb_device *device, int status)
nitpick, It's a bit better to keep same prefix for function name:
perhaps spice_usb_device_manager_win_device_connect() ?
+{
+ if (status) {
any value of status != 0? I realized
- Added win-usb-driver-install.[ch]
- Added usbclerk.h
Operation (on Windows, spice-gtk point of view):
- After some sanity checks, just before redir'ing a USB device
a libusb driver needs to be installed (before libusb can open/access it).
- A connection (NamedPipe) is established with
