See notes below.
I guess you defined it only for ref counting, otherwise you would have
used simply a struct (similar to _SpiceUsbDevicePrivate) ?
btw, why define Private and getters and not putting it all public?
Is it the the right gobject-way? no shorter way to do it? (see
Hi Arnon,
Thanks for reviewing.
On 06/28/2012 09:45 AM, Arnon Gilboa wrote:
See notes below.
I guess you defined it only for ref counting, otherwise you would have
used simply a struct (similar to _SpiceUsbDevicePrivate) ?
btw, why define Private and getters and not putting it all public?
Is
On Thu, Jun 28, 2012 at 11:18 AM, Uri Lublin u...@redhat.com wrote:
IIUC, the class-name-priv.h file is only included in code inside the
library,
while class-name.h can be included in code outside of the library too.
Good rule, it's followed more or less in spice-gtk (because everything
is not
On 06/28/2012 01:38 PM, Marc-André Lureau wrote:
On Thu, Jun 28, 2012 at 11:18 AM, Uri Lublinu...@redhat.com wrote:
IIUC, theclass-name-priv.h file is only included in code inside the
library,
whileclass-name.h can be included in code outside of the library too.
Good rule, it's followed more
On 06/28/2012 12:49 PM, Christophe Fergeau wrote:
On Thu, Jun 28, 2012 at 04:46:33AM +0300, Uri Lublin wrote:
diff --git a/gtk/spice-usb-device.c b/gtk/spice-usb-device.c
+void spice_usb_device_set_info(SpiceUsbDevice *self, libusb_device *libdev)
When USE_USBREDIR is not defined, there still
---
gtk/spice-usb-device-priv.h | 38 +
gtk/spice-usb-device.c | 124 +++
gtk/spice-usb-device.h | 57
3 files changed, 219 insertions(+), 0 deletions(-)
create mode 100644 gtk/spice-usb-device-priv.h
create
