Re: [Spice-devel] 0001-a patch for syncing keyboard lock status

2014-04-02 Thread Jonathon Jongsma
How about this alternative approach? It introduces a new central keyboard monitor object which can keep the registered input channels in sync with the client keyboard state. This object has an 'override-guest-modifiers' property which controls whether it will connect to the 'inputs-modifiers'

Re: [Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-31 Thread Jonathon Jongsma
Subject: Re:Re: [Spice-devel] 0001-a patch for syncing keyboard lock status that is not enough. in that case server and client will keep syncing lock status all the time. we have to judge if two ends are identical already. my patch avoid modifying old functions, but for the sake

Re: [Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-27 Thread longguang.yue
my comment tells the reason. there are only one or two oppotunity to sync lock status. when channel_new and windows get focus. but some use cases do not encounter the latter one, because they use spice as desktop(maxmized when launched), no get-focus event will be catched, so if after input

Re: [Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-27 Thread longguang.yue
: spice-devel@lists.freedesktop.org Sent: Thursday, March 27, 2014 9:05:19 AM Subject: Re:Re: [Spice-devel] 0001-a patch for syncing keyboard lock status my comment tells the reason. there are only one or two oppotunity to sync lock status. when channel_new and windows get focus. but some use

[Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-26 Thread bigclouds
thanks 0001-there-is-only-few-oppotunity-one-or-two-to-sync-keyb.patch Description: Binary data ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-26 Thread Jonathon Jongsma
Hello, Thanks for the patch. First, a general comment: it's helpful if you write a few more details in the commit message. I can't tell exactly what bug you are trying to fix, what conditions trigger the bug, or what the expected behavior is. Knowing these things will make it easier to review