Re: [Spice-devel] [PATCH] server/video: do not allow non-streamable drawables be stream candidates

2012-05-20 Thread Alon Levy
On Thu, May 17, 2012 at 08:46:47PM +0300, Yonit Halperin wrote: Fix a crash caused by a call to __red_is_next_stream_frame made by red_stream_maintenance, with a drawable that is not a DRAW_COPY one. Only DRAW_COPY drawables can be streamed, and __red_is_next_stream_frame refers to

[Spice-devel] [PATCH spice-server 1/2] server/red_channel: prevent creating more than one channel client with the same type+id

2012-05-20 Thread Yonit Halperin
--- server/red_channel.c | 51 ++--- 1 files changed, 47 insertions(+), 4 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 4858bb5..0359466 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -40,6 +40,7 @@

[Spice-devel] [PATCH spice-server 2/2] server: handle red_channel_client_create returning NULL

2012-05-20 Thread Yonit Halperin
--- server/inputs_channel.c|3 +++ server/main_channel.c |2 +- server/red_tunnel_worker.c |4 +++- server/red_worker.c|3 +++ server/smartcard.c |3 +++ server/snd_worker.c|3 +++ 6 files changed, 16 insertions(+), 2 deletions(-) diff

Re: [Spice-devel] [PATCH spice-server 1/2] server/red_channel: prevent creating more than one channel client with the same type+id

2012-05-20 Thread Alon Levy
On Sun, May 20, 2012 at 01:31:37PM +0300, Yonit Halperin wrote: --- server/red_channel.c | 51 ++--- 1 files changed, 47 insertions(+), 4 deletions(-) ACK, one spelling idea and a blank line that crept in. diff --git a/server/red_channel.c

Re: [Spice-devel] [PATCH spice-server 2/2] server: handle red_channel_client_create returning NULL

2012-05-20 Thread Alon Levy
On Sun, May 20, 2012 at 01:31:38PM +0300, Yonit Halperin wrote: Looks good, ACK. --- server/inputs_channel.c|3 +++ server/main_channel.c |2 +- server/red_tunnel_worker.c |4 +++- server/red_worker.c|3 +++ server/smartcard.c |3 +++

[Spice-devel] [spice-gtk Win32 v2 PATCH 0/5] usb-redir support for Windows (mingw32)

2012-05-20 Thread Uri Lublin
Hello, This patchset enables usb-redir support in spice-gtk running on Windows. Patches 1, 2 fixes compilation on mingw with usbredir enabled. Patch 1 - No need to review, was was already reviewed and acked. Patch 2 - On windows GUDEV is not required. Patch 3 adds GUdev like implementation

[Spice-devel] [spice-gtk Win32 v2 PATCH 1/5] Move err variable definition to beginning of the function

2012-05-20 Thread Uri Lublin
This fixes the following compilation error: channel-usbredir.c: In function 'spice_usbredir_channel_connect_device_async': channel-usbredir.c:313:9: error: jump skips variable initialization [-Werror=jump-misses-init] --- gtk/channel-usbredir.c |4 +++- 1 files changed, 3 insertions(+), 1

[Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-20 Thread Uri Lublin
For windows GUDEV is not required - GUDEV is alwasy checked as part of USBREDIR, and fails if USBREDIR but no GUDEV on non-windows. - Added GUDEV env-variables in gtk/Makefile.am --- configure.ac| 20 +++- gtk/Makefile.am |2 ++ 2 files changed, 21 insertions(+), 1

[Spice-devel] [spice-gtk Win32 v2 PATCH 3/5] Windows mingw: usb: add win-usb-dev.[ch]: implement GUdevDevice GUdevClient

2012-05-20 Thread Uri Lublin
From: Arnon Gilboa agil...@redhat.com With this patch usb-device-manager can work with little changes on windows too. -added GUdevDevice and GUdevClient like classes -added uevent signal based on WM_DEVICECHANGE Modified-by: Uri Lublin u...@redhat.com --- gtk/Makefile.am | 15 ++

[Spice-devel] [spice-gtk Win32 v2 PATCH 4/5] Windows mingw: usb: Dynamically install a libusb driver for USB devices

2012-05-20 Thread Uri Lublin
- Added win-usb-driver-install.[ch] - Added usbclerk.h Operation (on Windows, spice-gtk point of view): - After some sanity checks, just before redir'ing a USB device a libusb driver needs to be installed (before libusb can open/access it). - A connection (NamedPipe) is established with

[Spice-devel] [spice-gtk Win32 v2 PATCH 5/5] Windows mingw: usb: Comment out some memory cleanups not working on Windows

2012-05-20 Thread Uri Lublin
It's not nice, but better than crashing. --- gtk/usb-device-manager.c | 15 +++ gtk/usbutil.c|1 + 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index c373447..492689f 100644 ---

Re: [Spice-devel] Is there any network bandwidth recommendation for spice?

2012-05-20 Thread Andrew Cathrow
- Original Message - From: David Jaša dj...@redhat.com To: Liang Han liang@gmail.com Cc: spice-devel@lists.freedesktop.org Sent: Wednesday, May 16, 2012 4:06:23 AM Subject: Re: [Spice-devel] Is there any network bandwidth recommendation for spice? Hi Liang, 5-10 Mbps per

Re: [Spice-devel] Problem with dual-display full-screen client on X

2012-05-20 Thread Andrew Cathrow
- Original Message - From: Noel Van Hook noel.van.h...@intelligraphics.com To: Christophe Fergeau cferg...@redhat.com Cc: spice-devel@lists.freedesktop.org Sent: Monday, May 14, 2012 12:07:08 PM Subject: Re: [Spice-devel] Problem with dual-display full-screen client on X On Mon,