Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-17 Thread Alon Levy
Hi, As long as we are changing the way SpiceVDIPortPlug (plug) works, we should have the read callback direction reversed: struct SpiceVDIPortInterface { +int (*have_data)(SpiceVDIPortInstance *sin, uint8_t *buf, int len); -int (*read)(SpiceVDIPortInstance *sin, uint8_t *buf, int len);

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-18 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: To check this I'll have to compile the vdi_port driver, since back porting the spice_vmc.c file from qemu-kvm-rhel6 would be too much work (there is not virtio-serial in current qemu used in upstrea spice). But I'll try to do it and send the

Re: [Spice-devel] [PATCH 28/35] vdi port: redesign.

2010-05-18 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: Hi, I'm not sure how that should be done. My main dislike of the current interface is that it forces either a copy from the driver to an intermediate, like the code I had checked in, or it forces spice-server to consume everything it gets.

[Spice-devel] RFC: client: don't invalidate unless primary surface

2010-05-23 Thread Alon Levy
Izik suggested this, said it will save some performance - in bitmap operations on non primary surfaces no need to invalidate the rectangle. Did some very minimal tests on windows xp guest. Can anyone have a look? Alon diff --git a/client/display_channel.cpp b/client/display_channel.cpp index

Re: [Spice-devel] cannot boot from virtio / no -qxl option

2010-05-24 Thread Alon Levy
- Frédéric Grelot fredericg...@yahoo.fr wrote: Hi List Gerd, [snip] By the way, I made winxp and win7 work with spice without much trouble, but is it normal that there is no special device anymore? I remember installing two specific drivers miniport and vdi_port, then vdagent... with

Re: [Spice-devel] RFC: client: don't invalidate unless primary surface

2010-05-24 Thread Alon Levy
ok, want me to add it and send a patch? this makes sense? - Alexander Larsson al...@redhat.com wrote: On Sun, 2010-05-23 at 14:40 -0400, Alon Levy wrote: Izik suggested this, said it will save some performance - in bitmap operations on non primary surfaces no need to invalidate

Re: [Spice-devel] Spice install problem

2010-05-27 Thread Alon Levy
The error log from compiling the libSDL test is: /tmp/qemu-conf-18013-7491-1531.c:1:17: error: SDL.h: No such file or directory You need to install the sdl-devel packages. btw, you can do yum provides */SDL.h to find out which. Under fedora (I suspect it's the same in centos) the packages

Re: [Spice-devel] SPICE developers wanted

2010-07-28 Thread Alon Levy
- Attila Sukosd attila.suk...@gmail.com wrote: On Wed, Jul 28, 2010 at 9:31 AM, Alon Levy al...@redhat.com wrote: - steven stevenph...@yahoo.com wrote: Hi Guys I'm looking for someone who can help with porting SPICE onto an ARM-based platform using Linux

[Spice-devel] [PATCH] support python 2.5.4+ for marshaller/demarshallers

2010-07-29 Thread Alon Levy
Patch adds a from __future__ import that doesn't affect newer python's but allows python 2.5.4 to run the code (tested under scratchbox, n900 build environment) diff --git a/python_modules/codegen.py b/python_modules/codegen.py index af6636b..03c67e6 100644 --- a/python_modules/codegen.py +++

[Spice-devel] [RFC] codegen+demarshal: cast to void** through a temporary

2010-07-29 Thread Alon Levy
Changes var = (void**)val; Into { typeof val* p = val; var = (void**)p; } Which fixes these warnings (we compile with -Werror, any warning breaks compile): warning: dereferencing type-punned pointer will break strict-aliasing rules Warnings were triggered by gcc 4.2.1 used by scratchbox

Re: [Spice-devel] SPICE developers wanted

2010-07-29 Thread Alon Levy
-a? - Alon Levy al...@redhat.com wrote: I just pushed some of the fixes to upstream spice (git://anongit.freedesktop.org/spice/spice) It is broken now with the autogenerated protocol. I'm trying to fix that. I'll update you. - Original Message - From: Steven Tan stevenph

Re: [Spice-devel] SPICE developers wanted

2010-07-30 Thread Alon Levy
with it too much yet.. not good, sounds like our new fangled clipboard support isn't supported.. please send a stack trace if possible. Thanks for testing. It has a 400Mhz TI OMAP 2420. Attila On Thu, Jul 29, 2010 at 6:31 PM, Alon Levy al...@redhat.com wrote: ok, so I just tested

[Spice-devel] RFC spicevmc chardev backend

2010-08-02 Thread Alon Levy
channel logic. For smart card it will look something like this: -chardev spicevmc,name=usb-ccid,id=usb-ccid -device usb-ccid,chardev=usb-ccid From 4fdf5f37a9312a2b2febded3314fe72f2290582d Mon Sep 17 00:00:00 2001 From: Alon Levy al...@redhat.com Date: Sun, 1 Aug 2010 18:26:52 +0300 Subject

[Spice-devel] spice-vmc updated on branch spice.v13 from spice.kvm.v11

2010-08-03 Thread Alon Levy
This isn't new stuff, I just synced the main branch (spice.v13) in the qemu repository with the branch that already had the latest spice-vmc.c, namely spice.kvm.v11. It's required to work with the new virtio-serial drivers and vdagent/vdservice for windows guests. Alon

Re: [Spice-devel] [PATCH] client: fix - exit on bad display-effect argument

2010-08-08 Thread Alon Levy
- Yonit Halperin yhalp...@redhat.com wrote: --- client/application.cpp |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/client/application.cpp b/client/application.cpp index 3dafbc6..490cd8c 100644 --- a/client/application.cpp +++ b/client/application.cpp

Re: [Spice-devel] [RFC] codegen+demarshal: cast to void** through a temporary

2010-08-17 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Thu, 2010-07-29 at 12:20 -0400, Alon Levy wrote: Changes var = (void**)val; Into { typeof val* p = val; var = (void**)p; } Which fixes these warnings (we compile with -Werror, any warning breaks compile): warning

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: On 08/18/10 14:15, Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboaagil...@agilboa.usersys.redhat.com -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in

[Spice-devel] [PATCH] spice-vmc: add a reset handler used to unregister spice interface (and trigger server mouse)

2010-08-24 Thread Alon Levy
In the scenario where we already switched to agent mouse, and then reset, there was no indication to the device, and from there to spice, that the guest driver and agent have quit. This allows us to switch to server side mouse until the agent starts up again. In case the agent doesn't start,

[Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Alon Levy
SpiceCharDevice{Interface,Instance} replaces SpiceVDIPort*. This gives nothing right now, but lets us support smartcard and other interfaces that rely on a char device without having to introduce further patches to qemu. The changes are: * spice_server_add_interface delegates to

[Spice-devel] [RFC 2/2] qemu, spice-vmc, vdi: update to use SpiceCharDevice* instead of SpiceVDIPort*

2010-08-25 Thread Alon Levy
--- hw/spice-vdi.c | 22 ++ hw/spice-vmc.c | 39 --- 2 files changed, 42 insertions(+), 19 deletions(-) diff --git a/hw/spice-vdi.c b/hw/spice-vdi.c index 23cbbe1..b2ea54a 100644 --- a/hw/spice-vdi.c +++ b/hw/spice-vdi.c @@ -104,7

Re: [Spice-devel] Fwd: [PATCH 2/3] server: fix race when data arrives from guest through vdi interface

2010-08-25 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Wed, 2010-08-25 at 06:28 -0400, Alon Levy wrote: - Forwarded Message - From: Alon Levy al...@redhat.com To: al...@redhat.com Sent: Sunday, August 22, 2010 10:28:37 PM (GMT+0200) Auto-Detected Subject: [PATCH 2/3] server: fix

Re: [Spice-devel] [RFC 1/2] spice, server: introduce SpiceCharDevice

2010-08-25 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Wed, 2010-08-25 at 06:53 -0400, Alon Levy wrote: index aede4ce..6c02afb 100644 --- a/server/spice-experimental.h +++ b/server/spice-experimental.h @@ -1,26 +1,31 @@ -/* vdi port interface */ +/* char device interfaces

[Spice-devel] [PATCH 1/2] server: rename SpiceVDIPort* to SpiceCharDevice*

2010-08-26 Thread Alon Levy
--- server/reds.c | 48 +- server/spice-experimental.h | 28 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/server/reds.c b/server/reds.c index 571013f..0870612 100644 --- a/server/reds.c +++

[Spice-devel] [PATCH 1/2] spice-{vdi, vmc}: rename SpiceVDIPort* to SpiceCharDevice*

2010-08-26 Thread Alon Levy
--- hw/spice-vdi.c | 16 hw/spice-vmc.c | 22 +++--- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/spice-vdi.c b/hw/spice-vdi.c index 23cbbe1..415932b 100644 --- a/hw/spice-vdi.c +++ b/hw/spice-vdi.c @@ -104,7 +104,7 @@ typedef struct

[Spice-devel] [PATCH] server: moved agent pipe headers to spice-protocol

2010-08-30 Thread Alon Levy
diff --git a/server/reds.c b/server/reds.c index b7c6ce7..3ed5ba9 100644 --- a/server/reds.c +++ b/server/reds.c @@ -174,16 +174,6 @@ enum { VDI_PORT_READ_STATE_READ_DATA, }; -enum { -VDP_CLIENT_PORT = 1, -VDP_SERVER_PORT, -}; - -typedef struct __attribute__ ((__packed__))

[Spice-devel] [PATCH v2 1/3] spice-protocol: add vd_agent announce capabilities message

2010-08-30 Thread Alon Levy
Announce capabilities message for agent/client. v2: - variable length field - includes request field, true means receiver should respond with same but with false in request. - client sends with true if it sees agent already connected on startup, otherwise sends with false - agent always

[Spice-devel] [PATCH v2 2/3] client: add announce_capabilities

2010-08-30 Thread Alon Levy
diff --git a/client/red_client.cpp b/client/red_client.cpp index b6a412e..0b0e7ab 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -328,6 +328,8 @@ RedClient::RedClient(Application application) , _agent_out_msg_pos (0) , _agent_tokens (0) , _agent_timer (new

[Spice-devel] [PATCH v2 3/3] vdagent: support announce_capabilities

2010-08-30 Thread Alon Levy
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index b1f47c0..4755b19 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -37,6 +37,8 @@ private: VDAgent(); void input_desktop_message_loop(); bool handle_mouse_event(VDAgentMouseState* state); +bool

Re: [Spice-devel] [PATCH v2 1/3] spice-protocol: add vd_agent announce capabilities message

2010-08-30 Thread Alon Levy
- Hans de Goede hdego...@redhat.com wrote: Hi, On 08/30/2010 01:51 PM, Alon Levy wrote: Announce capabilities message for agent/client. v2: - variable length field - includes request field, true means receiver should respond with same but with false in request

Re: [Spice-devel] [PATCH v2 1/3] spice-protocol: add vd_agent announce capabilities message

2010-08-30 Thread Alon Levy
- Hans de Goede hdego...@redhat.com wrote: Hi, On 08/30/2010 02:40 PM, Alon Levy wrote: - Hans de Goedehdego...@redhat.com wrote: Hi, On 08/30/2010 01:51 PM, Alon Levy wrote: Announce capabilities message for agent/client. v2: - variable length field

[Spice-devel] [PATCH v3 1/3] add vd_agent announce capabilities message

2010-08-30 Thread Alon Levy
diff --git a/spice/vd_agent.h b/spice/vd_agent.h index 1fcda88..2e455ac 100644 --- a/spice/vd_agent.h +++ b/spice/vd_agent.h @@ -64,6 +64,8 @@ enum { VD_AGENT_REPLY, VD_AGENT_CLIPBOARD, VD_AGENT_DISPLAY_CONFIG, +VD_AGENT_ANNOUNCE_CAPABILITIES, +VD_AGENT_END_MESSAGE, };

[Spice-devel] [PATCH v3 2/3] client: add announce_capabilities

2010-08-30 Thread Alon Levy
v3: delete _agent_caps remove caps_size diff --git a/client/red_client.cpp b/client/red_client.cpp index b6a412e..bc4c76c 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -328,6 +328,8 @@ RedClient::RedClient(Application application) , _agent_out_msg_pos (0) ,

[Spice-devel] [PATCH v3 3/3] vdagent: support announce_capabilities

2010-08-30 Thread Alon Levy
v3 change: remove caps_size --- diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index b1f47c0..5024456 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -37,6 +37,8 @@ private: VDAgent(); void input_desktop_message_loop(); bool

[Spice-devel] [PATCH v4 0/3] add vdagent announce_capabilities

2010-08-30 Thread Alon Levy
v4 changes: * put back enum, but with capablity per existing message (minus the announce_capabilities message) * fix consistency of macro bit twiddling ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

[Spice-devel] [PATCH v4 1/3] add vd_agent announce capabilities message

2010-08-30 Thread Alon Levy
diff --git a/spice/vd_agent.h b/spice/vd_agent.h index 1fcda88..9b79f0f 100644 --- a/spice/vd_agent.h +++ b/spice/vd_agent.h @@ -64,6 +64,8 @@ enum { VD_AGENT_REPLY, VD_AGENT_CLIPBOARD, VD_AGENT_DISPLAY_CONFIG, +VD_AGENT_ANNOUNCE_CAPABILITIES, +VD_AGENT_END_MESSAGE, };

[Spice-devel] [PATCH v4 2/3] client: add announce_capabilities

2010-08-30 Thread Alon Levy
diff --git a/client/red_client.cpp b/client/red_client.cpp index b6a412e..72b5909 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -328,6 +328,8 @@ RedClient::RedClient(Application application) , _agent_out_msg_pos (0) , _agent_tokens (0) , _agent_timer (new

[Spice-devel] [PATCH v4 3/3] vdagent: support announce_capabilities

2010-08-30 Thread Alon Levy
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index b1f47c0..634f3a0 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -37,6 +37,8 @@ private: VDAgent(); void input_desktop_message_loop(); bool handle_mouse_event(VDAgentMouseState* state); +bool

[Spice-devel] creating devices on the fly (smartcard ccid readers)

2010-08-31 Thread Alon Levy
Hi, I have most of the changes for adding smartcard readers to spice ready, with the exception of the actual creation/removal of readers during runtime. Basically I want the guest to see the amount of readers that the client has. Which can be zero or more. SpiceCoreInterface doesn't allow

[Spice-devel] recent patches to spice-vmc change command line parameters

2010-08-31 Thread Alon Levy
Hi, I've pushed two patches (right now just on spice.v17, should be on spice.kvm.v14 too) that change the required flags to spicevmc. The new syntax requires you to specify a subtype argument, only value right now is vdagent. So: -device spicevmc,subtype=vdagent instead of just -device

[Spice-devel] [PATCH] client: add default_agent_caps

2010-08-31 Thread Alon Levy
diff --git a/client/red_client.cpp b/client/red_client.cpp index 6c6e066..e1a322e 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -75,6 +75,12 @@ private: RedClient _client; }; +uint32_t default_agent_caps[] = { +(1 VD_AGENT_CAP_MOUSE_STATE) | +(1

[Spice-devel] [PATCH v3] client: add default agent capabilities

2010-08-31 Thread Alon Levy
v3: allocate to maximal size on start (even if default is smaller) diff --git a/client/red_client.cpp b/client/red_client.cpp index 6c6e066..79f5e6d 100644 --- a/client/red_client.cpp +++ b/client/red_client.cpp @@ -75,6 +75,12 @@ private: RedClient _client; }; +uint32_t

[Spice-devel] [PATCH v2] spice-vmc: add a reset handler used to unregister spice interface (and trigger server mouse)

2010-08-31 Thread Alon Levy
v2: use qdev.reset instead of old API. diff --git a/hw/spice-vmc.c b/hw/spice-vmc.c index 434c70f..0636973 100644 --- a/hw/spice-vmc.c +++ b/hw/spice-vmc.c @@ -189,6 +189,15 @@ static void vmc_print_optional_subtypes(void) fprintf(stderr, \n); } +static void vmc_reset(DeviceState

Re: [Spice-devel] [PATCH 2/2] Fix scaling with large magnification

2010-08-31 Thread Alon Levy
- al...@redhat.com wrote: From: Alexander Larsson al...@redhat.com When scaling part of an image we need to specify the source coordinates in transformed coordinates. For large magnifications this means we will get pretty large values. Now, if e.g. src_x * transform is larger than

Re: [Spice-devel] Announcing Spice 0.6.0

2010-09-01 Thread Alon Levy
- Bitman Zhou bitman.z...@sinobot.com.cn wrote: First thank you for your great job! I tried spice.kvm.v18 with spice-0.6.0. One build issue at hw/spice-vmc.c, line 185 fprintf(stderr, *psubtype); What error message do you get exactly? what compiler do you use?

[Spice-devel] [PATCH] spice-vmc: compiler warning fix on fprintf

2010-09-01 Thread Alon Levy
--- hw/spice-vmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spice-vmc.c b/hw/spice-vmc.c index 1255d46..b9c5eb6 100644 --- a/hw/spice-vmc.c +++ b/hw/spice-vmc.c @@ -182,7 +182,7 @@ static void vmc_print_optional_subtypes(void) fprintf(stderr, supported

[Spice-devel] Fwd: [PATCH v2] spice-vmc: add a reset handler used to unregister spice interface (and trigger server mouse)

2010-09-01 Thread Alon Levy
bump - any reviewers? Gerd? - Forwarded Message - From: Alon Levy al...@redhat.com To: spice-devel spice-de...@freedesktop.org Sent: Tuesday, August 31, 2010 2:57:43 PM (GMT+0200) Auto-Detected Subject: [Spice-devel] [PATCH v2] spice-vmc: add a reset handler used to unregister spice

Re: [Spice-devel] RFC: spice vdagent protocol documentation

2010-09-01 Thread Alon Levy
- Hans de Goede hdego...@redhat.com wrote: Hi All, This is a first draft version / a first attempt to document the spice vdagent protocol. This is meant to eventually go to the wiki. Question where on the wiki should I put this? spice vdagent protocol ---

Re: [Spice-devel] virtio-serial question

2010-09-02 Thread Alon Levy
- Vasiliy G Tolstov v.tols...@selfip.ru wrote: Hello. Can somebody provide minimal example code that using virtio-serial to communicate with guest os? (work on guest side and hypervisor side) This is a qemu question, spice just uses virtio-serial. I think you can find info at

Re: [Spice-devel] [PATCH] spicec-x11: Fix going into a never ending loop upon xrandr event (#628573) (v2)

2010-09-05 Thread Alon Levy
- Hans de Goede hdego...@redhat.com wrote: When handling an xrandr event the event_listener-on_monitors_change() callback destroys and re-creates the monitor object(s) which results in the DynamicScreen or MultyMonconstructor being called, which triggers more xrandr events. This causes

[Spice-devel] tom2d benchmark

2010-09-13 Thread Alon Levy
this looks like a nice GDI benchmark: http://www.tomshardware.de/download/Tom2D,0301-26150.html Also has a very nice overview of GDI rendering in XP vs Vista vs Win7. (short story: accel removed in Vista and returned in 7). Alon ___ Spice-devel

Re: [Spice-devel] Are there 64 bit Windows 7 QXL drivers?

2010-09-13 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Thu, 2010-09-09 at 10:23 -0400, Matt Feinberg wrote: I apologize if this information is on the list somewhere. I could not find it. Are there binaries for 64 bit Windows 7 QXL drivers? I have a 64 bit Windows 7 guest which I'm

[Spice-devel] [PATCH] smartcard: add channel

2010-09-13 Thread Alon Levy
--- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h index 3317536..6c65d61 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -327,6 +327,7 @@ enum { SPICE_CHANNEL_PLAYBACK, SPICE_CHANNEL_RECORD,

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Mon, 2010-09-13 at 13:58 -0400, Alon Levy wrote: --- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h Is this change generated? If not, just update

Re: [Spice-devel] [PATCH] smartcard: add channel

2010-09-14 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: Hi, +enum { +SPICE_MSG_SMARTCARD_DATA = 1, + +SPICE_MSG_END_SMARTCARD +}; + +enum { +SPICE_MSGC_SMARTCARD_DATA = 1, + +SPICE_MSGC_END_SMARTCARD +}; I don't think this is a good idea. This is just a chardev

Re: [Spice-devel] SPICE USB redirection support

2010-09-18 Thread Alon Levy
- raveenpl ravee...@gmail.com wrote: Hi, I suppose that status of USB support is still the same - it will be developed in the future. But I've noticed that RedHat provide package spice-usb-redirector (http://rhn.redhat.com/errata/RHEA-2010-0460.html). I am wondering what kind of

Re: [Spice-devel] [announce] alpha glib/gtk client library + app.

2010-10-03 Thread Alon Levy
- Alexander Larsson al...@redhat.com wrote: On Thu, 2010-09-30 at 22:18 +0200, Gerd Hoffmann wrote: On 09/30/10 20:41, Alexander Larsson wrote: On Thu, 2010-09-30 at 14:48 +0200, Alexander Larsson wrote: More later... Bit more before I disappear: why do you have a

Re: [Spice-devel] RFC: spice vdagent protocol documentation

2010-10-03 Thread Alon Levy
- Hans de Goede hdego...@redhat.com wrote: Hi, Alon, Thanks for the feedback! On 09/01/2010 04:42 PM, Alon Levy wrote: - Hans de Goedehdego...@redhat.com wrote: Hi All, This is a first draft version / a first attempt to document the spice vdagent protocol

[Spice-devel] [PATCH] spice codegen: fix copy-o, no such variable

2010-10-05 Thread Alon Levy
): -- 1.7.3.1 -- Alon Levy al...@redhat.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH 3/4] smartcard: server side (not enabled yet)

2010-10-06 Thread Alon Levy
--- server/reds.c | 26 +++ server/smartcard.c | 537 server/smartcard.h | 18 ++ 3 files changed, 581 insertions(+), 0 deletions(-) create mode 100644 server/smartcard.c create mode 100644 server/smartcard.h diff --git

[Spice-devel] [PATCH 4/4] smartcard: configure option --enable-smartcard

2010-10-06 Thread Alon Levy
--- client/Makefile.am |8 +++- client/x11/Makefile.am |9 + configure.ac | 23 +++ server/Makefile.am | 11 +++ 4 files changed, 50 insertions(+), 1 deletions(-) diff --git a/client/Makefile.am b/client/Makefile.am index

[Spice-devel] [PATCH] smartcard: add channel

2010-10-06 Thread Alon Levy
--- spice/enums.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/spice/enums.h b/spice/enums.h index 3317536..76fec0c 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -327,6 +327,7 @@ enum { SPICE_CHANNEL_PLAYBACK, SPICE_CHANNEL_RECORD,

Re: [Spice-devel] [PATCH spice 4/5] spicec-x11: Drop annoying useless warning

2010-10-06 Thread Alon Levy
ACK. - Hans de Goede hdego...@redhat.com wrote: Every time an events comes past where the Window is None (which happens about once every 5 minutes or so), this annoying invalid window message gets printed. Remove it! --- client/x11/platform.cpp |1 - 1 files changed, 0

Re: [Spice-devel] [PATCH xf86-video-qxl master 1/2] limit calculated virtual size to fit within the framebuffer

2010-10-10 Thread Alon Levy
- Hans de Goede hdego...@redhat.com wrote: When running inside a vm with a qxl device with a 8MB framebuffer the code, for automatically setting the virtualsize to the largest width and height seen in the resolution list, would lead to a too large virtual size. The 8MB list has both

Re: [Spice-devel] [PATCH qemu-spice] spice-core: fix watching for write events

2010-10-17 Thread Alon Levy
between a linux guest and a linux client without any issues. Regards, Hans On 10/17/2010 11:55 AM, Alon Levy wrote: looks straight forward enough.. have you tested this? - Hans de Goedehdego...@redhat.com wrote: --- ui/spice-core.c |2 +- 1 files changed, 1

Re: [Spice-devel] [PATCH spice 1/2] client: Interpret the title control message as utf8 instead of unicode16

2010-10-21 Thread Alon Levy
Looks like the same patch I tested, so ACK. On Thu, Oct 21, 2010 at 01:22:30PM +0200, Hans de Goede wrote: The activex browser plugin is sending unicode16 text, where as the xpi one is sending utf8 text. After discussing this on irc we've decided that utf8 is what we want to use. So the client

Re: [Spice-devel] [PATCH spice 2/2] Remove no longer used wstring_printf functions

2010-10-21 Thread Alon Levy
ACK. On Thu, Oct 21, 2010 at 01:22:31PM +0200, Hans de Goede wrote: --- client/utils.cpp |8 client/utils.h|2 -- client/windows/platform_utils.cpp | 14 -- client/x11/platform_utils.cpp | 18 -- 4

Re: [Spice-devel] [PATCH spice] spicec-x11: Do not set _NET_WM_USER_TIME to 0 on startup

2010-10-21 Thread Alon Levy
ACK On Thu, Oct 21, 2010 at 04:43:12PM +0200, Hans de Goede wrote: Setting _NET_WM_USER_TIME to 0 means we do not want focus, not good. --- client/x11/red_window.cpp | 10 ++ client/x11/red_window_p.h |2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

[Spice-devel] [PATCH] vdagent-x11: reopen tablet on resolution change to register new resolution

2010-10-24 Thread Alon Levy
The tablet uinput device is closed and opened by vdagentd as a result of guest_xorg_res. So far this message was only sent on startup of vdagent. Unless we resend it uinput doesn't know of the changed resolution, and the mouse position in the guest is incorrect. --- vdagent-x11.c |3 +++ 1

Re: [Spice-devel] [PATCH] vdagent-x11: reopen tablet on resolution change to register new resolution

2010-10-25 Thread Alon Levy
On Mon, Oct 25, 2010 at 09:30:02AM +0200, Hans de Goede wrote: Hi, On 10/24/2010 03:13 PM, Alon Levy wrote: The tablet uinput device is closed and opened by vdagentd as a result of guest_xorg_res. So far this message was only sent on startup of vdagent. Unless we resend it uinput doesn't

[Spice-devel] [PATCH 1/1] client: add verbose link error messages

2010-10-25 Thread Alon Levy
--- client/red_channel.cpp | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/client/red_channel.cpp b/client/red_channel.cpp index 54caccf..273b28d 100644 --- a/client/red_channel.cpp +++ b/client/red_channel.cpp @@ -42,6 +42,23 @@

[Spice-devel] [PATCH 2/2] reds: fix typo

2010-10-31 Thread Alon Levy
--- server/reds.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/server/reds.c b/server/reds.c index 7ab4925..9d14320 100644 --- a/server/reds.c +++ b/server/reds.c @@ -75,7 +75,7 @@ static SpiceCharDeviceInstance *vdagent = NULL; #define

Re: [Spice-devel] help!secure port for spice

2010-11-03 Thread Alon Levy
On Wed, Nov 03, 2010 at 11:09:39AM +0800, Danica wrote: hi,guys I'm new for spice.I met some troubles when I was working on the secure port for spice through SSL. I have already read the page on spice-space about the SSLConection.But I still can't fix the issues. I ran the

[Spice-devel] [attila.suk...@gmail.com: Re: help!secure port for spice]

2010-11-03 Thread Alon Levy
Date: Wed, 3 Nov 2010 15:37:45 +0100 From: Attila Sukosd attila.suk...@gmail.com To: Alon Levy al...@redhat.com Subject: Re: [Spice-devel] help!secure port for spice On Wed, Nov 3, 2010 at 3:33 PM, Alon Levy al...@redhat.com wrote: On Wed, Nov 03, 2010 at 03:17:42PM +0100, Attila Sukosd wrote

[Spice-devel] [PATCH] server: tests: add basic tests with working do nothing server

2010-11-04 Thread Alon Levy
--- configure.ac |1 + server/Makefile.am |2 + server/tests/Makefile.am | 25 +++ server/tests/basic_event_loop.c| 144 ++

[Spice-devel] zack rustin's blog post on 2d graphics

2010-11-05 Thread Alon Levy
interesting comments. http://zrusin.blogspot.com/2010/11/2d-musings.html -- Alon Levy ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] Created a 0.6 branch

2010-11-07 Thread Alon Levy
On Fri, Nov 05, 2010 at 01:29:26PM +0100, Hans de Goede wrote: Hi All, I've created a 0.6 branch where we can push bugfixes if / when we want to do a 0.6.4 release. This also means that we can move on with new and exciting things like smartcard support for master. ok, great. I guess that

Re: [Spice-devel] [PATCH spice] spicec: Make cegui log to app_data_dir/cegui.log

2010-11-07 Thread Alon Levy
ACK On Fri, Nov 05, 2010 at 08:57:55PM +0100, Hans de Goede wrote: This stops the client from dropping CEGUI.log files into the cwd all the time, and stops it from crashing when the cwd is not writable (rhbz#650253). --- client/gui/gui.cpp |9 - 1 files changed, 8

Re: [Spice-devel] Fedora moving to CEGUI-0.7 for F-15, breaks spicec + solution

2010-11-08 Thread Alon Levy
On Sun, Nov 07, 2010 at 04:28:30PM +0100, Hans de Goede wrote: Hi all, Fedora is moving to cegui-0.7 for F-15. It turns out that the API for apps defining there own renderer has been completely redone. Rather then fixing the current spicec which is likely to be replaced by a gtk version in

Re: [Spice-devel] [PATCH spice] spicec-x11: Add a few missing XLockDisplay calls (rhbz#54265)

2010-11-18 Thread Alon Levy
Looks pretty harmless, but that's from someone not even sure what XIM is (input management?). Did you just miss these calls when doing the XLockDisplay addition before? On Wed, Nov 17, 2010 at 12:30:46PM +0100, Hans de Goede wrote: The XIM functions end up waiting for a reply from the server,

Re: [Spice-devel] qxl dualhead with Fedora14 guest

2010-11-18 Thread Alon Levy
On Thu, Nov 18, 2010 at 12:38:08AM +, Paul Ionescu wrote: Hi, I'm trying to setup a dualhead spice Fedora 14 guest on a Fedora 14 host with with the following command: qemu-kvm f14.img -m 2048 -vga qxl -spice port=5930,disable-ticketing - device qxl -device qxl Fedora 14 is already

Re: [Spice-devel] Can someone tell me the difference between the 2 stream types : Stream_Data and Stream_Clip?

2010-11-18 Thread Alon Levy
On Thu, Nov 18, 2010 at 09:48:25AM +0800, xuzhinong999 wrote: Can someone tell me the difference between the 2 stream types : Stream_Data and Stream_Clip? (I am sorry i have sent the message before, but it seems no response) Bill Bill, you are asking plenty of good questions - the fact

Re: [Spice-devel] [PATCH spice] spicec-x11: Add a few missing XLockDisplay calls (rhbz#54265)

2010-11-18 Thread Alon Levy
On Thu, Nov 18, 2010 at 09:35:23AM +0100, Hans de Goede wrote: Hi, On 11/18/2010 09:32 AM, Alon Levy wrote: Looks pretty harmless, but that's from someone not even sure what XIM is (input management?). Yes input management Did you just miss these calls when doing the XLockDisplay

Re: [Spice-devel] [PATCH spice] spicec-x11: Fix modifier keys getting stuck (rhbz#655048)

2010-11-22 Thread Alon Levy
On Mon, Nov 22, 2010 at 04:36:32PM +0100, Hans de Goede wrote: Currently modifier keys (ctrl, alt) can get stuck when using the x11 client. To reproduce under gnome: -focus the client window without causing it to grab the keyborad (click on the title bar not the window) -press crlt + alt +

Re: [Spice-devel] [virt-tools-list] [PATCH 0 of 4] RFC: add SPICE support (take 2)

2010-11-23 Thread Alon Levy
Accidentally discarded this message - sorry Karol. Sending to spice-devel again. Will virt-viewer support HP RGS? Karol Perkowski CBS karol.perkow...@cbs.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [PATCH spice] spicec-x11: Fix unhandled exception: no window proc crash (rhbz#655836)

2010-11-23 Thread Alon Levy
On Tue, Nov 23, 2010 at 03:39:12PM +0100, Hans de Goede wrote: When XIM + ibus is in use XIM creates an invisible window for its own purposes, we sometimes get a _GTK_LOAD_ICONTHEMES ClientMessage event on this window. Since this window was not explicitly created by spicec, it does not have a

Re: [Spice-devel] [PATCH spice] spicec: Don't show a white screen if guest resolution does not fit fullscreen

2010-11-24 Thread Alon Levy
On Tue, Nov 23, 2010 at 09:17:34PM +0100, Hans de Goede wrote: Currently when going / starting fullscreen if the guest resolution for one of the monitors is higher then that monitor on the client can handle, we show a white screen. Leaving the user stuck (unless they know the fullscreen key

Re: [Spice-devel] qxldd.dll caused windows xp crash

2010-11-24 Thread Alon Levy
On Wed, Nov 24, 2010 at 04:04:22PM +0800, Coolper Chen wrote: I get a problem when running windows xp with qxl,the detail messages from windows xp are(on blue screen): Technical information: *** STOP: 0x008E(0xC005,0xBF9D4DFA,0xEFF759D4,0x) *** qxldd.dll - Address

Re: [Spice-devel] [Announce] spice-gtk 0.1.0

2010-11-25 Thread Alon Levy
On Thu, Nov 25, 2010 at 01:31:51PM -0200, Amador Pahim wrote: Hello, this is a very good news. I need some help... GENvncdisplaykeymap_xorgevdev2xtkbd.c Can't locate Text/CSV.pm in @INC (@INC contains: Seems you are missing a perl package - search for whatever distribution package

Re: [Spice-devel] [Announce] spice-gtk 0.1.0

2010-11-25 Thread Alon Levy
-0.1.0' make: *** [all] Error 2 On Thu, Nov 25, 2010 at 2:17 PM, Alon Levy al...@redhat.com wrote: On Thu, Nov 25, 2010 at 01:31:51PM -0200, Amador Pahim wrote: Hello, this is a very good news. I need some help...  GEN    vncdisplaykeymap_xorgevdev2xtkbd.c  Can't locate Text/CSV.pm

[Spice-devel] [PATCH 0/2] add display test

2010-11-28 Thread Alon Levy
This adds a basic display test for the server not requiring qemu. It is basic since it just does QXL_DRAW_COPY and for instance doesn't do any surfaces (except primary), streams etc. Alon Levy (2): server/tests: add test_display_no_ssl add .gitignore for tests client/tests/.gitignore

[Spice-devel] [PATCH 1/2] server/tests: add test_display_no_ssl

2010-11-28 Thread Alon Levy
updates taken from spice vga mode updates, i.e. non cacheable, glz compressed (depends on whatever settings you apply to the server) opaque draw operations. + completed the SpiceCoreInterface implementation (timers) --- server/tests/Makefile.am | 17 ++-

[Spice-devel] [PATCH 2/2] add .gitignore for tests

2010-11-28 Thread Alon Levy
--- client/tests/.gitignore |1 + server/tests/.gitignore |4 2 files changed, 5 insertions(+), 0 deletions(-) create mode 100644 client/tests/.gitignore create mode 100644 server/tests/.gitignore diff --git a/client/tests/.gitignore b/client/tests/.gitignore new file mode 100644

Re: [Spice-devel] qemu spice 32-bit

2010-11-28 Thread Alon Levy
On Sun, Nov 28, 2010 at 06:00:06PM +0300, Pavel Zhukov wrote: Hi all. Does qemu for x86 support spice? Or only x86_64? I find such strings in qemu.spec from fedora: %ifarch x86_64 BuildRequires: spice-protocol = 0.6.0 BuildRequires: spice-server-devel = 0.6.0 %endif I want to build

Re: [Spice-devel] [PATCH 1/2] server/tests: add test_display_no_ssl

2010-11-29 Thread Alon Levy
04:23 PM, Alon Levy wrote: updates taken from spice vga mode updates, i.e. non cacheable, glz compressed (depends on whatever settings you apply to the server) opaque draw operations. + completed the SpiceCoreInterface implementation (timers) --- server/tests/Makefile.am | 17

[Spice-devel] [PATCH 0/1] introduce spice-qemu-char chardev

2010-11-30 Thread Alon Levy
Adding a chardev backend for spice, for usage by spice vdagent over a with virtio-serial device. Alon Levy (1): spice: add chardev Makefile.objs |2 +- qemu-char.c |7 ++ qemu-config.c |9 ++ qemu-options.hx | 18 - spice-qemu-char.c | 222

[Spice-devel] [PATCH 1/1] spice: add chardev

2010-11-30 Thread Alon Levy
--- Makefile.objs |2 +- qemu-char.c |7 ++ qemu-config.c |9 ++ qemu-options.hx | 18 - spice-qemu-char.c | 222 + spice-qemu-char.h |9 ++ 6 files changed, 265 insertions(+), 2 deletions(-) create mode

[Spice-devel] [PATCH 1/1] server: add char_device.h to Makefile.am for make dist

2010-11-30 Thread Alon Levy
--- server/Makefile.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/server/Makefile.am b/server/Makefile.am index 72c7a4e..2c86a2c 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@ -129,6 +129,7 @@ libspice_server_la_SOURCES =\

[Spice-devel] [PATCH] server/tests: Makefile.am fixes

2010-11-30 Thread Alon Levy
* don't install tests on make install * don't forget anything for make dist tarball --- server/tests/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index dbae555..09fdc26 100644 ---

[Spice-devel] [PATCH 1/1] server/tests: add test_display_no_ssl

2010-11-30 Thread Alon Levy
updates taken from spice vga mode updates, i.e. non cacheable, glz compressed (depends on whatever settings you apply to the server) opaque draw operations. + completed the SpiceCoreInterface implementation (timers) v1-v2: removed test_util.c (Hans) replaced mallocz with calloc (Hans) ---

Re: [Spice-devel] [Announce] spice-gtk 0.2

2010-12-02 Thread Alon Levy
On Thu, Dec 02, 2010 at 03:56:28PM +0100, Gianluca Cecchi wrote: On Thu Dec 2 05:25:19 PST 2010 Marc-André Lureau wrote: One week after 0.1.0, here is the second release of spice-gtk! http://spice-space.org/download/gtk/spice-gtk-0.2.tar.bz2 Hello, my system is F13 x86_64 with

  1   2   3   4   5   6   7   8   9   10   >