Hi,
On Fri, Mar 18, 2011 at 12:52:22PM +0200, Alon Levy wrote:
On Fri, Mar 18, 2011 at 06:26:09PM +0800, Shuxiang Lim wrote:
Hi,
I have to say I cannot solve the glib bugs on Android 'cause it's too
arcane and too huge for me now. e.g such a statement will cause a segfault:
On Sun, Mar 20, 2011 at 03:18:31PM +0100, Christophe Fergeau wrote:
However as you pointed out, maemo uses glib on ARM (and I think other
devices are doing that too) so I don't think glib/gtk+ is fundamentally
broken on ARM
Actually, I was pointed at
http://android.git.kernel.org/?p=platform
On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote:
Well, this is test code, I would want to get back to this eventually, so
could you turn this into a non static (and then the compiler won't complain)
instead? if that doesn't work even #if 0 is better. (again, test code).
Adding
When compiling spice with make CFLAGS=-g3 -ggdb3 -O0 -Wall -Werror,
the build broken because of a few unused variables/missing returns.
This patch fixes these warnings.
---
server/tests/basic_event_loop.c |2 +-
server/tests/test_display_base.c |5 +++--
On Mon, Mar 21, 2011 at 05:32:20PM +0200, Alon Levy wrote:
On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote:
On Mon, Mar 21, 2011 at 04:20:29PM +0100, Christophe Fergeau wrote:
When compiling spice with make CFLAGS=-g3 -ggdb3 -O0 -Wall -Werror,
the build broken because of a few
On Mon, Mar 21, 2011 at 06:47:19PM +0100, Christophe Fergeau wrote:
On Mon, Mar 21, 2011 at 05:24:54PM +0200, Alon Levy wrote:
btw, while you're at it, mind trying to compile with clang?
I ran some tests, spice compiled fine with clang using make CC=clang
CXX=clang++ CFLAGS=-Wall
Hi,
I ran spice through clang static analyzer (by doing
scan-build ./autogen.sh scan-build make -e) and here are 2 patches
fixing some minor issues it reported.
Christophe Fergeau (2):
common/pixman: remove dead assignments
server/tests remove useless assignment
common/pixman_utils.c
They were detected using clang-static-analyzer. Don't initialize
the variable to a value to override it with a different value
a few lines after.
---
common/pixman_utils.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/common/pixman_utils.c
This was detected by clang-static-analyzer.
---
server/tests/basic_event_loop.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/server/tests/basic_event_loop.c b/server/tests/basic_event_loop.c
index 2fe1b69..8db4426 100644
--- a/server/tests/basic_event_loop.c
+++
I ran clang static analyzer on gtk-spice using
scan-build ./autogen.sh scan-build make -e
and it reported some errors (unused variables and potential NULL dereferences).
This patch series fixes these warnings.
Christophe Fergeau (3):
gtk: remove unused variables
gtk: don't attempt
They were spotted by the clang static analyzer.
---
gtk/channel-record.c | 10 --
gtk/spice-channel.c |3 +--
2 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/gtk/channel-record.c b/gtk/channel-record.c
index c7f7054..69c9ea0 100644
--- a/gtk/channel-record.c
+++
In spice_channel_handle_migrate there's an explicit check for
data being NULL. However, we subsequently dereference it twice
even when it can be NULL. Add explicit checks to avoid that.
---
gtk/channel-base.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
If things don't go as expected in gnome_rr_config_ensure_primary
(for example we don't find any usable output), we may end up
trying to dereference a NULL pointer. It's better to check
top_left is not NULL before using it.
---
gtk/display/gnome-rr-config.c |2 +-
1 files changed, 1
When OpenGL is enabled, build fails in DisplayChannel::create_surface
because Canvas *canvas is declared twice. Remove the first
declaration to fix compilation.
---
client/display_channel.cpp |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/client/display_channel.cpp
clang static analyzer warned that 'len' was computed but never
used in glc_vertex2d. glc_stroke_line_dash has side effects so
we have to call it, but we don't need to save its return value
since it's not used.
---
common/glc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
hrm, forget about that patch, I forgot to remove the len
declaration, this breaks compilation.
Christophe
2011/3/22 Christophe Fergeau cferg...@gmail.com:
clang static analyzer warned that 'len' was computed but never
used in glc_vertex2d. glc_stroke_line_dash has side effects so
we have
clang static analyzer warned that 'len' was computed but never
used in glc_vertex2d. glc_stroke_line_dash has side effects so
we have to call it, but we don't need to save its return value
since it's not used.
---
common/glc.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff
Hi Shuxiang,
On Wed, Mar 23, 2011 at 06:03:50PM +0800, Shuxiang Lim wrote:
And also after some hacking on spice-gtk(mostly on the SIGBUS/SEGFAULT
issues,such as replace write_uint16() with memcpy(),..etc),
Are you planning to share these patches? I'm sure spice-gtk maintainers
would be
On Wed, Mar 23, 2011 at 01:25:48PM +0200, Alon Levy wrote:
Way cool. I can't really read the patch there very well. Is this something
you plan to try pushing into glib?
Here is a more readable version of the same email:
http://mail.gnome.org/archives/gtk-devel-list/2011-March/msg00096.html
Hi Chen,
On Thu, Mar 31, 2011 at 04:22:00PM +0800, Chen Coolper wrote:
I got a segmentation fault of spice, spice version is 0.8, qemu version is
spice.v32.kvm.
The following is the detail information:
If you can reproduce the bug, it might be useful to see what valgrind has
to say about it.
It's not obvious how qemu should be started so that vdagentd can
find its com.redhat.spice.0 virtio device. It's explained at
http://spice-space.org/page/Whiteboard/AgentProtocol but is easier
to find if it's explained in README too.
---
README | 17 +
1 files changed, 17
Hi,
Here are two more patches which remove unused code from spice. I
requested a merge request for spice-gtk since the 2nd patch applies to it
too.
Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
MIN() is already defined in spice-protocol/spice/macros.h
---
server/tests/test_util.h |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/server/tests/test_util.h b/server/tests/test_util.h
index 5344a4f..c63f051 100644
--- a/server/tests/test_util.h
+++
spice configure.ac has some code to detect if the compiler has
a special attribute to tag some functions so that they generate a
warning when their return value isn't checked. However, this test
is broken (the gcc attribute name is warn_unused_result, not
__warn_unused_result__ and
On Mon, Apr 04, 2011 at 01:43:23PM +0200, Hans de Goede wrote:
Thanks I've applied this to my vdagent git tree (and will push it
to the official tree together with some other stuff soon). I did
make a small change, since the cmdline syntax was different for
older qemu versions. So I've added
Hi,
On Tue, Mar 22, 2011 at 01:41:10PM +0100, Christophe Fergeau wrote:
I ran spice through clang static analyzer (by doing
scan-build ./autogen.sh scan-build make -e) and here are 2 patches
fixing some minor issues it reported.
I didn't get any feedback on this patch series, this is just
Hi,
After installing fedora 15, I rebuilt spice with gcc 4.6 (and still with opengl
enabled ;), and found a few more issues which I fixed with these 3 patches.
Christophe
NB: still no commit access to spice git, I'll have to ask on
freedesktop IRC
The server Makefile.am rules for marshallers generation are
prefixed with AM_V_SILENT to integrate nicely with automake silent
rules. The same AM_V_SILENT prefix isn't used in client/Makefile.am
resulting in verbose output even when automake silent mode is
enabled. This commit removes this
Commit 774e5bd36f4 changed
- dest-source.pixmap.x_image-data +
+ (uint8_t *)pixman_image_get_stride(dest-source.pixmap.pixman_image) +
The correct accessor to use is pixman_image_get_data. Thanks to gcc
4.6 for warning about a different size int to pointer conversion.
---
gcc 4.6 warned about these.
---
client/x11/red_pixmap_gl.cpp |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/client/x11/red_pixmap_gl.cpp b/client/x11/red_pixmap_gl.cpp
index 7c85966..0e7b8c1 100644
--- a/client/x11/red_pixmap_gl.cpp
+++
Hi,
On Fri, Apr 08, 2011 at 11:48:12AM +0200, Hans de Goede wrote:
nit pick, the usual way to do preprocessor macros with { } is:
I was about to nit pick about the same thing ;)
On a side note, I'm curious about the
#define DEBUG_PRINT(arg) DebugPrint arg
which require using double (( as in
On Fri, Apr 08, 2011 at 11:09:59AM +0200, Hans de Goede wrote:
Ack
(and I pushed them for you)
Thanks! This should be the last time,
https://bugs.freedesktop.org/show_bug.cgi?id=35511#c3
Christophe
pgpfnh6m6SaGz.pgp
Description: PGP signature
___
Hi Cliff,
On Sat, Apr 09, 2011 at 06:04:38PM -0500, Cliff Sharp wrote:
Undefined symbols for architecture x86_64:
_ec_ilog, referenced from:
_ec_enc_uint in ectest.o
_ec_dec_uint in ectest.o
_ec_enc_tell in ectest.o
_ec_dec_tell in ectest.o
_log2_frac in
On Mon, Apr 11, 2011 at 09:57:24AM +0200, Attila Sukosd wrote:
I've also got similar errors during the test, but seemed to work fine
regardless... (Of course its not very optimal)
I indeed forgot to mention that since the error happens in the tests/
directory, one can just ignore it (for
spice-protocol comes with 2 headers to handle structure packing,
but controller_prot.h and foreign_menu_prot were both using their
own preprocessor definitions to handle packing. It's better to have
structure packing macros centralized since how it's done varies
between compilers, so it may need
On Mon, Apr 11, 2011 at 01:18:27PM +0200, Christophe Fergeau wrote:
spice-protocol comes with 2 headers to handle structure packing,
but controller_prot.h and foreign_menu_prot were both using their
own preprocessor definitions to handle packing. It's better to have
structure packing macros
laplace_test_SOURCES = laplace-test.c
mdct_test_SOURCES = mdct-test.c
#rotation_test_SOURCES = rotation-test.c
mathops_test_SOURCES = mathops-test.c
___
And BTW - this has been very helpful.
On Apr 11, 2011, at 3:15 AM, Christophe Fergeau wrote:
On Mon, Apr 11
Christophe Fergeau (5):
client: s/AVAILIBLE/AVAILABLE in CmdLineParser
client: s/reqired/required in CmdLineParser
client: add --version cmdline option to spicec
draw: remove SPICE_ADDRESS
client: skip spaces in --host-subject
client/application.cpp | 19 +--
client
---
client/cmd_line_parser.cpp |6 +++---
client/cmd_line_parser.h |4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/client/cmd_line_parser.cpp b/client/cmd_line_parser.cpp
index 1aa5c96..ec00c3e 100644
--- a/client/cmd_line_parser.cpp
+++
This fixes freedesktop bug #33907
---
client/application.cpp | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/client/application.cpp b/client/application.cpp
index e74a871..ef08087 100644
--- a/client/application.cpp
+++ b/client/application.cpp
@@ -2183,7 +2183,8
This commit removes the typedef for SPICE_ADDRESS which was no
longer used. This is the last thing that was missing to close
fdo bug #28984
---
common/draw.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/common/draw.h b/common/draw.h
index 95f07b8..cb15672 100644
---
red_worker.c has an is_primary_surface helper function, but there
were some places in the file not using it. This patch fixes that
---
server/red_worker.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index
Most uses of AC_ARG_ENABLE were buggy:
- when passing --disable-xxx, configure.ac would behave as if it
was passed --enable-xxx
- passing --enable-xxx=foo would leak into the summary, ie the
summary (at the end of configure) would say xxx: foo instead
of xxx: yes
This patch fixes these 2
configure.ac defines a SPICEC_STATIC_LINKAGE_BDYNAMIC variable
when --enable-static-linkage is not set, but it's never used.
SPICEC_STATIC_LINKAGE_BSTATIC is used in client/, but since we
are using libtool, it might be more appropriate to use
'make LDFLAGS=-all-static' to achieve static link.
---
---
Makefile.am |6 +-
configure.ac |8
2 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index d90357f..853ffea 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,8 @@
-SUBDIRS = common server client python_modules
+SUBDIRS =
Since some spice C++ code is using code from common/, the C
functions need to be marked as such for the C++ compiler, otherwise
we'll get linkage issues.
---
common/canvas_base.h |8
common/canvas_utils.h |8
common/draw.h |8
common/gdi_canvas.h
---
common/gl_canvas.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/common/gl_canvas.h b/common/gl_canvas.h
index ff3fba0..4a15668 100644
--- a/common/gl_canvas.h
+++ b/common/gl_canvas.h
@@ -20,6 +20,9 @@
#include canvas_base.h
#include region.h
+#ifndef
client/ contains several .cpp file which only #include a .c file
of the same name. This is unusual and seems to only be done to
get C++ name mangling on the symbols defined in the C file.
Now that all headers files in common/ use extern C, these
wrappers are no longer useful.
---
---
server/main_channel.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/main_channel.c b/server/main_channel.c
index 1f407e2..4ddd38b 100644
--- a/server/main_channel.c
+++ b/server/main_channel.c
@@ -677,7 +677,7 @@ static int
In C, the latter isn't a prototype for a function with no arg,
but declares a function with an undefined number of args.
---
common/gdi_canvas.c |2 +-
common/gdi_canvas.h |2 +-
common/gl_canvas.c |2 +-
common/gl_canvas.h |2 +-
common/quic.c |2
---
server/smartcard.c| 17 +
server/smartcard.h| 17 +
server/zlib_encoder.c | 17 +
3 files changed, 51 insertions(+), 0 deletions(-)
diff --git a/server/smartcard.c b/server/smartcard.c
index 892500b..d201f5f 100644
---
distcheck still passes, but I couldn't test what happens on windows,
let me know if you can test it and want help fixing it ;)
This patch series applies on top of the cleanup series I just sent.
Christophe
Christophe Fergeau (8):
autotools: refactor the whole build machinery
configure.ac: remove
spice Makefile.am setup is a bit confusing, with source file
names being listed several times in different Makefile.am
(generally, once in EXTRA_DIST and another time in another
Makefile.am in _SOURCES). The client binaries are built
by client/x11/Makefile.am, which means recursing into client,
---
configure.ac |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 92957fa..7e77672 100644
--- a/configure.ac
+++ b/configure.ac
@@ -13,9 +13,6 @@ AC_CONFIG_AUX_DIR(.)
AM_INIT_AUTOMAKE([dist-bzip2 no-dist-gzip subdir-objects])
When using config.h, it must be the very first include in all source
files since it contains #define that may change the compilation process
(eg libc structure layout changes when it's used to enable large file
support on 32 bit x86 archs). This commit adds it at the beginning
of all .c and .cpp
Modify the python (de)marshaller generator to add #include
config.h at the beginning of the C files it generates
---
spice_codegen.py |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/spice_codegen.py b/spice_codegen.py
index 3a9989d..4dad06c 100755
---
Now that all source files include config.h, we can use AC_DEFINE
to enable/disable optional features (opengl, cegui). This is
cleaner than directly appending -Dxxx directives to the preprocessor
flags. This also guarantees that everything will be appropriately
rebuilt when using the same source
This is more explicit about what it does, and not much longer
---
client/application.cpp |6 ++--
client/application.h |2 +-
client/common.h |2 +-
client/display_channel.cpp | 40 +++---
---
spice_codegen.py |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/spice_codegen.py b/spice_codegen.py
index 4dad06c..05b47f6 100755
--- a/spice_codegen.py
+++ b/spice_codegen.py
@@ -142,6 +142,8 @@ writer.set_option(source, os.path.basename(proto_file))
On Thu, Apr 21, 2011 at 02:03:10PM +0200, Hans de Goede wrote:
Nitpick: you're adding a LGPL header, might be good to reflect
that in the commit message.
Indeed, will fix before pushing.
For the record, I used the same licence as most of spice (a
few files are under more permissive licences).
On Thu, Apr 21, 2011 at 08:06:45PM +0300, Uri Lublin wrote:
This breaks windows build with VS.
You need to also modify client/windows/redc.vcproj
Something like this?
diff --git a/client/windows/redc.vcproj b/client/windows/redc.vcproj
index b1b7341..0b1ecbf 100644
---
On Thu, Apr 21, 2011 at 02:00:17PM +0200, Christophe Fergeau wrote:
diff --git a/common/Makefile.am b/common/Makefile.am
index 0a2f9c1..501a6e1 100644
--- a/common/Makefile.am
+++ b/common/Makefile.am
@@ -6,7 +6,6 @@ NULL =
noinst_LTLIBRARIES = libspice-common.la
some detailed logging of the context in which the panic was risen.
There are also a few more cleanups
Christophe
Christophe Fergeau (12):
win32: remove obsolete preprocessor #defines
configure.ac: remove setting default C(XX)FLAGS
add missing static
remove void * arithmetic
common
SW_CANVAS_NO_CHUNKS isn't used anywhere but in this file.
SW_CANVAS_CACHE is now defined directly in the files where it's
needed so we no longer need it in the .vcproj file.
---
client/windows/redc.vcproj |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
---
server/red_worker.h |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/server/red_worker.h b/server/red_worker.h
index ae2eaee..b4e2ed2 100644
--- a/server/red_worker.h
+++ b/server/red_worker.h
@@ -23,12 +23,14 @@
static inline void set_bit(int index, uint32_t
spice_common.h provides an ASSERT macro, no need to duplicate it
in many places. For now client/debug.h keeps its own copy since
debug.h and spice_common.h have clashes on other macros which are
trickier to unify.
---
common/canvas_base.c|7 ---
common/canvas_utils.c |8
---
common/canvas_base.c |7 ---
common/ogl_ctx.c |6 --
common/pixman_utils.c |7 ---
3 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/common/canvas_base.c b/common/canvas_base.c
index a8db367..d11c8ec 100644
--- a/common/canvas_base.c
+++
---
common/glc.c |8
common/rop3.c |8 ++--
common/spice_common.h |2 ++
3 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/common/glc.c b/common/glc.c
index 0396fc9..f85d9f6 100644
--- a/common/glc.c
+++ b/common/glc.c
@@ -40,14 +40,6 @@
---
common/spice_common.h | 22 +++---
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/common/spice_common.h b/common/spice_common.h
index ed28689..d324ca1 100644
--- a/common/spice_common.h
+++ b/common/spice_common.h
@@ -28,40 +28,40 @@
abort();
There is only one user of get_time_stamp from spice_common.h so
it's not really useful to keep it there.
---
common/spice_common.h |7 ---
server/main_channel.c |7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/common/spice_common.h b/common/spice_common.h
Hi,
I am confused, because the git master branch had the version 0.8
bumped only last week.
A 0.8 branch was created from master in late February/early March, and the
version number was changed in that branch shortly *after* the branch was
created. So the version number between the branch
This breaks opengl compilation, I'll send a fixed patch
On Fri, Apr 22, 2011 at 06:43:08PM +0200, Christophe Fergeau wrote:
---
common/glc.c |8
common/rop3.c |8 ++--
common/spice_common.h |2 ++
3 files changed, 4 insertions(+), 14 deletions
On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote:
Also I've attached the patch which fixes a few things here and there... With
this it builds fine.
Ah, so you've already built spice-gtk on macosx? How well did it work?
I had some questions about your patch, it would be really
On Tue, Apr 26, 2011 at 05:10:43PM +0200, Kai Mosebach wrote:
I just triesbuild the OSX gtk client, my findings :
1.) Installed gtk2 and gstreamer via ports
Do you get a gtk2 version using x11 or the native osx port when you get
it from (mac?)ports ?
Christophe
pgp3ZllVEhXHR.pgp
On Wed, Apr 27, 2011 at 11:27:53AM +0200, Kai Mosebach wrote:
Regarding the native gtk2 build I think its not possible with macports.
You would need to use this I guess : http://gtk-osx.sourceforge.net/
yes, trying out http://sourceforge.net/apps/trac/gtk-osx/wiki/Build is part
of my medium
On Tue, Jan 25, 2011 at 07:17:20PM +0100, Marc-André Lureau wrote:
This patch make it easier to spot warnings in compilation. It should
work with older versions of automake that don't support silent rules.
This one was already applied in 0e64e2d0 in November
Christophe
pgpJjjGKTG7sS.pgp
Why do you want to require c99? Do the compilers we use on windows have
good enough c99 support?
Christophe
On Tue, Jan 25, 2011 at 07:17:21PM +0100, Marc-André Lureau wrote:
---
configure.ac |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure.ac
On Tue, Jan 25, 2011 at 07:17:22PM +0100, Marc-André Lureau wrote:
This patch has not been verified. Somebody with VS should check if it
still compiles and run fine before applying it.
Making gdi_handlers makes a lot of sense to me. I couldn't find on google
or with git grep anything that would
On Tue, Jan 25, 2011 at 07:17:25PM +0100, Marc-André Lureau wrote:
diff --git a/common/mem.c b/common/mem.c
index b0a7eb1..4db8a2c 100644
--- a/common/mem.c
+++ b/common/mem.c
@@ -71,6 +71,10 @@ void *spice_memdup(const void *mem, size_t n_bytes)
{
void *copy;
+if (mem ==
On Wed, Apr 27, 2011 at 07:22:34AM -0400, Marc-André Lureau wrote:
- Original Message -
Why do you want to require c99? Do the compilers we use on windows
have
good enough c99 support?
Because we use c99: stdbool.h, inttypes.h, bool, variadic macros, //
comments, ...
On Wed, Apr 27, 2011 at 02:06:48PM +0200, Christophe Fergeau wrote:
On Wed, Apr 27, 2011 at 07:27:18AM -0400, Marc-André Lureau wrote:
Sigh.. i would prefer to avoid ASSERT, and instead use return_val_if_fail()
or so.
That's probably why I didn't add it in the first place.
The old
On Tue, Jan 25, 2011 at 02:33:34PM -0500, Marc-André Lureau wrote:
Hi
+static inline unsigned int ring_get_length(Ring *ring)
This won't compile if no one uses it - so you probably want to make
it non static (or do a hack by doing (void)ring_get_length somewhere).
Correct, if you
On Wed, Apr 27, 2011 at 10:24:01AM -0400, Marc-André Lureau wrote:
Do you mean it should be #ifdef'ed? or that it's better to add the
equivalent of G_GNUC_UNUSED to the function definition to avoid the
compiler
warning?
Is there such warning? I was expecting unused inline functions not
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote:
Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/
Another note, on building the OSX client the symbol _g_get_monotonic_clock
is missing.
I think this comes from gtk/spice-session.c but does not seem to
On Wed, Apr 27, 2011 at 10:47:10AM +0200, Christophe Fergeau wrote:
diff --git a/gtk/continuation.h b/gtk/continuation.h
index 585788e..6822757 100644
--- a/gtk/continuation.h
+++ b/gtk/continuation.h
@@ -21,7 +21,8 @@
#ifndef _CONTINUATION_H_
#define _CONTINUATION_H_
-#include
On Wed, Apr 27, 2011 at 07:36:45PM +0200, Kai Mosebach wrote:
If I run configure --with-coroutine=gthread I don¹t need those patches
below.
Are there any disadvantages out of the gthreads?
No idea, I'm trying to stay as close as possible to upstream defaults :)
Christophe
pgpxSxdBRmQ0r.pgp
On Wed, Apr 27, 2011 at 07:27:58PM +0200, Kai Mosebach wrote:
Yeah, I also gave it a shot and that x11 parts stopped my quite quickly :-/
Another note, on building the OSX client the symbol _g_get_monotonic_clock
is missing.
I think this comes from gtk/spice-session.c but does not seem to
On Wed, Apr 27, 2011 at 06:55:55PM +0300, Alon Levy wrote:
replace everywhere it is needed for xspice - places left out are ifdefed
out later based on the same define mentioned in qxl.h, XSPICE.
note: leave spaces between function name and open paren?
note2: ioport_write is added at the
Ack too
On Wed, Apr 27, 2011 at 06:55:58PM +0300, Alon Levy wrote:
---
src/qxl_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 3514360..dced9fb 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -60,7
Seems ok, ack
On Wed, Apr 27, 2011 at 06:56:00PM +0300, Alon Levy wrote:
---
src/qxl_driver.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index ff6fe97..18050fb 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@
On Wed, Apr 27, 2011 at 06:56:02PM +0300, Alon Levy wrote:
removing whitespace in lines consisting only of it.
most of those areas are touched later, but not all.
---
src/qxl_driver.c | 50 +-
1 files changed, 25 insertions(+), 25
Should be merged in patch #15
On Wed, Apr 27, 2011 at 06:56:07PM +0300, Alon Levy wrote:
---
src/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 8f048c8..6f2cb56 100644
--- a/src/Makefile.am
+++
Ack
On Wed, Apr 27, 2011 at 06:56:08PM +0300, Alon Levy wrote:
---
src/qxl.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index e45066c..3fddef3 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -28,6 +28,7 @@
#include stdint.h
#include
On Wed, Apr 27, 2011 at 06:56:04PM +0300, Alon Levy wrote:
---
configure.ac|2 ++
src/Makefile.am | 23 +++
2 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/configure.ac b/configure.ac
index 99bc517..6a183df 100644
--- a/configure.ac
+++
On Fri, Apr 29, 2011 at 11:10:02AM +0200, Kai Mosebach wrote:
The slim barebone one :) Without all the gtk overhead...
What overhead?
I think if the audio-interface was more portable it would make a pretty
good starting point for porting.
it? Something requiring X11 osx support isn't good
On Fri, Apr 29, 2011 at 07:49:14AM -0400, Cliff Sharp wrote:
There are companies that only use spicec that don't want to make changes
right now.
Not on OSX, do they? I'm really not understanding why using spice-gtk seems
to be so bad for you :(
Christophe
pgpByFrLpGmPB.pgp
Description: PGP
On Fri, Apr 29, 2011 at 07:22:12AM -0500, Cliff Sharp wrote:
I never said that spice-gtk is bad for me.
There are companies that need and use spicec.
Once again, why do they *need* it as opposed to they need a spice client,
they don't really care if it's C, python, raw X, Qt, ...
Saying these
On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote:
Code adapter from RedPeer::ssl_verify_callback() and used by
spice-gtk.
I looked at this one, and was quickly concerned about the amount of
security checks we're trying to do on our own. Basically, we let openssl do
the
On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote:
diff --git a/common/ssl_verify.c b/common/ssl_verify.c
new file mode 100644
index 000..f7d9482
--- /dev/null
+++ b/common/ssl_verify.c
@@ -0,0 +1,458 @@
+/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */
On Tue, Jan 25, 2011 at 07:17:28PM +0100, Marc-André Lureau wrote:
---
client/application.cpp | 20 ++-
client/red_client.cpp |2 +-
client/red_peer.cpp| 374
+++-
client/red_peer.h | 23 +---
4 files changed, 36
1 - 100 of 6456 matches
Mail list logo
