Re: [Sqlalchemy-users] Better Firebird patch and test patches

2006-05-31 Thread Michael Bayer
On May 30, 2006, at 9:20 PM, Brad Clements wrote: pattern = re.compile(r''' (\w+):// (?: ([^:]*) (?::(.*))? @)? (?: ([^/:]*) (?::([^/]*))? )? (?:/[^?]*)?

[Sqlalchemy-users] Better Firebird patch and test patches

2006-05-30 Thread Brad Clements
The attached firebird engine passes 14 query tests and 48 mapper tests. It also passes some reflection tests, but doesn't extract foreign keys or indexes yet. Attached are some minor changes to tests. The reflection diff changes 'value' to 'val', since 'value' is a keyword for firebird.

Re: [Sqlalchemy-users] Better Firebird patch and test patches

2006-05-30 Thread Michael Bayer
On May 30, 2006, at 8:55 PM, Brad Clements wrote: However I really want to change this so that url.py can parse out extra engine specific params. ok what do you want here, dbengine://user:[EMAIL PROTECTED]:port/database? opt=valopt=val ? as long as its good with RFC1738. did you send

Re: [Sqlalchemy-users] Better Firebird patch and test patches

2006-05-30 Thread Brad Clements
On 30 May 2006 at 21:05, Michael Bayer wrote: Copies to: sqlalchemy-users sqlalchemy-users@lists.sourceforge.net From: Michael Bayer [EMAIL PROTECTED] Subject:Re: [Sqlalchemy-users] Better Firebird patch and test patches Date sent: Tue

Re: [Sqlalchemy-users] Better Firebird patch and test patches

2006-05-30 Thread Michael Bayer
On May 30, 2006, at 9:20 PM, Brad Clements wrote: I did not send a patch. I'm looking at the regex in url._parse_rfc1738_args and trying to decide if I can just change it to.. pattern = re.compile(r''' (\w+):// (?: ([^:]*)