Re: [sqlite] Double return Issue in sqlite3_filename_database

2020-02-06 Thread Richard Hipp
On 2/6/20, Damian Wilson wrote: > > Probably benign, but nice if it was cleaned up. > Correct. It is benign - identical machine code is generated with and without the extra statement. And, curiously, the problem was not detected by GCC even with -Wall -Wextra -pedantic-errors. Thanks for

[sqlite] Double return Issue in sqlite3_filename_database

2020-02-06 Thread Damian Wilson
Hi folks Firstly, apologies if this should go to the -dev user list, but I had to start somewhere. I noticed the following double return issue in 3.31.1 source code: Main.c: const char *sqlite3_filename_database(const char *zFilename){ return databaseName(zFilename); return