Re: [sqlite] Two-line patch to fix memory leak

2012-05-11 Thread Eric Sink
Oh darn. If the leak is not obvious to you, and if my patch would cause an undesirable side effect, then the leak may somehow be the fault of our code. I'll have to dig into this a bit further. Sending you our whole tree would be somewhat less than constructive. Maybe I can narrow down to a

Re: [sqlite] Two-line patch to fix memory leak

2012-05-11 Thread Dan Kennedy
On 05/11/2012 11:28 PM, Eric Sink wrote: In sqlite3Fts3Matchinfo(): Near the end of the function, I added two lines: if( rc!=SQLITE_OK ){ sqlite3_result_error_code(pContext, rc); }else{ int n = pCsr->nMatchinfo * sizeof(u32); sqlite3_result_blob(pContext, pCsr->aMatchinfo, n,

[sqlite] Two-line patch to fix memory leak

2012-05-11 Thread Eric Sink
In sqlite3Fts3Matchinfo(): Near the end of the function, I added two lines: if( rc!=SQLITE_OK ){ sqlite3_result_error_code(pContext, rc); }else{ int n = pCsr->nMatchinfo * sizeof(u32); sqlite3_result_blob(pContext, pCsr->aMatchinfo, n, SQLITE_TRANSIENT); ADDED: