Re: [squid-dev] [PATCH] Http::StreamContext refactoring

2016-01-23 Thread Amos Jeffries
On 23/01/2016 7:59 a.m., Alex Rousskov wrote: > On 01/14/2016 05:53 AM, Amos Jeffries wrote: > >> The ClientSocketContext is renamed and shuffled to Http::StreamContext. > > This class does not belong to the Http namespace. It represents the user > side of a master transaction. No, that is

Re: [squid-dev] ftruncate() failures on OS X (Darwin)

2016-01-23 Thread Kinkie
> If there are no objections, I will commit your patch (with the above > polishing touches). +1 from me. Please commit as soon as it's convenient for you. Thank you guys! -- Francesco ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: [squid-dev] ftruncate() failures on OS X (Darwin)

2016-01-23 Thread Markus Mayer
On 23 January 2016 at 09:35, Alex Rousskov wrote: > On 01/21/2016 08:03 PM, Markus Mayer wrote: > > > I left out the "flags" variable from the shm_open() call that you > > showed, since I didn't see it being used or declared anywhere. > > Sorry about that

Re: [squid-dev] ftruncate() failures on OS X (Darwin)

2016-01-23 Thread Alex Rousskov
On 01/21/2016 08:03 PM, Markus Mayer wrote: > I left out the "flags" variable from the shm_open() call that you > showed, since I didn't see it being used or declared anywhere. Sorry about that leftover from a previous version of my sketch. You did the right thing. > I did test it, and it

Re: [squid-dev] ftruncate() failures on OS X (Darwin)

2016-01-23 Thread Amos Jeffries
On 24/01/2016 6:35 a.m., Alex Rousskov wrote: > > If there are no objections, I will commit your patch (with the above > polishing touches). Please do. It seems to have 3 votes already. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org