Re: [squid-dev] [PATCH] Segfault via Ftp::Client::readControlReply.

2016-11-10 Thread Amos Jeffries
On 11/11/2016 6:03 a.m., Christos Tsantilas wrote: > > Added nil dereference checks for Ftp::Client::ctrl.conn, including: > - Ftp::Client::handlePasvReply() and handleEpsvReply() that dereference > ctrl.conn in DBG_IMPORTANT messages. > - Many functions inside FtpClient.cc and FtpGateway.cc

Re: [squid-dev] [PATCH] ICAP trailer support

2016-11-10 Thread Amos Jeffries
On 10/11/2016 7:29 a.m., Alex Rousskov wrote: > On 11/09/2016 08:16 AM, Amos Jeffries wrote: >> On 9/11/2016 3:05 a.m., Eduard Bagdasaryan wrote: >>> Also simplified and fixed headers isolating code while dealing with >>> empty (i.e. zero header fields) headers. Old httpMsgIsolateHeaders() >>>

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-10 Thread Amos Jeffries
On 11/11/2016 9:28 a.m., Kinkie wrote: > > v4 attached. > Does it have to take begin() and end() iterators explicitly? can we not have it take the container itself and use a for(auto : container) loop ? Amos ___ squid-dev mailing list

[squid-dev] Build failed in Jenkins: 4-matrix » gcc,d-debian-unstable #2

2016-11-10 Thread noc
http://build.squid-cache.org/job/4-matrix/compiler=gcc,label=d-debian-unstable/2/-- [...truncated 32111 lines...] mv -f $depbase.Tpo $depbase.Plo libtool: compile: ccache gcc -DHAVE_CONFIG_H -I../../.. -I../../../include -I../../../lib -I../../../src

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-10 Thread Kinkie
> Tests and code analysis show that JoinContainerIntoSBuf() allocates when > no allocation is needed. I have also shown that it is possible to > implement JoinContainerIntoSBuf() so that there is no extra allocation. > AFAICT, going forward, you choices are: > > * state that the extra allocation

[squid-dev] Build failed in Jenkins: 5-matrix » gcc,d-debian-unstable #3

2016-11-10 Thread noc
http://build.squid-cache.org/job/5-matrix/compiler=gcc,label=d-debian-unstable/3/-- [...truncated 32111 lines...] libtool: compile: ccache g++ -DHAVE_CONFIG_H -I../../.. -I../../../include -I../../../lib -I../../../src -I../include -I/usr/include/libxml2

[squid-dev] [PATCH] Segfault via Ftp::Client::readControlReply.

2016-11-10 Thread Christos Tsantilas
Added nil dereference checks for Ftp::Client::ctrl.conn, including: - Ftp::Client::handlePasvReply() and handleEpsvReply() that dereference ctrl.conn in DBG_IMPORTANT messages. - Many functions inside FtpClient.cc and FtpGateway.cc files. TODO: We need to find a better way to handle nil

[squid-dev] Build failed in Jenkins: 5-matrix » gcc,d-debian-unstable #2

2016-11-10 Thread noc
http://build.squid-cache.org/job/5-matrix/compiler=gcc,label=d-debian-unstable/2/-- [...truncated 32111 lines...] depbase=`echo xusleep.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ../libtool --tag=CC --mode=compile ccache gcc -DHAVE_CONFIG_H