Re: [squid-dev] [PATCH] SBuf const iterator fixes

2016-02-10 Thread Amos Jeffries
Since I'm not seeing any outright objections I have applied this as trunk rev.14533. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

[squid-dev] [PATCH] SBuf const iterator fixes

2016-02-08 Thread Amos Jeffries
The SBufIterator is mostly actually a const iterator. But not quite. The point of difference from const_iterator is the operator*() API which is also different from the normal itertor API in that is returns a char instead of a char& or const char &. The attached patch fixes that API making the

Re: [squid-dev] [PATCH] SBuf const iterator fixes

2016-02-08 Thread Kinkie
+1; please merge asap. On Mon, Feb 8, 2016 at 7:18 PM, Amos Jeffries wrote: > The SBufIterator is mostly actually a const iterator. But not quite. > > The point of difference from const_iterator is the operator*() API which > is also different from the normal itertor API in

Re: [squid-dev] [PATCH] SBuf const iterator fixes

2016-02-08 Thread Alex Rousskov
On 02/08/2016 11:18 AM, Amos Jeffries wrote: > The SBufIterator is mostly actually a const iterator. But not quite. I am not sure I understand what you are implying because you did not change any const-related aspects of SBufIterator. What are the requirements for being a "const iterator" class