Re: [PATCH] Native FTP Relay

2014-08-11 Thread Amos Jeffries
On 11/08/2014 11:30 a.m., Alex Rousskov wrote: On 08/10/2014 06:11 AM, Amos Jeffries wrote: snip * please use tok.prefix(CharacterSet::ALPHA) to parse the FTP command instead of BlackSpace. Then explicit delimiter check to validate the input. - RFC 959 is clear: The command codes

Re: [PATCH] Native FTP Relay

2014-08-11 Thread Alex Rousskov
On 08/11/2014 05:50 AM, Amos Jeffries wrote: On 11/08/2014 11:30 a.m., Alex Rousskov wrote: On 08/10/2014 06:11 AM, Amos Jeffries wrote: snip * please use tok.prefix(CharacterSet::ALPHA) to parse the FTP command instead of BlackSpace. Then explicit delimiter check to validate the input. -

Re: [PATCH] Native FTP Relay

2014-08-10 Thread Amos Jeffries
On 10/08/2014 2:44 p.m., Alex Rousskov wrote: On 08/08/2014 11:13 AM, Amos Jeffries wrote: On 9/08/2014 4:57 a.m., Alex Rousskov wrote: On 08/08/2014 09:48 AM, Amos Jeffries wrote: Audit results (part 1): * Please apply CharacterSet updates separately. * Please apply Tokenizer API updates

Re: [PATCH] Native FTP Relay

2014-08-10 Thread Alex Rousskov
On 08/10/2014 06:11 AM, Amos Jeffries wrote: On 10/08/2014 2:44 p.m., Alex Rousskov wrote: This part of the problem will be gone when HTTP-specific code will be moved to HttpServer, but the ICAP compatibility part will not go away regardless of any cleanup. The ICAP compatibility issue is a

Re: [PATCH] Native FTP Relay

2014-08-09 Thread Alex Rousskov
On 08/08/2014 11:13 AM, Amos Jeffries wrote: On 9/08/2014 4:57 a.m., Alex Rousskov wrote: On 08/08/2014 09:48 AM, Amos Jeffries wrote: Audit results (part 1): * Please apply CharacterSet updates separately. * Please apply Tokenizer API updates separately. * please apply src/HttpHdrCc.h

Re: [PATCH] Native FTP Relay

2014-08-08 Thread Amos Jeffries
On 8/08/2014 3:29 p.m., Alex Rousskov wrote: Hello, Native FTP Relay support is finally ready: Squid receives native FTP commands on ftp_port and relays FTP messages between FTP clients and FTP origin servers through the existing Squid access control, adaptation, and logging layers. A

Re: [PATCH] Native FTP Relay

2014-08-08 Thread Alex Rousskov
On 08/08/2014 09:48 AM, Amos Jeffries wrote: On 8/08/2014 3:29 p.m., Alex Rousskov wrote: Hello, Native FTP Relay support is finally ready: Squid receives native FTP commands on ftp_port and relays FTP messages between FTP clients and FTP origin servers through the existing Squid access

Re: [PATCH] Native FTP Relay

2014-08-08 Thread Amos Jeffries
On 9/08/2014 4:57 a.m., Alex Rousskov wrote: On 08/08/2014 09:48 AM, Amos Jeffries wrote: snip Audit results (part 1): * Please apply CharacterSet updates separately. * Please apply Tokenizer API updates separately. * please apply src/HttpHdrCc.h changes separately. Why? If the branch