Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-07 Thread Henrik Nordstrom
mån 2009-09-07 klockan 12:18 +1200 skrev Amos Jeffries: Tricky. That would place the hash at the wrong end of the file (last) where its most likely to be overlooked. Particularly on the longer config files. Doesn't matter if it's overlooked. There are also some distros (notably Gentoo and

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-07 Thread Amos Jeffries
Henrik Nordstrom wrote: mån 2009-09-07 klockan 12:18 +1200 skrev Amos Jeffries: Tricky. That would place the hash at the wrong end of the file (last) where its most likely to be overlooked. Particularly on the longer config files. Doesn't matter if it's overlooked. ?huh? if its overlooked

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-07 Thread Robert Collins
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Amos Jeffries wrote: You misunderstood me. On FreeBSD from what I've seen of squid-cache the md5sum 'binary' is: /path/to/pythonversion /path/to/md5sum.py 'md5' - -Rob -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment:

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-07 Thread Henrik Nordstrom
mån 2009-09-07 klockan 11:52 +1200 skrev Amos Jeffries: This seems to be related: http://www.squid-cache.org/bugs/show_bug.cgi?id=2719 I do't think so. Works for me. Regards Henrik

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-07 Thread Henrik Nordstrom
mån 2009-09-07 klockan 19:51 +1200 skrev Amos Jeffries: Henrik Nordstrom wrote: mån 2009-09-07 klockan 12:18 +1200 skrev Amos Jeffries: Tricky. That would place the hash at the wrong end of the file (last) where its most likely to be overlooked. Particularly on the longer config files.

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-07 Thread Henrik Nordstrom
mån 2009-09-07 klockan 19:51 +1200 skrev Amos Jeffries: But here is another idea. Have uninstall compare with the source directory and not the target. Would probably be best. Will screw up if someone tries make clean before make uninstall but that's their problem. And if that's a problem

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Amos Jeffries
n...@squid-cache.org wrote: See http://build.squid-cache.org/job/3.1-amd64-CentOS-5.3/14/changes Changes: [Amos Jeffries squ...@treenet.co.nz] Prep for 3.0.STABLE19 snip ERROR: files left after uninstall: ./etc/mime.conf ./etc/squid.conf make[1]: *** [distuninstallcheck] Error 1 make[1]:

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Henrik Nordstrom
mån 2009-09-07 klockan 00:16 +1200 skrev Amos Jeffries: ERROR: files left after uninstall: ./etc/mime.conf ./etc/squid.conf make[1]: *** [distuninstallcheck] Error 1 make[1]: Leaving directory

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Robert Collins
On Sun, 2009-09-06 at 22:52 +0200, Henrik Nordstrom wrote: Yes. With no dependencies to guide it make reorders as it sees fit for the day, especially if running parallel jobs. We should be fine if we just list the dependencies. -Rob signature.asc Description: This is a digitally signed

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Henrik Nordstrom
mån 2009-09-07 klockan 07:08 +1000 skrev Robert Collins: On Sun, 2009-09-06 at 22:52 +0200, Henrik Nordstrom wrote: Yes. With no dependencies to guide it make reorders as it sees fit for the day, especially if running parallel jobs. We should be fine if we just list the

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Robert Collins
On Sun, 2009-09-06 at 23:25 +0200, Henrik Nordstrom wrote: Not sure I am comfortable with adding dependencies to automakes own targets.. and no, we are not fine with just that. See the rest of previous response.. To repeat there is more issues here than uninstall racing, we don't even

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Henrik Nordstrom
mån 2009-09-07 klockan 07:29 +1000 skrev Robert Collins: On Sun, 2009-09-06 at 23:25 +0200, Henrik Nordstrom wrote: Not sure I am comfortable with adding dependencies to automakes own targets.. and no, we are not fine with just that. See the rest of previous response.. To repeat there

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Amos Jeffries
On Sun, 06 Sep 2009 23:25:29 +0200, Henrik Nordstrom hen...@henriknordstrom.net wrote: mån 2009-09-07 klockan 07:08 +1000 skrev Robert Collins: On Sun, 2009-09-06 at 22:52 +0200, Henrik Nordstrom wrote: Yes. With no dependencies to guide it make reorders as it sees fit for the day,

Re: Build failed in Hudson: 3.1-amd64-CentOS-5.3 #14

2009-09-06 Thread Amos Jeffries
On Sun, 06 Sep 2009 23:51:54 +0200, Henrik Nordstrom hen...@henriknordstrom.net wrote: mån 2009-09-07 klockan 07:29 +1000 skrev Robert Collins: On Sun, 2009-09-06 at 23:25 +0200, Henrik Nordstrom wrote: Not sure I am comfortable with adding dependencies to automakes own targets.. and