Re: [squid-dev] Compiling from repository checkout

2017-12-24 Thread Kinkie
Hi Mika, sorry for the delayed answer. > Thanks, got it. One more question. Do you know why bootstrap.sh verifies > that glibtool is installed in OS X. Cause I tried this > > brew install libtool > ./bootstrap.sh > brew uninstall libtool > ./configure && make > > And squid builds (and runs)

Re: [squid-dev] Compiling from repository checkout

2017-12-18 Thread Kinkie
On Mon, Dec 18, 2017 at 7:34 AM, mika ristimaki wrote: > Hi all, Hello Mika! > I noticed that the source code distributions > (http://www.squid-cache.org/Versions/v4/) and the repository > (https://github.com/squid-cache/squid) differ in a sense that the tar.gz >

Re: [squid-dev] Stuck jenkins jobs

2017-11-30 Thread Kinkie
I believe so, let’s see in practice On Thu, 30 Nov 2017 at 16:01, Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 11/30/2017 03:12 AM, Kinkie wrote: > > > I've added the build-timeout plugin to jenkins; it'll abort > > pull-request validation jobs

[squid-dev] Stuck jenkins jobs

2017-11-30 Thread Kinkie
Hi, I've added the build-timeout plugin to jenkins; it'll abort pull-request validation jobs that take "several times their usual completion times". Let's see if it helps unstick the queue. -- Francesco ___ squid-dev mailing list

Re: [squid-dev] State of things and stuff

2017-11-26 Thread Kinkie
Ok thanks! Do we have a map of the missing bits? Maybe I could help there On Thu, 23 Nov 2017 at 13:10, Amos Jeffries wrote: > As some of you know since the git transition I've had a few issues with > converting the maintainer scripts which has been the roadblock on our >

Re: [squid-dev] wiki.squid-cache.org has an expired certificate

2017-11-08 Thread Kinkie
Thanks for letting us know. Now fixed. On Wed, Nov 8, 2017 at 9:52 AM, Marcus Kool wrote: > > ___ > squid-dev mailing list > squid-dev@lists.squid-cache.org > http://lists.squid-cache.org/listinfo/squid-dev --

Re: [squid-dev] Build farm updaes?

2017-07-23 Thread Kinkie
Yes, I agree. Eduard, let's align on this. Possibly real time (chat or Skype/WhatsApp/whatever) Thanks! On Sun, 23 Jul 2017 at 23:04, Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 07/23/2017 10:21 AM, Kinkie wrote: > > > is it worth investing time in freshen

[squid-dev] Build farm updaes?

2017-07-23 Thread Kinkie
Hi all, is it worth investing time in freshening up the current build farm setup or is preferable to abandon it altogether in favor of a newly built one? If the former, I can start investing some time in that, removing obsolete nodes and adding newer ones, etc. -- Francesco

Re: [squid-dev] [RFC] Disable Github issue tracker

2017-07-22 Thread Kinkie
I also agree to close Issues for the time being. We can always reopen them later on if it'll be deemed useful. On Fri, Jul 21, 2017 at 5:37 PM, Alex Rousskov wrote: > On 07/21/2017 10:15 AM, Amos Jeffries wrote: >> Alex would you like to draw up a formal

Re: [squid-dev] What should we do about these *wrong* wiki articles?

2017-07-21 Thread Kinkie
Everyone's invited to improve the contents in any way they see reasonable. Please, just go ahead :) On Fri, Jul 21, 2017 at 10:17 AM, Eliezer Croitoru wrote: > Hey List, > > I have seen that these articles aren't up-to-date and are misleading admins. > The first step to my

Re: [squid-dev] Bzr to git migration schedule

2017-07-21 Thread Kinkie
em Administrator > Mobile: +972-5-28704261 > Email: elie...@ngtech.co.il > > > > -Original Message- > From: Alex Rousskov [mailto:rouss...@measurement-factory.com] > Sent: Friday, July 21, 2017 08:02 > To: Eliezer Croitoru <elie...@ngtech.co.il>; 'Kinkie' <

Re: [squid-dev] Bzr to git migration schedule

2017-07-20 Thread Kinkie
I believe we are talking about updating the pages that reference bzr with pages that reference the current repositories and best practices On Thu, 20 Jul 2017 at 08:27, Eliezer Croitoru wrote: > I didn't knew we are trying to "re-write" the wiki. > To what scale are we

Re: [squid-dev] Bzr to git migration schedule

2017-07-18 Thread Kinkie
On Tue, Jul 18, 2017 at 9:36 PM, Alex Rousskov wrote: > On 07/18/2017 02:59 AM, Amos Jeffries wrote: >> We also need someone to lead the wiki re-writing, most of the >> DeveloperResources mentioning the repository and how-to for certain >> development activities.

Re: [squid-dev] [PATCH] fix escaping errors in manual pages causing information loss

2017-05-11 Thread Kinkie
Hi Ingo, I've merged your changes as Squid-5 revno 15135. Thanks for your contribution! On Thu, May 11, 2017 at 6:22 PM, Ingo Schwarze wrote: > Hi, > > while auditing manual pages in the OpenBSD ports tree, i noticed > serious escaping errors in four of the squid manuals that

Re: [squid-dev] [PATCH] SBuf header names

2017-04-28 Thread Kinkie
What's with the comment // TODO: this is probably incorrect, for now it should match w_space ? Apart from this, +1 from me. On Sun, Apr 23, 2017 at 9:56 PM, Amos Jeffries wrote: > This patch replaces String with SBuf for storage of header names in > HttpHeaderEntry. > >

Re: [squid-dev] [PATCH] configure.ac cleanup of BerkleyDB related checks

2017-03-27 Thread Kinkie
+1. On Mon, Mar 27, 2017 at 2:57 PM, Amos Jeffries wrote: > While looking into the last remaining bits of bug 4610 I have found that > most of what we were doing for libdb / -ldb is not necessary any longer. > > Most of the logic seems to be hangovers from when session

Re: [squid-dev] [PATCH] Case-insensitive URI schemes

2017-01-29 Thread Kinkie
> I'm thinking the quick-and-dirty way is to just lowercase the 'proto' > variable in url.cc urlParse() function. Doing that in the for-loop where > it is copied from 'src' would be easiest. > - it breaks the case preservation on unknown schemes a litte bit. But > since they are supposed to be

Re: [squid-dev] [PATCH] remove USE_CHUNKEDMEMPOOLS

2017-01-11 Thread Kinkie
Please go ahead when it's convenient for you. On Wed, Jan 11, 2017 at 4:00 PM, Amos Jeffries wrote: > On 12/01/2017 4:46 a.m., Alex Rousskov wrote: >> On 01/11/2017 08:29 AM, Amos Jeffries wrote: >>> On 1/01/2017 6:37 p.m., Amos Jeffries wrote: The USE_CHUNKEDMEMPOOLS

Re: [squid-dev] [PATCH] remove ip/Qos.cci

2017-01-07 Thread Kinkie
Looks good, except that +Qos::Config() {STUB} Surrounding the STUB macro in brackets is not the common style (although it is harmless and could actually be a good idea) +1, possibly with this change On Sat, Jan 7, 2017 at 11:46 AM, Amos Jeffries wrote: > This patch

Re: [squid-dev] [PATCH] Compilation fix for v5 r14973

2016-12-10 Thread Kinkie
+1; please apply. Thanks! On Sat, Dec 10, 2016 at 1:05 PM, Eduard Bagdasaryan wrote: > Hello, > > Attached a typo fix for r14973 which caused Jenkins errors. > > Regards, > Eduard. > > ___ > squid-dev

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-30 Thread Kinkie
Ok, done. Thanks On Wed, Nov 30, 2016 at 2:02 PM, Kinkie <gkin...@gmail.com> wrote: > I'll do that tonight, but after the rever of std::regex which it clashes with. > > On Wed, Nov 30, 2016 at 12:31 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: >> On 15/11/2016 5:34

Re: [squid-dev] [PATCH] ServerBump class cleanup

2016-11-30 Thread Kinkie
Looks reasonable to me. +1 On Wed, Nov 30, 2016 at 1:34 PM, Amos Jeffries wrote: > This patch is a general cleanup of coding styles and current code > requirements for the ServerBump class. > > Is there any other general cleanup that should be done to this class > while I'm

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-30 Thread Kinkie
I'll do that tonight, but after the rever of std::regex which it clashes with. On Wed, Nov 30, 2016 at 12:31 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 15/11/2016 5:34 a.m., Kinkie wrote: >> Hi, >> the attached patch fixes the issue with missing ACL

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-14 Thread Kinkie
does or does > not do. I am sure you and Kinkie do not need me to finish this. Thanks for helping out so far. -- Francesco ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-14 Thread Kinkie
Hi, the attached patch fixes the issue with missing ACL entries (verified) and streamlines the code a bit. Performance-wise it improves a bit, parsing the same 1M-entry ACL in 19.4 seconds (17.8 seconds in userland). On Mon, Nov 14, 2016 at 11:04 AM, Kinkie <gkin...@gmail.com>

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-14 Thread Kinkie
ve rather than repeating -i values. If Squid does something > else here, that would be a pretty big bug IMO! Double-checked. No it doesn't, it uses -i and +i as documented, I was remembering wrong details. Kinkie ___ squid-dev mailing list squid-

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-14 Thread Kinkie
On Mon, Nov 14, 2016 at 5:59 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 14/11/2016 6:30 p.m., Alex Rousskov wrote: >> On 11/13/2016 05:11 PM, Kinkie wrote: >> >>> the attached patch moves away from hand-rolling a c-string onto >>> joining a SBufList

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-14 Thread Kinkie
On Mon, Nov 14, 2016 at 5:36 AM, Alex Rousskov wrote: > On 11/13/2016 10:15 PM, Amos Jeffries wrote: > >> I think we should accumulate into two SBufList instead, one for -i and >> one for +i instead of switching back and forth with potentially lots of >> little

Re: [squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-14 Thread Kinkie
On Mon, Nov 14, 2016 at 5:30 AM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 11/13/2016 05:11 PM, Kinkie wrote: > >> the attached patch moves away from hand-rolling a c-string onto >> joining a SBufList for optimizing regexes in RegexData.cc. > >>

[squid-dev] [PATCH] Rework acl/RegexData optimization to use SBufList

2016-11-13 Thread Kinkie
shared off memory_cache_mode always memory_replacement_policy lru cache_replacement_policy lru minimum_object_size 0 bytes maximum_object_size 4194304 bytes store_dir_select_algorithm least-load max_open_disk_fds 0 cache_swap_low 90 cache_swap_high 95 access_log daemon:/Users/kinkie/tmp/squid/var/logs/

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-11 Thread Kinkie
On Fri, Nov 11, 2016 at 5:02 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 11/11/2016 9:28 a.m., Kinkie wrote: >> >> v4 attached. >> > > Does it have to take begin() and end() iterators explicitly? > can we not have it take the container itself and

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-10 Thread Kinkie
> Tests and code analysis show that JoinContainerIntoSBuf() allocates when > no allocation is needed. I have also shown that it is possible to > implement JoinContainerIntoSBuf() so that there is no extra allocation. > AFAICT, going forward, you choices are: > > * state that the extra allocation

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-06 Thread Kinkie
>> +dest.reserveSpace(prefix.length() + totalContainerSize + >> suffix.length()); > > Please note that v4 still allocates memory according to my last > experiment. See JoinContainerIntoSBuf3() which mimics your patch v4. You > may claim that the unnecessary allocation is not the fault of this

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-05 Thread Kinkie
On Fri, Nov 4, 2016 at 6:12 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 11/04/2016 01:12 AM, Kinkie wrote: >> On Thu, Nov 3, 2016 at 10:55 PM, Alex Rousskov >> <rouss...@measurement-factory.com> wrote: >>> On 11/03/2016 03:19 PM, Kinkie wro

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-04 Thread Kinkie
On Thu, Nov 3, 2016 at 10:55 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 11/03/2016 03:19 PM, Kinkie wrote: >> On Tue, Nov 1, 2016 at 8:47 PM, Alex Rousskov wrote: >>> On 11/01/2016 02:02 PM, Kinkie wrote: >>>> the attached patch exte

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-03 Thread Kinkie
On Tue, Nov 1, 2016 at 8:47 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 11/01/2016 02:02 PM, Kinkie wrote: >> the attached patch extends SBufContainerJoin to have prefix and >> suffix arguments. This can support a use-case which I found in the >>

[squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-01 Thread Kinkie
Hi all, the attached patch extends SBufContainerJoin to have prefix and suffix arguments. This can support a use-case which I found in the current ACLRegexData work I'm following, where we need to transform {"foo", "bar", "gazonk"} into (foo)|(bar)|(gazonk) It can be done with the current

[squid-dev] Heads up with bzr and lp: urls

2016-10-27 Thread Kinkie
Hi all, I just found out that launchpad suffers from a bug where bzr will hang if trying to negotiate an ecdsa key. Workaround here: https://bugs.launchpad.net/lazr.sshserver/+bug/830679 -- Francesco ___ squid-dev mailing list

Re: [squid-dev] [PATCH] Refactor wordlist to SBufList in acl/RegexData

2016-10-27 Thread Kinkie
On Thu, Oct 27, 2016 at 5:10 AM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 10/26/2016 05:18 PM, Kinkie wrote: >>>> the attached patch refactors the use of wordlist to SBufList in >>>> acl/RegexData.cc > >> -while (wl != NULL) { &

Re: [squid-dev] [PATCH] Refactor wordlist to SBufList in acl/RegexData

2016-10-26 Thread Kinkie
On Wed, Oct 26, 2016 at 10:40 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 27/10/2016 9:16 a.m., Kinkie wrote: >> Hi all, >>the attached patch refactors the use of wordlist to SBufList in >> acl/RegexData.cc; the "test.txt" attachment shows the out

[squid-dev] [PATCH] Refactor wordlist to SBufList in acl/RegexData

2016-10-26 Thread Kinkie
Hi all, the attached patch refactors the use of wordlist to SBufList in acl/RegexData.cc; the "test.txt" attachment shows the output of "./src/squid -X 2>&1 | grep 'RegexData' >/tmp/test_plan.txt" when applied to a default configuration file with these additions: acl t1 dstdom_regex pattern1

[squid-dev] bzr -> git?

2016-10-16 Thread Kinkie
Hi all, I'm currently trying to use recent advancements in Jenkins to improve our QA via gated commits to trunk. This raises (again) the issue of bazaar versus git. Remaining on bazaar is getting more and more painful, as tools such as jenkins focus on git. Asm an example, jenkins pipelines

Re: [squid-dev] [RFC] Support concurrent SBuf::c_str() calls

2016-10-02 Thread Kinkie
On Fri, Sep 30, 2016 at 6:03 PM, Alex Rousskov wrote: > On 09/29/2016 09:19 PM, Amos Jeffries wrote: >> On 30/09/2016 5:03 a.m., Alex Rousskov wrote: >>> Should we remove the increment to make concurrent c_str() calls safe? > >> The reason it exists remember is

[squid-dev] Call for interested Squid developers to join our Coverity Scan team

2016-09-15 Thread Kinkie
Hello, The Squid project is benefiting of a kind donation from Coverity, in the form of free ( as in beer ) access to their Coverity Scan (https://scan.coverity.com/) static code analysis product to analyze our code base for defects. The tool has highlighted in time several potential (and

Re: [squid-dev] dlink question

2016-09-14 Thread Kinkie
Hi Adam. That's a very good question. We are in fact slowly refactoring from our custom data structures to std:: wherever appropriate. If you wish to join the effort, patches are welcome :) Kinkie On Wednesday, 14 September 2016, Adam Majer <ama...@suse.de> wrote: > Hello, >

Re: [squid-dev] Sad performance trend

2016-09-12 Thread Kinkie
On Tue, Sep 6, 2016 at 6:43 PM, Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 09/06/2016 08:27 AM, Amos Jeffries wrote: > > On 27/08/2016 12:32 p.m., Alex Rousskov wrote: > >> W1 W2 W3 W4 W5 W6 > >> v3.1 32% 38% 16% 48% 16+ 9% > >> v3.3 23% 31% 14% 42% 15% 8% >

Re: [squid-dev] Coding standards

2016-08-23 Thread Kinkie
Hi Adam! You're absolutely right; Squid 4.0 is c++11; squid 3.5 is not getting new features right now. On Tue, Aug 23, 2016 at 12:48 PM, Adam Majer wrote: > Hello, > > What are the coding standards for Squid? More specifically, I would like > to know if C++11 (or later?) is

[squid-dev] Retiring unsupported build nodes

2016-08-07 Thread Kinkie
Hi, Ubuntu Utopic and Vivid are now EOL at Ubuntu; I'll be retiring these nodes and replacing them with a Xenial node instead. I'll also be retiring Fedora 21 and replacing it with a Fedora 24 node. Opensuse seems to have jumped from release 13.2 to 42.2, I'll be trying that one out as

Re: [squid-dev] HTTP meetup in Stockholm

2016-07-12 Thread Kinkie
Well, there are representatives from all major UA makers. So while I don't expect them to deviate from their business objectives for us, if we have any specific grievances for them, we certainly can. Regarding JSON headers: what I like about it is that while everything you say is true, more or

Re: [squid-dev] HTTP meetup in Stockholm

2016-07-11 Thread Kinkie
On Mon, Jul 11, 2016 at 8:53 PM, Henrik Nordström <h...@squid-cache.org> wrote: > > sön 2016-07-10 klockan 11:33 +0100 skrev Kinkie: > > Hi all, > > at the end of the month I will attend the HTTP meetup in Stockholm. > > Besides having a chance to see He

Re: [squid-dev] [PATCH Bug 4534 and N-bit fixes for CacheDigest

2016-07-10 Thread Kinkie
Hi, I think it is reasonable to expand the number of objects Squid can manage. 32-bit systems are almost rare to come by nowadays. On Sun, Jul 10, 2016 at 11:08 AM, Amos Jeffries wrote: > On 10/07/2016 1:37 a.m., Amos Jeffries wrote: > > This patch converts the

Re: [squid-dev] [PATCH Bug 4534 and N-bit fixes for CacheDigest

2016-07-10 Thread Kinkie
Hi, +uint32_t mask_size; /* mask size in bytes */ +uint64_t capacity; /* expected maximum for .count, not a hard limit */ +int8_t bits_per_entry; /* number of bits allocated for each entry from capacity */ int count; /* number of digested entries */ int

[squid-dev] HTTP meetup in Stockholm

2016-07-10 Thread Kinkie
Hi all, at the end of the month I will attend the HTTP meetup in Stockholm. Besides having a chance to see Henrik, I'd like to collect your feedback and opinions on the topic that are likely to be touched. Currently there is rather hot discussion on the mailing list on the topics of JSON

Re: [squid-dev] Dealing with RegisteredHeadersHash.gperf

2016-06-22 Thread Kinkie
. My understanding is that I need to > > modify http/RegisteredHeadersHash.gperf, and then run > > "make gperf-files" to generate RegisteredHeadersHash.cci. Is this > correct? > > I believe so, though I've not done it myself yet. Kinkie knows more if > he replies. >

Re: [squid-dev] [PATCH] scripts/trace-kid.pl

2016-06-13 Thread Kinkie
Likewise. +1. On Tue, Jun 14, 2016 at 2:49 AM, Amos Jeffries wrote: > On 14/06/2016 1:22 p.m., Alex Rousskov wrote: > > Hello, > > > > I got tired missing important cache.log lines (or temporary patching > > other tracing scripts to better handle SMP logs) and added a

Re: [squid-dev] What to do with stale related software?

2016-06-12 Thread Kinkie
Hi, done. On Wed, Jun 1, 2016 at 7:27 AM, Kinkie <gkin...@gmail.com> wrote: > Ok, I'll check them and readjust/remove as necessary. > Thanks > > > On Wednesday, 1 June 2016, Amos Jeffries <squ...@treenet.co.nz> wrote: > >> On 31/05/2016 4:37 p.m., Kinkie wrot

Re: [squid-dev] [PATCH] cleanup cppunit detection and use

2016-06-12 Thread Kinkie
HI! have you had a chance to check if the new code works for all the systems we care about? Thanks! On Sun, Jun 12, 2016 at 1:28 AM, Amos Jeffries wrote: > The cppunit-config tool has apparently been replaced by pkg-config .pc > file years ago and is now in the process

Re: [squid-dev] What to do with stale related software?

2016-06-01 Thread Kinkie
Ok, I'll check them and readjust/remove as necessary. Thanks On Wednesday, 1 June 2016, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 31/05/2016 4:37 p.m., Kinkie wrote: > > Hi all, > > I'm reviewing some 'related software' listings on the website, and > > som

[squid-dev] What to do with stale related software?

2016-05-30 Thread Kinkie
Hi all, I'm reviewing some 'related software' listings on the website, and some links are stale. What should we do with them? I recommend to do a cleanup; opinions? -- Kinkie ___ squid-dev mailing list squid-dev@lists.squid-cache.org http

Re: [squid-dev] [PATCH] Deprecating SMB LanMan helpers

2016-05-26 Thread Kinkie
+1. On Thu, May 26, 2016 at 10:03 AM, Amos Jeffries wrote: > Bring the SMB LanMan helpers one step closer to removal by dropping them > from the set of helpers which are auto-detected and built by default > with Squid. > > They are still available for the minority using

Re: [squid-dev] [PATCH] Drop ie_refresh configuration option

2016-05-26 Thread Kinkie
+1. On Thu, May 26, 2016 at 10:16 AM, Amos Jeffries wrote: > This option was provided as a hack to workaround problems in MSIE 5.01 > and older. > > Since those MSIE versions are long deprecated and no longer even > registering on the popularity charts for more than 5 years

Re: [squid-dev] [PATCH] libmem API cleanup pt2

2016-04-20 Thread Kinkie
Looks reasonable to me, except that new class names do not comply with naming conventions -- Francesco On Apr 20, 2016 8:00 AM, "Amos Jeffries" wrote: > On 12/04/2016 11:31 p.m., Amos Jeffries wrote: > > This is the first of the followup patches I promised when applying

Re: [squid-dev] [PATCH] Replace new/delete operators using modern C++ rules

2016-04-10 Thread Kinkie
Hi, I can check Mac. We have had a donation of Solaris nodes, though I need to revise and unrot the setup. I'll do that as soon as possible but don't hold your breath. On Sun, Apr 10, 2016 at 5:50 AM, Amos Jeffries wrote: > On 7/04/2016 7:05 p.m., Alex Rousskov wrote: >>

Re: [squid-dev] [PATCH] BUg 4466: removal of -k kill command

2016-03-29 Thread Kinkie
Hi, I like it. I am not sure how it fits with our stance not to deprecate API as much as possible. So +0, I'd like us to ask feedback from downstream before merging. On Tue, Mar 29, 2016 at 6:22 PM, Amos Jeffries wrote: > The Squid "-k kill" command line option is

Re: [squid-dev] [PATCH] implement RFC3986

2016-03-19 Thread Kinkie
>> Will it be initialized at all? I'd expect that fromHexTable, which is >> const and POD be simply laid out in the data segment and not require >> initialization at all. > > Are you implying that > > (a) fromHexTable is a C++11 constexpr _and_ > (b) constexpr cannot suffer from initialization

Re: [squid-dev] [RFC][PATCH] Bug4438 second attempt: give MemBlob its own pools

2016-03-16 Thread Kinkie
On Tue, Mar 15, 2016 at 9:43 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 03/14/2016 02:11 PM, Kinkie wrote: > >> this second attempt at bug4438 tries a different approach: by giving >> MemBlob its own pools and having a hard initialization de

Re: [squid-dev] [PATCH] implement RFC3986

2016-03-15 Thread Kinkie
> I do not think so. The crux of the issue is that you are defending a > medium-size template function as a necessary and small evil, while I am > attacking the principle or direction of accommodating helper needs by > making Squid code worse. Hi, the attached patch is a modification of what

[squid-dev] [RFC][PATCH] Bug4438 second attempt: give MemBlob its own pools

2016-03-14 Thread Kinkie
Hi all, this second attempt at bug4438 tries a different approach: by giving MemBlob its own pools and having a hard initialization dependency in MemBlob's allocating function, instead of relying on memAllocString. Known side-effects: - allows to tune memblob sizes according to actual use

Re: [squid-dev] [PATCH] tentative fix for bug 4438

2016-03-06 Thread Kinkie
On Sun, Mar 6, 2016 at 9:41 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 03/06/2016 11:16 AM, Kinkie wrote: > >> As I cannot reproduce the issue it's really hard to do a root cause analysis. > > Agreed. However, if you can make SBuf/MemBlob use memory po

Re: [squid-dev] [PATCH] tentative fix for bug 4438

2016-03-06 Thread Kinkie
On Sat, Mar 5, 2016 at 10:21 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 03/05/2016 04:31 AM, Kinkie wrote: >> ensuring that mempools are initialized before MemBlob is >> used. > > Please explain how > > * a call to Mem::Init() >

[squid-dev] [PATCH] tentative fix for bug 4438

2016-03-05 Thread Kinkie
Hi all, attached is a tentative fix for bug 4438. I can't reproduce the bug, unfortunately; judging from the traces it seems to me to be a case of mismatched alloc/free calls (alloc through memallocate, free through mempools). If that's the case, there's a few angles to take on this problem,

Re: [squid-dev] [PATCH] sbuf/forward.h

2016-03-02 Thread Kinkie
Hi, no comments in almost a day and trivial patch; merged as r14574. On Tue, Mar 1, 2016 at 5:30 PM, Kinkie <gkin...@gmail.com> wrote: > Hi, > the attached patch defines sbuf/forward.h and makes use of it > everywhere SBuf had been forward-declared. > > -- > France

[squid-dev] [PATCH] sbuf/forward.h

2016-03-01 Thread Kinkie
Hi, the attached patch defines sbuf/forward.h and makes use of it everywhere SBuf had been forward-declared. -- Francesco sbuf-forward.bundle Description: Binary data ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: [squid-dev] [PATCH] libsbuf

2016-02-29 Thread Kinkie
On Thu, Feb 25, 2016 at 11:56 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 02/25/2016 10:01 AM, Kinkie wrote: >> Hi all, >> please find attached a the bundle implementing libsbuf (merge >> proposal from lp:~squid/squid/sbuflab). >> >

Re: [squid-dev] [PATCH] Remove most Makefile.am DEPENDENCIES

2016-02-27 Thread Kinkie
Committed as r14566. On Fri, Feb 26, 2016 at 5:50 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 27/02/2016 12:01 a.m., Kinkie wrote: >> Hi all, >> as part of the "makefile.am DEPENDENCIES considered harmful" push, >> please find attached a patch

[squid-dev] [PATCH] Remove most Makefile.am DEPENDENCIES

2016-02-26 Thread Kinkie
Hi all, as part of the "makefile.am DEPENDENCIES considered harmful" push, please find attached a patch removing most DEPENDENCIES in src/Makefile.am . Build-tested. -- Francesco === modified file 'src/Makefile.am' --- src/Makefile.am 2016-02-25 18:01:29 + +++ src/Makefile.am

Re: [squid-dev] [PATCH] libsbuf

2016-02-25 Thread Kinkie
On Thu, Feb 25, 2016 at 6:50 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 26/02/2016 6:01 a.m., Kinkie wrote: >> Hi all, >> please find attached a the bundle implementing libsbuf (merge >> proposal from lp:~squid/squid/sbuflab). >> >> It: >

[squid-dev] [PATCH] libsbuf

2016-02-25 Thread Kinkie
Hi all, please find attached a the bundle implementing libsbuf (merge proposal from lp:~squid/squid/sbuflab). It: - shuffles SBuf core files into src/sbuf and implements sbuf/libsbuf.la - refactors SBuf <-> String adaption functions into a separate header, increasing decoupling - reduces the

Re: [squid-dev] [PATCH] implement RFC3986

2016-02-22 Thread Kinkie
On Sun, Feb 21, 2016 at 4:51 PM, Alex Rousskov <rouss...@measurement-factory.com> wrote: > On 02/20/2016 11:27 AM, Kinkie wrote: > >> Sorry to bring this topic up again, but honestly I don't understand >> your position. >> >> I believe that the deadlock we curre

Re: [squid-dev] [PATCH] implement RFC3986

2016-02-20 Thread Kinkie
>> What is the big problem with these generic template functions? > > I believe the problem has already been discussed. I have no new general > information to add to that discussion, but would be happy to try to > answer any specific questions. Sorry to bring this topic up again, but honestly I

[squid-dev] testRock still not working on macOS

2016-02-14 Thread Kinkie
Hi all, the latest work done on Shm to make it work on MacOS seems to be working, however it is not still possible to do unit tests, because the anchors IPC segment created by testRock has too long a filename (it's "/squid-testRock_Store_map_anchors.shm"). Could we maybe work on shortening the

Re: [squid-dev] [PATCH] SBuf const iterator fixes

2016-02-08 Thread Kinkie
+1; please merge asap. On Mon, Feb 8, 2016 at 7:18 PM, Amos Jeffries wrote: > The SBufIterator is mostly actually a const iterator. But not quite. > > The point of difference from const_iterator is the operator*() API which > is also different from the normal itertor API in

Re: [squid-dev] fix for build error mentioned in bso#4403

2016-01-27 Thread Kinkie
Hi, thanks, however the issue was alrady fixed in r14487. On Sun, Jan 24, 2016 at 11:13 PM, Christian wrote: > Hi, > > stumbled over this build error mention in bugzilla (#4403) ... and fixed > it with attached patch. > Cheers > > -- > > Christian >

Re: [squid-dev] ftruncate() failures on OS X (Darwin)

2016-01-23 Thread Kinkie
> If there are no objections, I will commit your patch (with the above > polishing touches). +1 from me. Please commit as soon as it's convenient for you. Thank you guys! -- Francesco ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: [squid-dev] [RFC] The situation with helpers/

2016-01-13 Thread Kinkie
On Tue, Jan 5, 2016 at 6:01 PM, Alex Rousskov wrote: > On 01/04/2016 08:58 PM, Amos Jeffries wrote: >> The SBuf and CharacterSet patch auditing has brought up the questions of >> why helpers/ is separate from src/, built first, what cross-dependency >> there can

Re: [squid-dev] [RFC] The situation with helpers/

2016-01-13 Thread Kinkie
On Wed, Jan 13, 2016 at 10:13 PM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 14/01/2016 2:12 a.m., Kinkie wrote: >> >> About build dependencies from src/ : while refactoring some helpers I >> came across a recipe which seems reasonably clean and ma

Re: [squid-dev] [RFC] The situation with helpers/

2016-01-05 Thread Kinkie
On Tue, Jan 5, 2016 at 4:58 AM, Amos Jeffries wrote: > The SBuf and CharacterSet patch auditing has brought up the questions of > why helpers/ is separate from src/, built first, what cross-dependency > there can be, and even why we are bundling C++ helpers to begin with. >

Re: [squid-dev] [PATCH] Fix libatomic detection

2016-01-05 Thread Kinkie
candidate. On Tue, Jan 5, 2016 at 9:06 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 5/01/2016 7:34 a.m., Kinkie wrote: >> On Mon, Jan 4, 2016 at 6:47 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: >>> On 28/12/2015 10:25 p.m., Kinkie wrote: >>>> Hi, >

Re: [squid-dev] [PATCH] Fix libatomic detection

2016-01-05 Thread Kinkie
looks good. +1 On Tue, Jan 5, 2016 at 10:01 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 5/01/2016 9:24 p.m., Kinkie wrote: >> Hi, >> I haven't checked, but it should. >> MacOS builds for me right now; probably as a result of the LIBS >> side-effect

Re: [squid-dev] [PATCH] search for header files in well-known local directories

2016-01-04 Thread Kinkie
On Mon, Jan 4, 2016 at 6:38 AM, Amos Jeffries wrote: > The auto-conf design for using custom directories (such as these /opt > areas) is that the builder supplies the pth parameter > (--with-gnutls=/opt/local/gnutls) when such local customized installs > are to be used.

Re: [squid-dev] [PATCH] MacOS MIT Kerberos requires libresolv

2016-01-04 Thread Kinkie
Just for clarity: Squid isn't failing. The issue is in the kerberos_ldap_group helper. On Mon, Jan 4, 2016 at 8:58 AM, Kinkie <gkin...@gmail.com> wrote: > It is, however: > > $ pkg-config --libs mit-krb5 > -L/opt/local/lib -lkrb5 -lk5crypto -lcom_err > > :( > >

Re: [squid-dev] [PATCH] MacOS MIT Kerberos requires libresolv

2016-01-04 Thread Kinkie
On Mon, Jan 4, 2016 at 2:29 PM, Markus Moeller <hua...@moeller.plus.com> wrote: > Hi Kinkie, > > I wonder against which Kerberos library SASL is linked against. You may > get strange errors if SASL which is used by ldap is linked against the > native Ke

Re: [squid-dev] [PATCH] search for header files in well-known local directories

2016-01-04 Thread Kinkie
>> But I believe I found the actual issue, fixed by the attached patch. >> There's two problems: >> - headers are checked before PKG_CHECK_MODULES >> - PKG_CHECK_MODULES sets include-related flags in CFLAGS, but then >> AC_CHECK_HEADERS uses CPPFLAGS, not CFLAGS. > > Arg. Bug in PKG_CHECK_MODULES.

Re: [squid-dev] [PATCH] MacOS MIT Kerberos requires libresolv

2016-01-04 Thread Kinkie
> Could it be that the MIT header is used during configure instead of the MAC > Kerberos header files ? Doh! You are right - I had a stale config.cache Thanks for pointing it out! Francesco ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: [squid-dev] [PATCH] improve CharacterSet

2016-01-04 Thread Kinkie
>> This build order change should not be a part of the "improve >> CharacterSet" patch because it has nothing to do with improving >> CharacterSet API. Whether helpers are allowed to use src/ is a separate >> question, implicitly being discussed on the "SBuf API" thread right now. > > Aye.

Re: [squid-dev] [PATCH] Fix libatomic detection

2016-01-04 Thread Kinkie
On Mon, Jan 4, 2016 at 6:47 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 28/12/2015 10:25 p.m., Kinkie wrote: >> Hi, >> >> On Mon, Dec 28, 2015 at 1:32 AM, Amos Jeffries wrote: >>> On 24/12/2015 11:32 a.m., Kinkie wrote: >>>> Hi

Re: [squid-dev] [PATCH] MacOS MIT Kerberos requires libresolv

2016-01-03 Thread Kinkie
It is, however: $ pkg-config --libs mit-krb5 -L/opt/local/lib -lkrb5 -lk5crypto -lcom_err :( On Mon, Jan 4, 2016 at 6:10 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: > On 4/01/2016 1:01 a.m., Kinkie wrote: >> Hi, >> the attached patch improves the build on

Re: [squid-dev] [PATCH] Fix libatomic detection

2016-01-03 Thread Kinkie
10 days without vetoes, committing as revno 14474. On Mon, Dec 28, 2015 at 10:25 AM, Kinkie <gkin...@gmail.com> wrote: > Hi, > > On Mon, Dec 28, 2015 at 1:32 AM, Amos Jeffries <squ...@treenet.co.nz> wrote: >> On 24/12/2015 11:32 a.m., Kinkie wrote: >>> Hi, &g

[squid-dev] [PATCH] search for header files in well-known local directories

2016-01-03 Thread Kinkie
Hi, the attached patch for configure.ac tries to locate local header files in system-local directories. It fixes the build on MacOS/MacPorts which places GnuTLS headers in /opt/local/include. The search is not performed if the builder predefines CPPFLAGS. -- Francesco === modified file

[squid-dev] [PATCH] MacOS MIT Kerberos requires libresolv

2016-01-03 Thread Kinkie
Hi, the attached patch improves the build on MacOS, where MIT krb5 libraries require explicit linking of libresolv. -- Francesco === modified file 'configure.ac' --- configure.ac 2016-01-03 10:45:27 + +++ configure.ac 2016-01-03 11:59:49 + @@ -1478,6 +1478,7 @@

  1   2   3   4   5   6   7   8   9   10   >