Re: Failing build on opensolaris

2010-11-03 Thread Christos Tsantilas
On 11/02/2010 04:48 PM, Alex Rousskov wrote: On 11/02/2010 05:34 AM, Tsantilas Christos wrote: On 11/02/2010 12:42 PM, Amos Jeffries wrote: On 02/11/10 23:27, Tsantilas Christos wrote: Hi all, This problem caused by my last commit. If I am not wrong should fixed now by Amos r11000 commit. I

Re: Failing build on opensolaris

2010-11-03 Thread Alex Rousskov
On 11/03/2010 02:49 AM, Christos Tsantilas wrote: On 11/02/2010 04:48 PM, Alex Rousskov wrote: On 11/02/2010 05:34 AM, Tsantilas Christos wrote: On 11/02/2010 12:42 PM, Amos Jeffries wrote: On 02/11/10 23:27, Tsantilas Christos wrote: Hi all, This problem caused by my last commit. If I am

Re: Failing build on opensolaris

2010-11-03 Thread Tsantilas Christos
On 11/03/2010 04:54 PM, Alex Rousskov wrote: On 11/03/2010 02:49 AM, Christos Tsantilas wrote: On 11/02/2010 04:48 PM, Alex Rousskov wrote: On 11/02/2010 05:34 AM, Tsantilas Christos wrote: On 11/02/2010 12:42 PM, Amos Jeffries wrote: On 02/11/10 23:27, Tsantilas Christos wrote: Hi all,

Re: Failing build on opensolaris

2010-11-03 Thread Alex Rousskov
On 11/03/2010 09:08 AM, Tsantilas Christos wrote: On 11/03/2010 04:54 PM, Alex Rousskov wrote: On 11/03/2010 02:49 AM, Christos Tsantilas wrote: On 11/02/2010 04:48 PM, Alex Rousskov wrote: On 11/02/2010 05:34 AM, Tsantilas Christos wrote: On 11/02/2010 12:42 PM, Amos Jeffries wrote: On

Re: Failing build on opensolaris

2010-11-03 Thread Tsantilas Christos
On 11/03/2010 05:40 PM, Alex Rousskov wrote: On 11/03/2010 09:08 AM, Tsantilas Christos wrote: On 11/03/2010 04:54 PM, Alex Rousskov wrote: Events call cbdataReference/cbdataReferenceDone on their own, right? We do not need to double that effort as far as I can see. Yes events uses the

Re: Failing build on opensolaris

2010-11-03 Thread Henrik Nordström
ons 2010-11-03 klockan 17:08 +0200 skrev Tsantilas Christos: Yes events uses the cbdataReference/cbdataReferenceDone but if we do not lock cbdata before pass to an event the cbdata will be deleted after the event done (when the cbdataReferenceDone called) Only if someone calls cbdataFree

Re: Failing build on opensolaris

2010-11-02 Thread Tsantilas Christos
Hi all, This problem caused by my last commit. If I am not wrong should fixed now by Amos r11000 commit. I lost the related Build failed message and this discussion (I lost a lot of thinks :-( ) On 10/29/2010 12:28 PM, Henrik Nordström wrote: tor 2010-10-28 klockan 22:26 +0200 skrev

Re: Failing build on opensolaris

2010-11-02 Thread Amos Jeffries
On 02/11/10 23:27, Tsantilas Christos wrote: Hi all, This problem caused by my last commit. If I am not wrong should fixed now by Amos r11000 commit. I lost the related Build failed message and this discussion (I lost a lot of thinks :-( ) r11000 uses a temporary pointer. Just a workaround,

Re: Failing build on opensolaris

2010-11-02 Thread Tsantilas Christos
On 11/02/2010 12:42 PM, Amos Jeffries wrote: On 02/11/10 23:27, Tsantilas Christos wrote: Hi all, This problem caused by my last commit. If I am not wrong should fixed now by Amos r11000 commit. I lost the related Build failed message and this discussion (I lost a lot of thinks :-( ) r11000

Re: Failing build on opensolaris

2010-11-02 Thread Alex Rousskov
On 11/02/2010 05:34 AM, Tsantilas Christos wrote: On 11/02/2010 12:42 PM, Amos Jeffries wrote: On 02/11/10 23:27, Tsantilas Christos wrote: Hi all, This problem caused by my last commit. If I am not wrong should fixed now by Amos r11000 commit. I lost the related Build failed message and this

Re: Failing build on opensolaris

2010-10-29 Thread Henrik Nordström
tor 2010-10-28 klockan 22:26 +0200 skrev Kinkie: Well, my aim is a very modest let the damn thing build. I do not yet understand the intricacies of cbdata, and thus I am not able to understand when it is abused and when the abuse is benign. There is two cbdata roles a) Object owner, using

Re: Failing build on opensolaris

2010-10-28 Thread Henrik Nordström
ons 2010-10-27 klockan 20:29 +0200 skrev Kinkie: The build is failing on ../../src/comm.cc: In member function `void ClientInfo::setWriteLimiter(int, double, double)': ../../src/comm.cc:2156: warning: right-hand operand of comma has no effect That line is

Re: Failing build on opensolaris

2010-10-28 Thread Kinkie
Then, if I remember it correctly, that code is broken and needs to be fixed :( On Thursday, October 28, 2010, Henrik Nordström hen...@henriknordstrom.net wrote: ons 2010-10-27 klockan 20:29 +0200 skrev Kinkie: The build is failing on ../../src/comm.cc: In member function `void

Re: Failing build on opensolaris

2010-10-28 Thread Alex Rousskov
On 10/28/2010 01:09 PM, Kinkie wrote: Then, if I remember it correctly, that code is broken and needs to be fixed :( Isn't that what you were doing? If you want to fix the code _and_ follow the cbdata API rules, use CbcPointer instead of a raw queue pointer. The rules were not required for

Re: Failing build on opensolaris

2010-10-28 Thread Kinkie
On Thu, Oct 28, 2010 at 9:55 PM, Alex Rousskov rouss...@measurement-factory.com wrote: On 10/28/2010 01:09 PM, Kinkie wrote: Then, if I remember it correctly, that code is broken and needs to be fixed :( Isn't that what you were doing? If you want to fix the code _and_ follow the cbdata API

Failing build on opensolaris

2010-10-27 Thread Kinkie
The build is failing on ../../src/comm.cc: In member function `void ClientInfo::setWriteLimiter(int, double, double)': ../../src/comm.cc:2156: warning: right-hand operand of comma has no effect That line is cbdataReference(quotaQueue); where in cbdata.h #define cbdataReference(var)

Re: Failing build on opensolaris

2010-10-27 Thread Alex Rousskov
On 10/27/2010 12:29 PM, Kinkie wrote: The build is failing on ../../src/comm.cc: In member function `void ClientInfo::setWriteLimiter(int, double, double)': ../../src/comm.cc:2156: warning: right-hand operand of comma has no effect That line is cbdataReference(quotaQueue); where in