Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Amos Jeffries
On 04/07/18 11:18, Marcus Kool wrote: > I read the changes and like them. > FYI: if you have a github account you should be able to post an approve/change review, aka vote for the PR merge bot. > I also looked at the error messages that Squid produces when helpers are > overloaded. > It would

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Marcus Kool
I read the changes and like them. I also looked at the error messages that Squid produces when helpers are overloaded. It would be nice if in external_acl.cc, helper.cc and redirect.cc the debugs( ... DBG_IMPORTANT ... ) messages have additional text like #children, concurrency or

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Alex Rousskov
On 07/03/2018 10:52 AM, Marcus Kool wrote: > I do like to see better documentation for the new queue-size option. > Including your one-liner in squid.conf.documented is enough for me. I wish it were that simple! For starters, there are at least six independent and slightly different contexts

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Marcus Kool
On 03/07/18 12:54, Alex Rousskov wrote: On 07/03/2018 08:19 AM, Marcus Kool wrote: If you think Squid should use a different default for all or some helper categories, please post a proposal that documents pros and cons and justifies the change. The URL above can be used as your guide to

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Marcus Kool
Thanks for the clarification. The squid.conf.documented file says The queue-size=N option sets the maximum number of queued requests to N. which, for me at least, is hard to translate into maximum number of requests buffered because no helper can accept it. On 03/07/18 13:09, Alex

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Amish
On Tuesday 03 July 2018 09:39 PM, Alex Rousskov wrote: Marcus, Based on your examples, I suspect that you are misinterpreting what the queue is. The request is queued only when no helper can accept it. The queue is not used for requests sent to helpers. Alex. Which means my previous

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Alex Rousskov
Marcus, Based on your examples, I suspect that you are misinterpreting what the queue is. The request is queued only when no helper can accept it. The queue is not used for requests sent to helpers. Alex. ___ squid-users mailing list

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Amish
Umm, may be I mis-interpreted queue-size. I thought queue-size indicates messages "waiting" in the queue and not those are currently being processed. So in case of:    url_rewrite_children 16 concurrency=4 When redirect process is busy --- its currently processing 64 urls. So

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Alex Rousskov
On 07/03/2018 08:19 AM, Marcus Kool wrote: > The original intention of this default value is have a queue that is > twice the size of the messages being processed, AFAICT, the "original intention" was different. The original intention was to preserve old/unpatched Squid behavior to the extent

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Marcus Kool
If an admin finds it necessary to configure url_rewrite_children 16 concurrency=4 the helper subsystem is theoretically capable of processing 64 messages simultaneously. It does not makes sens to use max(2*4,2*16)=32 for queue-size, but should be _at least_ 64. Since Squid (before

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Amish
On Tuesday 03 July 2018 01:46 PM, Amos Jeffries wrote: On 03/07/18 20:00, Amish wrote: Hello, In squid 4.1 new option "queue-size" was introduced. In most (or all) cases default "queue-size" is set to children-max*2. But I believe it should be higher of (children-max*2) OR (concurrency*2)

Re: [squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Amos Jeffries
On 03/07/18 20:00, Amish wrote: > Hello, > > In squid 4.1 new option "queue-size" was introduced. > > In most (or all) cases default "queue-size" is set to children-max*2. > > But I believe it should be higher of (children-max*2) OR (concurrency*2) > > Or it can be some better formula but the

[squid-users] squid 4.1 default queue-size should consider concurrency

2018-07-03 Thread Amish
Hello, In squid 4.1 new option "queue-size" was introduced. In most (or all) cases default "queue-size" is set to children-max*2. But I believe it should be higher of (children-max*2) OR (concurrency*2) Or it can be some better formula but the point I am trying to make is that, "concurrency"