Re: [SSSD] [PATCH] Let the PAM client send its PID

2009-09-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/11/2009 06:13 AM, Sumit Bose wrote: Hi, with this patch the client sends its PID to sssd. This is at least needed by the krb5 provider if the client PID should be part of the credential cache file. bye, Sumit

Re: [SSSD] [PATCH] Let the PAM client send its PID

2009-09-11 Thread Sumit Bose
On Fri, Sep 11, 2009 at 09:07:01AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/11/2009 06:13 AM, Sumit Bose wrote: Hi, with this patch the client sends its PID to sssd. This is at least needed by the krb5 provider if the client PID should be

Re: [SSSD] [PATCH] Let the PAM client send its PID

2009-09-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/11/2009 10:29 AM, Sumit Bose wrote: On Fri, Sep 11, 2009 at 09:07:01AM -0400, Stephen Gallagher wrote: On 09/11/2009 06:13 AM, Sumit Bose wrote: Hi, with this patch the client sends its PID to sssd. This is at least needed by the krb5

[SSSD] [PATCHES] fix access to freed memory

2009-09-11 Thread Simo Sorce
In a couple of places Valgrind spotted a few bugs where memory was beeing freed too early. Following patches correct this errors. Simo. -- Simo Sorce * Red Hat, Inc * New York From f7968749cd062081421e72006581e0aacf547bab Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 11

[SSSD] [PATCH] Add unit tests for strtouint32 and strtoint32

2009-09-11 Thread Stephen Gallagher
Figured it would be a good idea to have some unit tests in place for the nonstandard strtoll functions I wrote. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 686ddf64016fda7258a6cb4c3730061678ddff5e Mon Sep 17 00:00:00 2001 From:

Re: [SSSD] [PATCHES] fix access to freed memory

2009-09-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/11/2009 01:50 PM, Simo Sorce wrote: In a couple of places Valgrind spotted a few bugs where memory was beeing freed too early. Following patches correct this errors. Simo.

[SSSD] [PATCH] Add 'make tests' target

2009-09-11 Thread Stephen Gallagher
Per Simo's request, here is a patch to enable the building (but not executing) of tests for the SSSD. To build and run them, 'make check' still works. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From

Re: [SSSD] [PATCH] fix broken getgrnam and getgrgid

2009-09-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/11/2009 04:17 PM, Simo Sorce wrote: The check_cache() patch broke them. This patch should fix the bug (ticket #177). Simo.

Re: [SSSD] [PATCH] Add unit tests for strtouint32 and strtoint32

2009-09-11 Thread Jenny Galipeau
Stephen Gallagher wrote: Figured it would be a good idea to have some unit tests in place for the nonstandard strtoll functions I wrote. ___ sssd-devel mailing list

Re: [SSSD] [PATCHES] fix access to freed memory

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 14:23 -0400, Stephen Gallagher wrote: On 09/11/2009 01:50 PM, Simo Sorce wrote: In a couple of places Valgrind spotted a few bugs where memory was beeing freed too early. Following patches correct this errors. Patch 0001: Ack Patch 0002: Ack pushed Simo. -- Simo

Re: [SSSD] [PATCH] Add 'make tests' target

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 15:34 -0400, Stephen Gallagher wrote: Per Simo's request, here is a patch to enable the building (but not executing) of tests for the SSSD. To build and run them, 'make check' still works. ack and pushed Simo. -- Simo Sorce * Red Hat, Inc * New York

[SSSD] [PATCH] fis docs with new options and remove legacy

2009-09-11 Thread Simo Sorce
Docs update. Simo. -- Simo Sorce * Red Hat, Inc * New York From 46d75e25ae6a9b088f48a264a99234db73db56ea Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Fri, 11 Sep 2009 17:11:56 -0400 Subject: [PATCH] Update documentation and examples Remove the legacy option from examples

Re: [SSSD] [PATCHES] python bindings for managing users in local domains

2009-09-11 Thread John Dennis
I've reviewed the python binding for sss. It looks pretty good Jakub. I only have a few comments and most of these are style issues as opposed to a coding or logic flaw. * In PyErr_SetSssErrorWithMessage() you don't need to call the PyExc_IOError constructor, instead use Py_BuildValue and use

Re: [SSSD] [PATCH] fix broken getgrnam and getgrgid

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 16:32 -0400, Stephen Gallagher wrote: On 09/11/2009 04:17 PM, Simo Sorce wrote: The check_cache() patch broke them. This patch should fix the bug (ticket #177). Ack pushed -- Simo Sorce * Red Hat, Inc * New York ___

Re: [SSSD] [PATCH] fis docs with new options and remove legacy

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 17:17 -0400, Jenny Galipeau wrote: Simo Sorce wrote: Docs update. That was easy. Nice description of the ldapSchema option. ack pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

Re: [SSSD] [PATCH] add change password target to krb5 backend

2009-09-11 Thread Simo Sorce
On Tue, 2009-09-08 at 11:26 +0200, Sumit Bose wrote: libdbus does not like a pure fork, but prefers fork+exec. The second patch add this functionality to the kerberos child. Parent and child communicate in the following way. UPN and passwords are sent from parent to child via a pipe and

Re: [SSSD] [PATCHES] Two small patches to address minor issues with starting as non-root

2009-09-11 Thread Simo Sorce
On Fri, 2009-09-11 at 16:17 -0400, Stephen Gallagher wrote: Patch 0001: Report specifically that the config database could not be opened (this was ambiguous if you tried to start SSSD and the user could not create the config database file) Patch 0002: Check whether monitor is being run as