Re: [SSSD] Design question

2009-10-16 Thread Sumit Bose
On Thu, Oct 15, 2009 at 05:26:14PM -0400, Dmitri Pal wrote: Hi, Couple questions about async processing. The communication usually consists of several parts. Imagine that you have an object that is responsible for some sort of communication (socket, pipe, file, bus - whatever). Here are

Re: [SSSD] [PATCH] add IPA backend

2009-10-16 Thread Sumit Bose
On Thu, Oct 15, 2009 at 07:10:26PM -0400, Simo Sorce wrote: This patcheset does the minimal necessary work to separate initialization from actual providers code for ldap and kerberos and uses this to introduce a first basic ipa provider skeleton that simply reuses the ldap and krb5 providers

Re: [SSSD] Design question

2009-10-16 Thread Simo Sorce
On Thu, 2009-10-15 at 17:26 -0400, Dmitri Pal wrote: Hi, Couple questions about async processing. The communication usually consists of several parts. Imagine that you have an object that is responsible for some sort of communication (socket, pipe, file, bus - whatever). Here are the basic

Re: [SSSD] Design question

2009-10-16 Thread Dmitri Pal
Simo Sorce wrote: On Thu, 2009-10-15 at 17:26 -0400, Dmitri Pal wrote: Hi, Couple questions about async processing. The communication usually consists of several parts. Imagine that you have an object that is responsible for some sort of communication (socket, pipe, file, bus -

[SSSD] [PATCH] Fix segfault when using SSS tools with no local provider

2009-10-16 Thread Stephen Gallagher
There was a double-free here. I removed the free()s within setup_db, because upon returning to sss_init_tools(), if ret != EOK, the context is freed as well. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From

Re: [SSSD] [PATCH] Fix segfault when using SSS tools with no local provider

2009-10-16 Thread Simo Sorce
On Fri, 2009-10-16 at 10:57 -0400, Stephen Gallagher wrote: There was a double-free here. I removed the free()s within setup_db, because upon returning to sss_init_tools(), if ret != EOK, the context is freed as well. ACK we should *never* free a context that is passed to us, unless we are a

[SSSD] [PATCH] Do not allow setting auth, access or chpass providers for LOCAL

2009-10-16 Thread Stephen Gallagher
This patch addresses https://fedorahosted.org/sssd/ticket/216 The LOCAL provider does not have a mechanism to load alternate auth, access or chpass backends, nor does it make sense to do so. This will throw a configuration error if these values are specified (unless they are explicitly also set

Re: [SSSD] [PATCH] ELAPI Compatibility code for getifaddr()

2009-10-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/15/2009 10:37 AM, Jakub Hrozek wrote: On 10/14/2009 08:27 PM, Dmitri Pal wrote: After some thinking I just fixed the configure.ac and added a new header file. The updated patch attached. Thank you, ACK Pushed to master.

Re: [SSSD] [PATCH] add IPA backend

2009-10-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/16/2009 05:36 AM, Sumit Bose wrote: On Thu, Oct 15, 2009 at 07:10:26PM -0400, Simo Sorce wrote: This patcheset does the minimal necessary work to separate initialization from actual providers code for ldap and kerberos and uses this to

Re: [SSSD] [PATCH] Fix segfault when using SSS tools with no local provider

2009-10-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/16/2009 01:40 PM, Simo Sorce wrote: On Fri, 2009-10-16 at 10:57 -0400, Stephen Gallagher wrote: There was a double-free here. I removed the free()s within setup_db, because upon returning to sss_init_tools(), if ret != EOK, the context is

Re: [SSSD] [PATCH] Do not allow setting auth, access or chpass providers for LOCAL

2009-10-16 Thread Simo Sorce
On Fri, 2009-10-16 at 14:19 -0400, Stephen Gallagher wrote: This patch addresses https://fedorahosted.org/sssd/ticket/216 The LOCAL provider does not have a mechanism to load alternate auth, access or chpass backends, nor does it make sense to do so. This will throw a configuration error

Re: [SSSD] [PATCH] Do not allow setting auth, access or chpass providers for LOCAL

2009-10-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/16/2009 02:37 PM, Simo Sorce wrote: On Fri, 2009-10-16 at 14:19 -0400, Stephen Gallagher wrote: This patch addresses https://fedorahosted.org/sssd/ticket/216 The LOCAL provider does not have a mechanism to load alternate auth, access or

Re: [SSSD] [PATCH] minor cleanup

2009-10-16 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/16/2009 03:02 PM, Stephen Gallagher wrote: On 10/16/2009 02:57 PM, Simo Sorce wrote: This just fixed the order of the options passed to auth_recv so that it conforms to the rest of the code. I prefer to always see inputs parameters before