Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Stephen Gallagher
Nack. Please make this conditional on success of all tests. If any tests fail, it can be useful to examine the contents of the DB files. On Dec 15, 2009, at 6:38 AM, Sumit Bose sb...@redhat.com wrote: Hi, with this patch the two ldb files created by the sysdb test are deleted at the end of

Re: [SSSD] sssd.spec for SLES

2009-12-15 Thread Sergei V. Kovylov
Great... Thanks :-) 2009/12/14 Stephen Gallagher sgall...@redhat.com: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/11/2009 06:58 AM, Sergei V. Kovylov wrote: Oh sorry - my mistake. Unfourtunately, I'm not able to do a patch in git format , as I've never work with git. Also maybe a

Re: [SSSD] sssd.spec for SLES

2009-12-15 Thread Sumit Bose
On Fri, Dec 11, 2009 at 02:58:36PM +0300, Sergei V. Kovylov wrote: Oh sorry - my mistake. Unfourtunately, I'm not able to do a patch in git format , as I've never work with git. ok, I have 'converted' it to git patch and I was able to build SLES10 rpms with this patch, so ACK. Also maybe

Re: [SSSD] [PATCH] fix for #323

2009-12-15 Thread Sumit Bose
On Mon, Dec 14, 2009 at 04:03:27PM -0500, Simo Sorce wrote: Now the upgrade process can cope with converting ols ssd.ldb files into multiple databases even if the new config file does not include a local provider anymore. Tested with a v1 db file and seem to work fine with and w/o a LOCAL

Re: [SSSD] [PATCH] Minor fixes

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2009 01:42 PM, Stephen Gallagher wrote: On 12/11/2009 10:38 AM, Sumit Bose wrote: Hi, 0001: I got an error with older python version when just calling exit(). 'TypeError: 'str' object is not callable' Ack. Good catch. Pushed

Re: [SSSD] [PATCH] Always close STDERR when daemonizing

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2009 02:58 PM, Simo Sorce wrote: On Mon, 2009-12-14 at 13:42 -0500, Stephen Gallagher wrote: Fixes bug https://fedorahosted.org/sssd/ticket/324 We were special-casing stderr and not closing it properly when we daemonized. I think this is

Re: [SSSD] [PATCHES] Translation updates for SV and IT

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2009 03:01 PM, Simo Sorce wrote: On Mon, 2009-12-14 at 13:24 -0500, Stephen Gallagher wrote: See attached patches. ack Simo. Pushed to master and 1-0-0 - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year.

Re: [SSSD] sssd.spec for SLES

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 06:53 AM, Sumit Bose wrote: On Fri, Dec 11, 2009 at 02:58:36PM +0300, Sergei V. Kovylov wrote: Oh sorry - my mistake. Unfourtunately, I'm not able to do a patch in git format , as I've never work with git. ok, I have 'converted'

Re: [SSSD] [PATCH] fix for #323

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 07:22 AM, Sumit Bose wrote: On Mon, Dec 14, 2009 at 04:03:27PM -0500, Simo Sorce wrote: Now the upgrade process can cope with converting ols ssd.ldb files into multiple databases even if the new config file does not include a local

[SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-15 Thread transifex
Hello sssd, this is Transifex at http://www.transifex.net. The following attached files were submitted to SSSD | master by goeran goe...@uddeborg.se Please, visit Transifex at http://www.transifex.net/projects/p/sssd/c/master/ in order to see the component page. Thank you, Transifex #

Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Sumit Bose
Ok this new version deletes the files only if there were no errors and adds a missing dependency when sysdb-tests is build individually in a clean tree. bye, Sumit On Tue, Dec 15, 2009 at 06:41:48AM -0500, Stephen Gallagher wrote: Nack. Please make this conditional on success of all tests. If

[SSSD] [PATCH] Fix warning in server.c

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Trivial fix to correct a warning introduced by 850d250442aaae413c054cf8136506e8d90f2fbe - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors.

Re: [SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 09:54 AM, transi...@gmail.com wrote: Göran Uddeborg goe...@uddeborg.se Attached patch incorporates the changes from this submission. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in

Re: [SSSD] [PATCH] Fix warning in server.c

2009-12-15 Thread Simo Sorce
On Tue, 2009-12-15 at 14:27 -0500, Stephen Gallagher wrote: Trivial fix to correct a warning introduced by 850d250442aaae413c054cf8136506e8d90f2fbe ack Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 11:36 AM, Sumit Bose wrote: Ok this new version deletes the files only if there were no errors and adds a missing dependency when sysdb-tests is build individually in a clean tree. Ack. - -- Stephen Gallagher RHCE 804006346421761

[SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-15 Thread transifex
Hello sssd, this is Transifex at http://www.transifex.net. The following attached files were submitted to SSSD | master by goeran goe...@uddeborg.se Please, visit Transifex at http://www.transifex.net/projects/p/sssd/c/master/ in order to see the component page. Thank you, Transifex #

Re: [SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 02:50 PM, Stephen Gallagher wrote: On 12/15/2009 09:54 AM, transi...@gmail.com wrote: Göran Uddeborg goe...@uddeborg.se Attached patch incorporates the changes from this submission. Updated patch includes changes from submission

Re: [SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-15 Thread Simo Sorce
On Tue, 2009-12-15 at 15:34 -0500, Stephen Gallagher wrote: Updated patch includes changes from submission later today. Ack Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCHES] Fix configuration mistakes

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 02:58 PM, Simo Sorce wrote: On Tue, 2009-12-15 at 14:26 -0500, Stephen Gallagher wrote: Patch 0001: Fix https://fedorahosted.org/sssd/ticket/329 If the domain heartbeat time was explicitly set in the configuration to 0, we would

Re: [SSSD] [PATCH] Fix warning in server.c

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 03:05 PM, Simo Sorce wrote: On Tue, 2009-12-15 at 14:27 -0500, Stephen Gallagher wrote: Trivial fix to correct a warning introduced by 850d250442aaae413c054cf8136506e8d90f2fbe ack Simo. Pushed to master and 1-0-0 - --

Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 03:12 PM, Stephen Gallagher wrote: On 12/15/2009 11:36 AM, Sumit Bose wrote: Ok this new version deletes the files only if there were no errors and adds a missing dependency when sysdb-tests is build individually in a clean tree.

Re: [SSSD] [Transifex] File submitted via email to SSSD | master

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 03:37 PM, Simo Sorce wrote: On Tue, 2009-12-15 at 15:34 -0500, Stephen Gallagher wrote: Updated patch includes changes from submission later today. Ack Simo. Pushed to master and 1-0-0 - -- Stephen Gallagher RHCE