Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

On Mon, Feb 01, 2010 at 01:33:27PM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patches 0001-0003: License and package libpath_utils Patches 0004-0007: License and package libcollection. (Patch 0005 fixes an incorrect #include in collection.h) Patch

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/01/2010 07:11 PM, Dmitri Pal wrote: Stephen Gallagher wrote: Patches 0001-0003: License and package libpath_utils 01: In the header should the COPYING.lesser be COPYING.LESSER? Otherwise Ok. I will correct that. 02: Ok 03: I can' review

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2010 05:50 AM, Sumit Bose wrote: NACK libini does not build anymore because it cannot find libcollection. The changes 0006-Split-off-libcollection-into-a-shared-library.patch does in server/ needs to be ported to common/ini/, too.

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

Stephen Gallagher wrote: On 02/01/2010 07:11 PM, Dmitri Pal wrote: Stephen Gallagher wrote: Patches 0001-0003: License and package libpath_utils 01: In the header should the COPYING.lesser be COPYING.LESSER? Otherwise Ok. I will correct that. 02: Ok 03: I can' review this file I

Re: [SSSD] [PATCHES] Split off helper libraries into their own packages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2010 08:15 AM, Dmitri Pal wrote: Are you including trace.h into the library? Without it the debug build will be broken. It should be a part of the SRPM. trace.h is available in the tarball, and its path is still listed in the

[SSSD] [PATCH] Enable debug_timestamps by default

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We will use timestamps unless they are explicitly disabled in the sssd.conf. I am not removing the --debug_timestamps option to the services so as to maintain backwards compatibility. This patch resolves https://fedorahosted.org/sssd/ticket/389 - --

Re: [SSSD] [PATCH] Enable debug_timestamps by default

On Tue, 02 Feb 2010 09:50:44 -0500 Stephen Gallagher sgall...@redhat.com wrote: We will use timestamps unless they are explicitly disabled in the sssd.conf. I am not removing the --debug_timestamps option to the services so as to maintain backwards compatibility. This patch resolves

Re: [SSSD] [PATCH] Warn the user if authentication happens offline

On Mon, Feb 01, 2010 at 09:24:47AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/28/2010 11:37 AM, Sumit Bose wrote: Hi, this patch should fix #239. All translatable strings are in the pam client and now it should be quite easy to add new

Re: [SSSD] [PATCH] Enable debug_timestamps by default

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2010 10:46 AM, Simo Sorce wrote: On Tue, 02 Feb 2010 09:50:44 -0500 Stephen Gallagher sgall...@redhat.com wrote: We will use timestamps unless they are explicitly disabled in the sssd.conf. I am not removing the --debug_timestamps

[SSSD] [PATCH] Internationalize help messages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I discovered this while working on https://fedorahosted.org/sssd/ticket/389. We are not currently translating the help messages printed when 'sssd - --help' (or similar) is run. This patch depends on the Enable debug_timestamps by default patch. -

Re: [SSSD] [PATCH] Warn the user if authentication happens offline

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2010 11:37 AM, Sumit Bose wrote: On Mon, Feb 01, 2010 at 09:24:47AM -0500, Stephen Gallagher wrote: Nitpick: In the sysdb-tests, could you please add a simple check for whether expire_date is zero or nonzero (as appropriate). It