Re: [SSSD] [PATCH] Added option to use libcrypto from OpenSSL instead of NSS.

2010-02-04 Thread George McCollister
Sumit, I've attached a new version of the patch with the changes you suggested. just some minor nitpicks: - please reformat the commit message to use multiple lines not longer than 80 characters Fixed. - can you rename SSS_SOURCES to SSS_CRYPT_SOURCES Thats what I meant to do in

Re: [SSSD] [PATCH] Add missing include

2010-02-04 Thread Sumit Bose
On Thu, Feb 04, 2010 at 07:56:06PM +0100, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 A one liner - I noticed that pam_sss.c uses snprintf but does not include stdio.h (vsnprintf is used elsewhere which is declared in correctly included stdarg.h) I just wrote the same

Re: [SSSD] [PATCH] Reactivate old fd handling conditionally

2010-02-04 Thread Sumit Bose
On Thu, Feb 04, 2010 at 09:02:51AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/04/2010 08:15 AM, Sumit Bose wrote: Hi, this path reintroduces the old way of handling the file description of a LDAP connection if the connection callback is not