[SSSD] [PATCH] Add check for broken LDAP connection callbacks

2010-02-12 Thread Sumit Bose
Hi, this patch extends the test for LDAP connection callbacks. There is a bug in OpenLDAP 2.4.12 which makes ldap_set_option() fail. Now it is first check if the ldap_conncb structure is available and then if ldap_set_option() succeeds. bye, Sumit From df6dcf338c4fef8428949ced3de4a28cf9282088

[SSSD] [PATCH] gitignore additions

2010-02-12 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 add some binaries to .gitignore -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkt1Ru8ACgkQHsardTLnvCUSHwCZAbA8V4tNRAHaeTxAhFC57pKh

Re: [SSSD] [PATCH] Don't pass a variable as format to talloc_asprintf()

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:22 AM, Martin Nagy wrote: Hi, SSIA. Martin Ack. Agreed, this has bitten us in the past. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors.

Re: [SSSD] [PATCH] gitignore additions

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:17 AM, Jakub Hrozek wrote: add some binaries to .gitignore Ack. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

Re: [SSSD] [PATCHES] Turn the ConfDB into its own package

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 08:04 AM, Sumit Bose wrote: On Tue, Feb 09, 2010 at 03:46:10PM -0500, Stephen Gallagher wrote: On 02/08/2010 03:34 AM, Sumit Bose wrote: On Fri, Feb 05, 2010 at 12:25:05PM -0500, Stephen Gallagher wrote: These three patches are the

Re: [SSSD] [PATCH] Add check for broken LDAP connection callbacks

2010-02-12 Thread Jeff Schroeder
On Fri, Feb 12, 2010 at 3:50 AM, Sumit Bose sb...@redhat.com wrote: Hi, this patch extends the test for LDAP connection callbacks. There is a bug in OpenLDAP 2.4.12 which makes ldap_set_option() fail. Now it is first check if the ldap_conncb structure is available and then if

Re: [SSSD] [PATCH] Add check for broken LDAP connection callbacks

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 08:34 AM, Jeff Schroeder wrote: On Fri, Feb 12, 2010 at 3:50 AM, Sumit Bose sb...@redhat.com wrote: Hi, this patch extends the test for LDAP connection callbacks. There is a bug in OpenLDAP 2.4.12 which makes ldap_set_option() fail.

Re: [SSSD] [PATCH] Don't pass a variable as format to talloc_asprintf()

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:23 AM, Stephen Gallagher wrote: On 02/12/2010 07:22 AM, Martin Nagy wrote: Hi, SSIA. Martin Ack. Agreed, this has bitten us in the past. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering

Re: [SSSD] [PATCH] Make change password errors more transparent

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:28 AM, Stephen Gallagher wrote: On 02/12/2010 05:02 AM, Sumit Bose wrote: Hi, this patch send the error message from an LDAP or Kerberos server back to the user if a password change fails. I think we do not disclose information

Re: [SSSD] [PATCH] gitignore additions

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:30 AM, Stephen Gallagher wrote: On 02/12/2010 07:17 AM, Jakub Hrozek wrote: add some binaries to .gitignore Ack. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat

Re: [SSSD] [PATCH] Remove ELAPI from the SSSD repo

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:44 AM, Sumit Bose wrote: On Tue, Feb 09, 2010 at 04:10:26PM -0500, Stephen Gallagher wrote: ELAPI now lives at https://fedorahosted.org/ELAPI This patch removes the ELAPI source from the tree (and build). The patch is gzipped

Re: [SSSD] [PATCH] sss_groupshow: separate member lists by comma

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 07:47 AM, Stephen Gallagher wrote: On 02/12/2010 07:17 AM, Jakub Hrozek wrote: For some reason I separated the member lists with colon, not comma..this simple patch fixes that and is the real fix for #398 Ack. Pushed to

Re: [SSSD] [PATCH] Add check for broken LDAP connection callbacks

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 08:36 AM, Stephen Gallagher wrote: On 02/12/2010 08:34 AM, Jeff Schroeder wrote: On Fri, Feb 12, 2010 at 3:50 AM, Sumit Bose sb...@redhat.com wrote: Hi, this patch extends the test for LDAP connection callbacks. There is a bug in

[SSSD] [PATCH] Make attr_type an integer

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This patch refers to the SBUS communication for getAccountInfo. Previously it was a string being passed and converted into an integer. It will be more efficient this way (and simpler for other implementers) - -- Stephen Gallagher RHCE

Re: [SSSD] [PATCHES] Turn the ConfDB into its own package

2010-02-12 Thread Sumit Bose
On Fri, Feb 12, 2010 at 10:31:04AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 09:17 AM, Stephen Gallagher wrote: On 02/12/2010 08:08 AM, Stephen Gallagher wrote: On 02/12/2010 08:04 AM, Sumit Bose wrote: I have two comments: +docs:

Re: [SSSD] [PATCH] Make attr_type an integer

2010-02-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/12/2010 10:50 AM, Stephen Gallagher wrote: This patch refers to the SBUS communication for getAccountInfo. Previously it was a string being passed and converted into an integer. It will be more efficient this way (and simpler for other