Re: [SSSD] [PATCH] Check and set permissions on SBUS sockets

2010-02-22 Thread Sumit Bose
On Fri, Feb 19, 2010 at 03:46:43PM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/19/2010 08:49 AM, Sumit Bose wrote: Hi, this patch should fix #403. libdbus is so nice to call chmod(0777) explicitly on a newly created socket so we have to

[SSSD] [PATCH] Clean up DP registration and PAM request interfaces

2010-02-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There is no need to pass domain as a parameter to the data provider. We're already talking directly to the provider for that domain. Both the provider and responder are fully aware of which domain is being queried without passing this parameter. It

Re: [SSSD] [PATCH] Clean up DP registration and PAM request interfaces

2010-02-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2010 10:14 AM, Stephen Gallagher wrote: There is no need to pass domain as a parameter to the data provider. We're already talking directly to the provider for that domain. Both the provider and responder are fully aware of which domain is

Re: [SSSD] [PATCH] Clean up DP registration and PAM request interfaces

2010-02-22 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2010 05:34 PM, Stephen Gallagher wrote: Simo noticed a typo on this patch during code review. Fixed. * providers/data_provider.h:67 still mentions domains in the PAM response packet * I'm not sure about removing pd-domain from

[SSSD] [PATCH] Restrict family lookups

2010-02-22 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adds a new option that tells resolver which address family to prefer or use exclusively. Fixes: #404 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

[SSSD] [PATCH] Remove Kerberos options from confdb.h

2010-02-22 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kerberos-specific options are pulled using dp_get_opts() and defined in Kerberos subtree. There is no need to keep these in confdb. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora -

Re: [SSSD] [PATCH] Clean up DP registration and PAM request interfaces

2010-02-22 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2010 06:30 PM, Stephen Gallagher wrote: New patch attached. Ack -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [SSSD] [PATCH] Remove Kerberos options from confdb.h

2010-02-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2010 12:46 PM, Stephen Gallagher wrote: On 02/22/2010 12:36 PM, Jakub Hrozek wrote: Kerberos-specific options are pulled using dp_get_opts() and defined in Kerberos subtree. There is no need to keep these in confdb. Ack. Pushed to

Re: [SSSD] [PATCH] Restrict family lookups

2010-02-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2010 12:49 PM, Stephen Gallagher wrote: On 02/22/2010 12:35 PM, Jakub Hrozek wrote: Adds a new option that tells resolver which address family to prefer or use exclusively. Fixes: #404 Looks good to me. Ack. Pushed to master. -

Re: [SSSD] [PATCH] Clean up DP registration and PAM request interfaces

2010-02-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/22/2010 12:19 PM, Jakub Hrozek wrote: On 02/22/2010 05:34 PM, Stephen Gallagher wrote: Simo noticed a typo on this patch during code review. Fixed. * providers/data_provider.h:67 still mentions domains in the PAM response packet Fixed *