Re: [SSSD] [PATCH] Only set _GNU_SOURCE if not already set

2011-05-20 Thread Jakub Hrozek
On 05/19/2011 05:12 PM, Sumit Bose wrote: Hi, there are a couple of places where we set _GNU_SOURCE in the source files to enable glibc specific extensions. If by chance '-D_GNU_SOURCE=1' is set on the gcc command line, e.g. by using the CFLAGS from a pkg-config output (yes, there are

Re: [SSSD] [PATCH] Only set _GNU_SOURCE if not already set

2011-05-20 Thread Sumit Bose
On Fri, May 20, 2011 at 09:34:06AM +0200, Jakub Hrozek wrote: On 05/19/2011 05:12 PM, Sumit Bose wrote: Hi, there are a couple of places where we set _GNU_SOURCE in the source files to enable glibc specific extensions. If by chance '-D_GNU_SOURCE=1' is set on the gcc command line, e.g.

Re: [SSSD] RFC: a substitute for the hostent structure

2011-05-20 Thread Jakub Hrozek
On 05/19/2011 12:46 PM, Jakub Hrozek wrote: I was also considering using struct sockaddr_storage because that is defined in system headers and some sources[1] recommend it, but I also think that semantics of sockaddr structures is more tied to connecting to a socket than just pure resolving.

[SSSD] sssd and sub-domains

2011-05-20 Thread Sumit Bose
Hi, with this email I would like to start some discussion and collect ideas and use-cases about a new concept for sssd, namely sub-domains. Currently in sssd a domain is like a single namespace which has to be defined in sssd.conf and only users from explicitly known domains are supported. E.g.

Re: [SSSD] [PATCH] Fixed copying of pam_data structure

2011-05-20 Thread Stephen Gallagher
On Tue, 2011-05-17 at 14:07 +0200, Jakub Hrozek wrote: On 05/17/2011 10:27 AM, Jan Zelený wrote: This is what caused the wrong error message described in related ticket. The code for the right error message was already there, but it didn't execute because of this bug. Related

Re: [SSSD] [PATCH] IPA Provider: don't fail if user is not a member of any groups

2011-05-20 Thread Stephen Gallagher
On Tue, 2011-05-17 at 21:21 +0200, Jakub Hrozek wrote: On Tue, May 17, 2011 at 12:52:26PM -0400, Stephen Gallagher wrote: We were erroneously returning ENOENT, but the associated _done() function treats all error codes other than EOK as fatal. This patch modifies sdap_initgr_nested_send()

Re: [SSSD] [PATCH] two cleanup patches

2011-05-20 Thread Stephen Gallagher
On Wed, 2011-05-18 at 20:40 +0200, Jan Zeleny wrote: Jakub Hrozek jhro...@redhat.com wrote: [PATCH 1/2] Remove append_attrs_to_array This used to be part of the deref patchset. Since the function is not used, I think it should be removed. Sounds reasonable. Even in the patch itself I

Re: [SSSD] [PATCH] Add options to override GID, homedir and shell

2011-05-20 Thread Stephen Gallagher
On Thu, 2011-05-19 at 10:11 +0200, Jakub Hrozek wrote: On 05/18/2011 06:02 PM, Stephen Gallagher wrote: On Wed, 2011-05-18 at 17:48 +0200, Jakub Hrozek wrote: Patch 0003: Nack. One last minor change. I realized that nss_get_etc_shells() could be vulnerable to a race-condition attack. If

Re: [SSSD] [PATCH] Add options to override GID, homedir and shell

2011-05-20 Thread Stephen Gallagher
On Fri, 2011-05-20 at 05:48 -0400, Stephen Gallagher wrote: On Thu, 2011-05-19 at 10:11 +0200, Jakub Hrozek wrote: On 05/18/2011 06:02 PM, Stephen Gallagher wrote: On Wed, 2011-05-18 at 17:48 +0200, Jakub Hrozek wrote: Patch 0003: Nack. One last minor change. I realized that

Re: [SSSD] [PATCH] Use dereference to speed up RFC2307bis group processing

2011-05-20 Thread Stephen Gallagher
On Wed, 2011-05-18 at 16:41 +0200, Jakub Hrozek wrote: On 05/09/2011 07:23 PM, Stephen Gallagher wrote: Continuing my review. Comments inline. New patches are attached. They are formatted with -M -C --patience --full-index, per Simo's suggestion. I think it helped, especially with patch

Re: [SSSD] [PATCHES] Build-system improvements

2011-05-20 Thread Stephen Gallagher
On Thu, 2011-05-19 at 10:53 +0200, Jakub Hrozek wrote: On 05/18/2011 10:40 PM, Jan Zeleny wrote: Stephen Gallagher sgall...@redhat.com wrote: Patch 0001: Stop building a fake interface version into the backend plugins. This is not the correct way to create a plugin module with libtool.

Re: [SSSD] [PATCH] Use dereference to speed up RFC2307bis group processing

2011-05-20 Thread Stephen Gallagher
On Fri, 2011-05-20 at 13:15 +0200, Jakub Hrozek wrote: On 05/20/2011 12:10 PM, Stephen Gallagher wrote: Patch 0001: Ack Patch 0002: Ack Patch 0003: Ack Patch 0004: Ack Patch 0005: Ack Patch 0006: Ack Patch 0007: Ack Patch 0008: Ack Patch 0009: Nack. Please add