Re: [SSSD] [PATCH] AUTOFS: fix copy-and-paste bug in the autofs client

2012-03-26 Thread Jan Zelený
I found this while working on the Coverity bug. This bug could potentially cause a segfault. Ack Jan signature.asc Description: This is a digitally signed message part. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] LDAP services: Keep the protocol around

2012-03-26 Thread Jan Zelený
We forgot to set the protocol member of a state structure which resulted in a funny behaviour - if a service supported a protocol and another protocol was requested, the sysdb entry for that service was removed. Ack Jan signature.asc Description: This is a digitally signed message part.

Re: [SSSD] [PATCH] Silence Coverity warning in the autofs test tool

2012-03-26 Thread Jan Zelený
I think Coverity is being too noisy here, because only if _sss_getautomntent_r() succeeds, then key and value are allocated. This fix should hopefully explain the code to Coverity, too :-) I have a question regarding the part of code where you delete exit() calls and replace them with jumps

Re: [SSSD] Problem in sssd and libsss_autofs

2012-03-26 Thread Stephen Gallagher
On Sat, 2012-03-24 at 16:35 +0100, Marco Pizzoli wrote: Hi guys, I would like to report this packaging(?) problem. As you can see in the following output, there's not a dependency between the rpm libsss_autofs and sssd. You're right. Looks like we're (incorrectly) including libsss_autofs.so

Re: [SSSD] Problem in sssd and libsss_autofs

2012-03-26 Thread Stephen Gallagher
On Mon, 2012-03-26 at 08:02 -0400, Stephen Gallagher wrote: On Sat, 2012-03-24 at 16:35 +0100, Marco Pizzoli wrote: Hi guys, I would like to report this packaging(?) problem. As you can see in the following output, there's not a dependency between the rpm libsss_autofs and sssd.

Re: [SSSD] [PATCH] Silence Coverity warning in the autofs test tool

2012-03-26 Thread Jakub Hrozek
On Mon, Mar 26, 2012 at 11:17:37AM +0200, Jan Zelený wrote: I think Coverity is being too noisy here, because only if _sss_getautomntent_r() succeeds, then key and value are allocated. This fix should hopefully explain the code to Coverity, too :-) I have a question regarding the part of

Re: [SSSD] [PATCH] sudo api: return only errno in sss_sudo_make_request()

2012-03-26 Thread Jakub Hrozek
On Fri, Mar 23, 2012 at 01:04:52PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1233 As Jakub suggested, I changed sss_sudo_make_request() to return only errno code, instead of errno and sss_status. I hope this will make the Coverity happy. Sorry, that's not exactly what

Re: [SSSD] [PATCH][PRELIMINARY] sudo: send username and uid while requesting default options

2012-03-26 Thread Jakub Hrozek
On Mon, Mar 19, 2012 at 02:46:02PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1239 [PATCH 1/2] Finally removes EOK constant from sudo api header. It is not used in the SUDO code so it does not require their changes. Looks good to me, it'w weird to use EOK in an

Re: [SSSD] [PATCH][PRELIMINARY] sudo: send username and uid while requesting default options

2012-03-26 Thread Simo Sorce
On Mon, 2012-03-26 at 15:47 -0400, Jakub Hrozek wrote: On Mon, Mar 19, 2012 at 02:46:02PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1239 [PATCH 1/2] Finally removes EOK constant from sudo api header. It is not used in the SUDO code so it does not require their

[SSSD] [PATCHES] Four small assorted patches on top of the previous set

2012-03-26 Thread Dmitri Pal
-- Thank you, Dmitri Pal Sr. Engineering Manager IPA project, Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From aa1ba9987197a0fb27a0d50744471703f57ecd47 Mon Sep 17 00:00:00 2001 From: Dmitri Pal d...@redhat.com Date: Mon, 26 Mar

Re: [SSSD] [PATCH] Add idmap library

2012-03-26 Thread Stephen Gallagher
On Fri, 2012-03-23 at 08:23 -0400, Stephen Gallagher wrote: On Thu, 2012-03-22 at 12:21 +0100, Sumit Bose wrote: On Thu, Mar 22, 2012 at 11:39:31AM +0100, Sumit Bose wrote: On Wed, Mar 21, 2012 at 02:49:05PM -0400, Stephen Gallagher wrote: On Mon, 2012-03-19 at 17:18 +0100, Sumit Bose

Re: [SSSD] [PATCH] AUTOFS: fix copy-and-paste bug in the autofs client

2012-03-26 Thread Stephen Gallagher
On Mon, 2012-03-26 at 11:01 +0200, Jan Zelený wrote: I found this while working on the Coverity bug. This bug could potentially cause a segfault. Ack Pushed to master and sssd-1-8. signature.asc Description: This is a digitally signed message part

Re: [SSSD] [PATCH] LDAP: Fix memory leaks in synchronous_tls_setup

2012-03-26 Thread Stephen Gallagher
On Fri, 2012-03-23 at 13:55 +0100, Jan Zelený wrote: We were never freeing result if it was allocated by ldap_result(). We were also not freeing errmsg if it was allocated but ldap_parse_result() returned an error. Also disambiguate error messages from ldap_parse_result() and error

Re: [SSSD] [PATCH] LDAP services: Keep the protocol around

2012-03-26 Thread Stephen Gallagher
On Mon, 2012-03-26 at 11:05 +0200, Jan Zelený wrote: We forgot to set the protocol member of a state structure which resulted in a funny behaviour - if a service supported a protocol and another protocol was requested, the sysdb entry for that service was removed. Ack Pushed to master

[SSSD] [PATCH] BUILDSYS: Create common libs for LDAP and KRB5 sources

2012-03-26 Thread Stephen Gallagher
This will eliminate the need for automake to build these files for each backend that consumes LDAP and KRB5 functionality (currently 'ldap', 'krb5' and 'ipa'; soon to include 'ad') This will speed up builds slightly, since they won't need to compile each of these files three times and it will

Re: [SSSD] [PATCH][PRELIMINARY] sudo: send username and uid while requesting default options

2012-03-26 Thread Jakub Hrozek
On Mon, Mar 26, 2012 at 06:35:08PM -0400, Simo Sorce wrote: On Mon, 2012-03-26 at 15:47 -0400, Jakub Hrozek wrote: On Mon, Mar 19, 2012 at 02:46:02PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1239 [PATCH 1/2] Finally removes EOK constant from sudo api header.

Re: [SSSD] [PATCH] BUILDSYS: Create common libs for LDAP and KRB5 sources

2012-03-26 Thread Jakub Hrozek
On Mon, Mar 26, 2012 at 09:53:08PM -0400, Stephen Gallagher wrote: This will eliminate the need for automake to build these files for each backend that consumes LDAP and KRB5 functionality (currently 'ldap', 'krb5' and 'ipa'; soon to include 'ad') This will speed up builds slightly, since