Re: [SSSD] [PATCHES][DING-LIBS] Fix two distcheck issues with libini_config

2012-05-14 Thread Jan Zelený
On 05/11/2012 04:21 PM, Dmitri Pal wrote: On 05/11/2012 10:04 AM, Stephen Gallagher wrote: Patch 0001: The unit tests for libini_config need to be able to validate specific permissions on some sample data. However, 'make distcheck' always removes the 'write' permissions on data in the

Re: [SSSD] Cached user info?

2012-05-14 Thread Jan Zelený
On 5/11/12 10:22 AM, Stephen Gallagher wrote: On Fri, 2012-05-11 at 10:19 -0400, Braden McDaniel wrote: As I mentioned at the top of the thread, I changed the local group GID on the Fedora 16 installation to 989 (from 990) to match the Fedora 17 installation. Things appear to be working

Re: [SSSD] Cached user info?

2012-05-14 Thread Jan Zelený
On Fri, 2012-05-11 at 09:41 +0200, Jan Zelený wrote: On Fri, 2012-05-11 at 09:10 +0200, Jan Zelený wrote: On Fri, 2012-05-11 at 08:38 +0200, Jan Zelený wrote: I guess SSSD cache is probably the reason why you still have the old GID. Try running sss_cache -G to invalidate all

Re: [SSSD] [PATCH] Fix typos in message and man pages.

2012-05-14 Thread Jan Zelený
A patch by Yuri Chornoivan. I had to look up supercede vs. supersede but it seems Yuri is right. https://bugzilla.redhat.com/show_bug.cgi?id=821088 Ack Jan signature.asc Description: This is a digitally signed message part. ___ sssd-devel

Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails

2012-05-14 Thread Jan Zelený
https://fedorahosted.org/sssd/ticket/1332 Obvious Ack, Jan signature.asc Description: This is a digitally signed message part. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails

2012-05-14 Thread Jakub Hrozek
On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Barria wrote: https://fedorahosted.org/sssd/ticket/1332 +if ( fd 0 ){ Thanks for the patch Ariel, but would you also mind amending the whitespace? We don't put whitespace between brackets and the expression inside, but we do put a space

Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails

2012-05-14 Thread Jan Zelený
On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Barria wrote: https://fedorahosted.org/sssd/ticket/1332 +if ( fd 0 ){ Thanks for the patch Ariel, but would you also mind amending the whitespace? We don't put whitespace between brackets and the expression inside, but we do put

Re: [SSSD] [PATCHES] Better handling of large Active Directory groups

2012-05-14 Thread Jan Zelený
On Thu, 2012-05-10 at 11:15 +0200, Jakub Hrozek wrote: On Wed, May 09, 2012 at 07:19:29PM -0400, Stephen Gallagher wrote: On Wed, 2012-05-09 at 22:20 +0200, Jakub Hrozek wrote: Nack, the way ldap_get_dn is used leaks memory: +DEBUG(SSSDBG_TRACE_INTERNAL, +

Re: [SSSD] Resolve link failure in sssd-1.8.3 on newer binutils

2012-05-14 Thread Jan Engelhardt
On Friday 2012-05-11 20:31, Stephen Gallagher wrote: sssd_be_LDADD = \ -$(SSSD_LIBS) \ +-ldl $(SSSD_LIBS) \ $(CARES_LIBS) \ libsss_util.la sssd_be_LDFLAGS = \ While there's nothing wrong with this patch, you SHOULD be picking up the -ldl requirement from pkg-config for

Re: [SSSD] [PATCHES][DING-LIBS] Fix two distcheck issues with libini_config

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote: On 05/11/2012 04:21 PM, Dmitri Pal wrote: On 05/11/2012 10:04 AM, Stephen Gallagher wrote: Patch 0001: The unit tests for libini_config need to be able to validate specific permissions on some sample data. However, 'make distcheck'

Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 10:22 +0200, Jakub Hrozek wrote: On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Barria wrote: https://fedorahosted.org/sssd/ticket/1332 +if ( fd 0 ){ Thanks for the patch Ariel, but would you also mind amending the whitespace? We don't put whitespace

Re: [SSSD] Resolve link failure in sssd-1.8.3 on newer binutils

2012-05-14 Thread Stephen Gallagher
On Fri, 2012-05-11 at 23:02 +0200, Jan Engelhardt wrote: On Friday 2012-05-11 20:31, Stephen Gallagher wrote: sssd_be_LDADD = \ -$(SSSD_LIBS) \ +-ldl $(SSSD_LIBS) \ $(CARES_LIBS) \ libsss_util.la sssd_be_LDFLAGS = \ While there's nothing wrong with this patch,

Re: [SSSD] Rename struct dom_sid to struct sss_dom_sid

2012-05-14 Thread Simo Sorce
On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote: Hi, although we currently use the same internal representation for struct dom_sid as samba does this might not be the case in future. To avoid irritations this patch changes

Re: [SSSD] [PATCHES][DING-LIBS] Fix two distcheck issues with libini_config

2012-05-14 Thread Dmitri Pal
On 05/14/2012 07:13 AM, Stephen Gallagher wrote: On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote: On 05/11/2012 04:21 PM, Dmitri Pal wrote: On 05/11/2012 10:04 AM, Stephen Gallagher wrote: Patch 0001: The unit tests for libini_config need to be able to validate specific permissions on

Re: [SSSD] [PATCHES][DING-LIBS] Fix two distcheck issues with libini_config

2012-05-14 Thread Jan Zelený
On 05/14/2012 07:13 AM, Stephen Gallagher wrote: On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote: On 05/11/2012 04:21 PM, Dmitri Pal wrote: On 05/11/2012 10:04 AM, Stephen Gallagher wrote: Patch 0001: The unit tests for libini_config need to be able to validate specific permissions

Re: [SSSD] [PATCHES][DING-LIBS] Fix two distcheck issues with libini_config

2012-05-14 Thread Dmitri Pal
On 05/14/2012 09:31 AM, Jan Zelený wrote: On 05/14/2012 07:13 AM, Stephen Gallagher wrote: On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote: On 05/11/2012 04:21 PM, Dmitri Pal wrote: On 05/11/2012 10:04 AM, Stephen Gallagher wrote: Patch 0001: The unit tests for libini_config need to be

Re: [SSSD] [PATCHES][DING-LIBS] Fix two distcheck issues with libini_config

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 08:41 -0400, Dmitri Pal wrote: foo.conf is no different that other test config files that reside in the ini.d directory. I do not understand why the change needed for one and not for the others. Can you please elaborate? Foo.conf is a special case. It's the only file

Re: [SSSD] Rename struct dom_sid to struct sss_dom_sid

2012-05-14 Thread Sumit Bose
On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote: On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote: Hi, although we currently use the same internal representation for struct dom_sid as samba does this might

Re: [SSSD] [PATCHES] Better handling of large Active Directory groups

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 10:13 +0200, Jan Zelený wrote: On Thu, 2012-05-10 at 11:15 +0200, Jakub Hrozek wrote: On Wed, May 09, 2012 at 07:19:29PM -0400, Stephen Gallagher wrote: On Wed, 2012-05-09 at 22:20 +0200, Jakub Hrozek wrote: Nack, the way ldap_get_dn is used leaks memory:

Re: [SSSD] Rename struct dom_sid to struct sss_dom_sid

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 15:37 +0200, Sumit Bose wrote: On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote: On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote: Hi, although we currently use the same internal

Re: [SSSD] Fix libsss_hbac library version

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 15:38 +0200, Sumit Bose wrote: Hi, while checking the version of libsss_idmap I found that there is a typo for libsss_hbac as well. This patch should fix it. Ack. As with libsss_idmap, this is NOT a soname bump. It only changes the revision number. signature.asc

[SSSD] Kerberos password, Office and Home network.

2012-05-14 Thread Daniel Löw
Hello! I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login even when I am offline. Everyting works great, but if I take the laptop home with me, and connect it to my home network, i cant login. Then it says that i have the wrong password. then if I want to be able to login i

[SSSD] [PATCH] Two sssd_nss patches

2012-05-14 Thread Jakub Hrozek
I found two sssd_nss bugs pretty much by accident. [PATCH 1/2] NSS: keep a pointer to body after body is reallocated When a memory is reallocated with talloc_realloc, the original pointer might be relocated elsewhere. The fullname pointer used to point to the original location before realloc

Re: [SSSD] Kerberos password, Office and Home network.

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 15:58 +0200, Daniel Löw wrote: Hello! I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login even when I am offline. Everyting works great, but if I take the laptop home with me, and connect it to my home network, i cant login. Then it says that i have

Re: [SSSD] Kerberos password, Office and Home network.

2012-05-14 Thread Dmitri Pal
On 05/14/2012 09:58 AM, Daniel Löw wrote: Hello! I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login even when I am offline. Everyting works great, but if I take the laptop home with me, and connect it to my home network, i cant login. Then it says that i have the wrong

Re: [SSSD] Kerberos password, Office and Home network.

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 10:09 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 15:58 +0200, Daniel Löw wrote: Hello! I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login even when I am offline. Everyting works great, but if I take the laptop home with me, and

[SSSD] [PATCH] Simple implementation of Netscape password warning expiration control

2012-05-14 Thread Stephen Gallagher
Joshua Roys submitted a patch in https://bugzilla.redhat.com/show_bug.cgi?id=726456 to add support for the Netscape password warning expiration control. I've made some modifications to his original patch to clean it up, so now I'm sending it to the list for further code-review. Fixes

Re: [SSSD] [PATCH] Potential NULL dereference in proxy provider

2012-05-14 Thread Stephen Gallagher
On Sun, 2012-05-13 at 20:42 +0200, Jakub Hrozek wrote: On Sat, May 12, 2012 at 11:05:30AM -0500, Ariel Barria wrote: https://fedorahosted.org/sssd/ticket/1333 Ack, thanks for the patch! Pushed to master and sssd-1-8. signature.asc Description: This is a digitally signed message part

Re: [SSSD] [PATCH] Fix typos in message and man pages.

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 09:34 +0200, Jan Zelený wrote: A patch by Yuri Chornoivan. I had to look up supercede vs. supersede but it seems Yuri is right. https://bugzilla.redhat.com/show_bug.cgi?id=821088 Ack Pushed to master. signature.asc Description: This is a digitally signed

Re: [SSSD] [PATCHES] Better handling of large Active Directory groups

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 09:45 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 10:13 +0200, Jan Zelený wrote: On Thu, 2012-05-10 at 11:15 +0200, Jakub Hrozek wrote: On Wed, May 09, 2012 at 07:19:29PM -0400, Stephen Gallagher wrote: On Wed, 2012-05-09 at 22:20 +0200, Jakub Hrozek

Re: [SSSD] Rename struct dom_sid to struct sss_dom_sid

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 09:47 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 15:37 +0200, Sumit Bose wrote: On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote: On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote:

Re: [SSSD] Fix libsss_hbac library version

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 09:48 -0400, Stephen Gallagher wrote: On Mon, 2012-05-14 at 15:38 +0200, Sumit Bose wrote: Hi, while checking the version of libsss_idmap I found that there is a typo for libsss_hbac as well. This patch should fix it. Ack. As with libsss_idmap, this is NOT a

Re: [SSSD] [PATCH][PRELIMINARY] sudo: send username and uid while requesting default options

2012-05-14 Thread Jakub Hrozek
On Mon, May 14, 2012 at 05:55:09PM +0200, Pavel Březina wrote: On 11.5.2012 12:23, Pavel Březina wrote: On 05/07/2012 07:17 PM, Pavel Březina wrote: On 05/03/2012 10:30 PM, Pavel Březina wrote: On 3.5.2012 13:48, Jakub Hrozek wrote: On Fri, Apr 27, 2012 at 01:21:30PM +0200, Jakub Hrozek

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Simo Sorce
On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote: - it ignores modifyTimestamp - simo suggested to use it in smart refresh when enabled in configuration and USN not available, but do we really want to use it? There is no other part in sssd that uses it (or am I wrong?).

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Stephen Gallagher
On Mon, 2012-05-14 at 13:16 -0400, Simo Sorce wrote: On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote: - it ignores modifyTimestamp - simo suggested to use it in smart refresh when enabled in configuration and USN not available, but do we really want to use it? There is no

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Pavel Březina
On 14.5.2012 20:40, Stephen Gallagher wrote: On Mon, 2012-05-14 at 13:16 -0400, Simo Sorce wrote: On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote: - it ignores modifyTimestamp - simo suggested to use it in smart refresh when enabled in configuration and USN not available, but do

Re: [SSSD] [PATCHES][PRELIMINARY] sudo - new design

2012-05-14 Thread Jakub Hrozek
On Mon, May 14, 2012 at 06:39:30PM +0200, Pavel Březina wrote: On 9.5.2012 17:07, Pavel Březina wrote: On 05/07/2012 07:13 PM, Pavel Březina wrote: On 04/23/2012 06:34 PM, Pavel Březina wrote: On 04/23/2012 05:04 PM, Pavel Březina wrote: Hello everybody, here is the first set of patches for

Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails

2012-05-14 Thread Ariel Barria
Thanks to comments From: sgall...@redhat.com To: sssd-devel@lists.fedorahosted.org Date: Mon, 14 May 2012 07:22:16 -0400 Subject: Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails On Mon, 2012-05-14 at 10:22 +0200, Jakub Hrozek wrote: On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel