Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Stephen Gallagher
Nack. Please make this conditional on success of all tests. If any tests fail, it can be useful to examine the contents of the DB files. On Dec 15, 2009, at 6:38 AM, Sumit Bose sb...@redhat.com wrote: Hi, with this patch the two ldb files created by the sysdb test are deleted at the end of

Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Sumit Bose
Ok this new version deletes the files only if there were no errors and adds a missing dependency when sysdb-tests is build individually in a clean tree. bye, Sumit On Tue, Dec 15, 2009 at 06:41:48AM -0500, Stephen Gallagher wrote: Nack. Please make this conditional on success of all tests. If

Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 11:36 AM, Sumit Bose wrote: Ok this new version deletes the files only if there were no errors and adds a missing dependency when sysdb-tests is build individually in a clean tree. Ack. - -- Stephen Gallagher RHCE 804006346421761

Re: [SSSD] [PATCH] Cleanup db files after test run

2009-12-15 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/15/2009 03:12 PM, Stephen Gallagher wrote: On 12/15/2009 11:36 AM, Sumit Bose wrote: Ok this new version deletes the files only if there were no errors and adds a missing dependency when sysdb-tests is build individually in a clean tree.