Re: [SSSD] [PATCH] Make return values more specific during password change

2010-02-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/09/2010 07:19 AM, Stephen Gallagher wrote: On 02/09/2010 05:53 AM, Sumit Bose wrote: new version attached bye, Sumit Ack. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red

Re: [SSSD] [PATCH] Make return values more specific during password change

2010-02-09 Thread Sumit Bose
On Mon, Feb 08, 2010 at 02:45:21PM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/08/2010 08:56 AM, Sumit Bose wrote: Hi, with this patch a user should get a better hint what went wrong if a password change operation failed. Nack (minor

Re: [SSSD] [PATCH] Make return values more specific during password change

2010-02-09 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/09/2010 05:53 AM, Sumit Bose wrote: On Mon, Feb 08, 2010 at 02:45:21PM -0500, Stephen Gallagher wrote: On 02/08/2010 08:56 AM, Sumit Bose wrote: Hi, with this patch a user should get a better hint what went wrong if a password change

[SSSD] [PATCH] Make return values more specific during password change

2010-02-08 Thread Sumit Bose
Hi, with this patch a user should get a better hint what went wrong if a password change operation failed. bye, Sumit From 2addacf0378e3083e6e5b2fd80fdc5e90877a201 Mon Sep 17 00:00:00 2001 From: Sumit Bose sb...@redhat.com Date: Mon, 8 Feb 2010 11:53:43 +0100 Subject: [PATCH] Make return values

Re: [SSSD] [PATCH] Make return values more specific during password change

2010-02-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/08/2010 08:56 AM, Sumit Bose wrote: Hi, with this patch a user should get a better hint what went wrong if a password change operation failed. Nack (minor nitpicks): DEBUG(1, (Failed to setup offline auth)); Missing '\n' DEBUG(5,