Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-27 Thread Stephen Gallagher
On Thu, 2012-04-12 at 21:53 -0400, Stephen Gallagher wrote: First of all, these patches are definitely preliminary. I'm mainly looking for input on whether I'm headed in the right direction. This thread is now concluded. Discussion should continue in the new thread [PATCHES] Add support for

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-23 Thread Sumit Bose
On Fri, Apr 20, 2012 at 03:01:17PM -0400, Stephen Gallagher wrote: On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: Hi Stephen, I went through all patches and I have couple things which I'd like to ask you about. First of all I'm not that familiar with ID mapping in winbind so my

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-23 Thread Stephen Gallagher
On Mon, 2012-04-23 at 10:56 +0200, Sumit Bose wrote: On Fri, Apr 20, 2012 at 03:01:17PM -0400, Stephen Gallagher wrote: On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: Hi Stephen, I went through all patches and I have couple things which I'd like to ask you about. First

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-23 Thread Sumit Bose
On Mon, Apr 23, 2012 at 07:27:55AM -0400, Stephen Gallagher wrote: On Mon, 2012-04-23 at 10:56 +0200, Sumit Bose wrote: On Fri, Apr 20, 2012 at 03:01:17PM -0400, Stephen Gallagher wrote: On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: Hi Stephen, I went through all patches

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-23 Thread Stephen Gallagher
On Mon, 2012-04-23 at 18:11 +0200, Sumit Bose wrote: sure, no problem, here is a sketch about the possilbe additions to libidmap. Would this work for you? Looks good to me, with one minor note below. diff --git a/src/lib/idmap/sss_idmap.h b/src/lib/idmap/sss_idmap.h index dbb2700..3855d9c

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-22 Thread Simo Sorce
On Sat, 2012-04-21 at 10:31 -0400, Stephen Gallagher wrote: On Fri, 2012-04-20 at 15:01 -0400, Stephen Gallagher wrote: On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: So in the default case: ldap_idmap_range_min = 100,001 ldap_idmap_range_max = 2,000,100,000 ldap_idmap_range_size

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-22 Thread Stephen Gallagher
On Sun, 2012-04-22 at 09:30 -0400, Simo Sorce wrote: On Sat, 2012-04-21 at 10:31 -0400, Stephen Gallagher wrote: On Fri, 2012-04-20 at 15:01 -0400, Stephen Gallagher wrote: On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: So in the default case: ldap_idmap_range_min = 100,001

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-21 Thread Stephen Gallagher
On Fri, 2012-04-20 at 15:01 -0400, Stephen Gallagher wrote: On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: So in the default case: ldap_idmap_range_min = 100,001 ldap_idmap_range_max = 2,000,100,000 ldap_idmap_range_size = 100,000 So what this means is that we will have 2000

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-20 Thread Stephen Gallagher
On Thu, 2012-04-12 at 22:12 -0400, Simo Sorce wrote: On Thu, 2012-04-12 at 21:53 -0400, Stephen Gallagher wrote: +#define SAFEALIGN_COPY_UINT8(dest, src, pctr) \ +safealign_memcpy(dest, src, sizeof(uint8_t), pctr) + +#define SAFEALIGN_COPY_INT8(dest, src, pctr) \ +

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-20 Thread Stephen Gallagher
On Fri, 2012-04-13 at 12:18 +0200, Jakub Hrozek wrote: On Thu, Apr 12, 2012 at 09:53:18PM -0400, Stephen Gallagher wrote: Patch 0006: The meat of the work. This patch will almost certainly be broken up into multiple patches before formal review, but right now it's late and I'm tired.

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-20 Thread Stephen Gallagher
On Fri, 2012-04-13 at 12:34 +0200, Jan Zelený wrote: Hi Stephen, I went through all patches and I have couple things which I'd like to ask you about. First of all I'm not that familiar with ID mapping in winbind so my questions might be trivial. If yes, sorry for that. First thing: I'd

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-13 Thread Jakub Hrozek
On Thu, Apr 12, 2012 at 09:53:18PM -0400, Stephen Gallagher wrote: Patch 0006: The meat of the work. This patch will almost certainly be broken up into multiple patches before formal review, but right now it's late and I'm tired. This patch initializes the idmap context, reading the LDB for

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-13 Thread Jan Zelený
First of all, these patches are definitely preliminary. I'm mainly looking for input on whether I'm headed in the right direction. Patch 0001: Add safe copy functions for 8-bit integers Patch 0002: LDAP: Add objectSID config option This patch is not complete (it needs manpages). This

Re: [SSSD] [PATCHES][PRELIMINARY] Add support for Active Directory objectSID mappings

2012-04-12 Thread Simo Sorce
On Thu, 2012-04-12 at 21:53 -0400, Stephen Gallagher wrote: +#define SAFEALIGN_COPY_UINT8(dest, src, pctr) \ +safealign_memcpy(dest, src, sizeof(uint8_t), pctr) + +#define SAFEALIGN_COPY_INT8(dest, src, pctr) \ +safealign_memcpy(dest, src, sizeof(int8_t), pctr) + Assigning a char