On Fri, 2011-11-25 at 06:55 +0100, Jakub Hrozek wrote:
On Tue, Nov 22, 2011 at 10:23:33AM -0500, Stephen Gallagher wrote:
Nack.
Looks good for the most part, but I'm not a huge fan of the three-way
boolean you're using for force_tls. I'd much prefer it if you just used
an enum
On Tue, Nov 22, 2011 at 10:23:33AM -0500, Stephen Gallagher wrote:
On Mon, 2011-11-07 at 14:34 +0100, Jakub Hrozek wrote:
On Sun, Sep 25, 2011 at 04:44:55PM +0200, Jakub Hrozek wrote:
On Tue, Sep 06, 2011 at 01:48:00PM -0400, Stephen Gallagher wrote:
On Thu, 2011-08-18 at 18:02 +0200,
On Mon, 2011-11-07 at 14:34 +0100, Jakub Hrozek wrote:
On Sun, Sep 25, 2011 at 04:44:55PM +0200, Jakub Hrozek wrote:
On Tue, Sep 06, 2011 at 01:48:00PM -0400, Stephen Gallagher wrote:
On Thu, 2011-08-18 at 18:02 +0200, Jakub Hrozek wrote:
On Thu, Aug 18, 2011 at 05:38:11PM +0200, Sumit
On Thu, 2011-08-18 at 18:02 +0200, Jakub Hrozek wrote:
On Thu, Aug 18, 2011 at 05:38:11PM +0200, Sumit Bose wrote:
On Thu, Aug 18, 2011 at 04:48:32PM +0200, Jan Zelený wrote:
The patches look fine, but I didn't manage to set up environment to test
the
new behavior. Nothing seems to
On Wed, Aug 17, 2011 at 04:58:05PM +0200, Jakub Hrozek wrote:
On Wed, Aug 17, 2011 at 01:15:31PM +0200, Jakub Hrozek wrote:
https://fedorahosted.org/sssd/ticket/924 started as a segfault ticket
but we could never reproduce the crash afterwards.
As Sumit noted it might have been caused by
On Wed, Aug 17, 2011 at 04:58:05PM +0200, Jakub Hrozek wrote:
On Wed, Aug 17, 2011 at 01:15:31PM +0200, Jakub Hrozek wrote:
https://fedorahosted.org/sssd/ticket/924 started as a segfault ticket
but we could never reproduce the crash afterwards.
As Sumit noted it might have been
On Thu, Aug 18, 2011 at 04:48:32PM +0200, Jan Zelený wrote:
On Wed, Aug 17, 2011 at 04:58:05PM +0200, Jakub Hrozek wrote:
On Wed, Aug 17, 2011 at 01:15:31PM +0200, Jakub Hrozek wrote:
https://fedorahosted.org/sssd/ticket/924 started as a segfault ticket
but we could never reproduce
On Thu, Aug 18, 2011 at 05:38:11PM +0200, Sumit Bose wrote:
On Thu, Aug 18, 2011 at 04:48:32PM +0200, Jan Zelený wrote:
On Wed, Aug 17, 2011 at 04:58:05PM +0200, Jakub Hrozek wrote:
On Wed, Aug 17, 2011 at 01:15:31PM +0200, Jakub Hrozek wrote:
https://fedorahosted.org/sssd/ticket/924
https://fedorahosted.org/sssd/ticket/924 started as a segfault ticket
but we could never reproduce the crash afterwards.
As Sumit noted it might have been caused by setting the O_NONBLOCK flag
twice. However, the changes Sumit proposed in the ticket still make
sense because they provide much
On Wed, Aug 17, 2011 at 01:15:31PM +0200, Jakub Hrozek wrote:
https://fedorahosted.org/sssd/ticket/924 started as a segfault ticket
but we could never reproduce the crash afterwards.
As Sumit noted it might have been caused by setting the O_NONBLOCK flag
twice. However, the changes Sumit
10 matches
Mail list logo
