Re: [SSSD] local vs LOCAL?

2009-11-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 06:17 AM, David O'Brien wrote: Should I be upper- or lower-casing local in the doc, or doesn't it matter? It seems to be spread evenly both ways in the wiki, and I'd like to standardize. thanks Currently, the domain that stores

Re: [SSSD] default value of filter_users_in_groups?

2009-11-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 07:00 AM, David O'Brien wrote: In the man page, it states that the default is true. I'm using v. 0.8.0 It does default to true according to the code. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG

[SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Sumit Bose
Hi, this patch adds the sysdb_attrs_replace_name() call to replace the name of an attribute with a new one. This is useful if you want to store the results of an LDAP query in sysdb, but need to replace certain attribute names, e.g. member or memberOf. bye, Sumit From

Re: [SSSD] what is sbus_timeout?

2009-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 06:05 AM, Jakub Hrozek wrote: On 11/04/2009 07:09 AM, David O'Brien wrote: David O'Brien wrote: This is in /etc/sssd/sssd.conf in the [sssd] section. I guess it's something like how long should a client or connection continue to

[SSSD] [PATCH] Do not delete users, groups outside domain range

2009-11-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #240 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkrxfaEACgkQHsardTLnvCV42ACfR7q6eEBeOIXtxntfXVT9SjzD 7moAoNlJLNnYWsxt5ouosuC8xn/DU6p6 =MVy0

Re: [SSSD] what is sbus_timeout?

2009-11-04 Thread Simo Sorce
On Wed, 2009-11-04 at 07:51 -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 06:05 AM, Jakub Hrozek wrote: On 11/04/2009 07:09 AM, David O'Brien wrote: David O'Brien wrote: This is in /etc/sssd/sssd.conf in the [sssd] section. I guess it's

[SSSD] [PATCH] Build the elapi_test suite without extra autoconf invocation

2009-11-04 Thread Stephen Gallagher
There's no need to have a separete configure.ac and Makefile.am for the elapi_test directory. By creating test-specific helper libraries, we can alter the CFLAGS for just the tests. This will speed up builds, as we do not need to run configure on an extra directory. It will also mean only one

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Sumit Bose
On Wed, Nov 04, 2009 at 12:53:22PM +0100, Sumit Bose wrote: Hi, this patch adds the sysdb_attrs_replace_name() call to replace the name of an attribute with a new one. This is useful if you want to store the results of an LDAP query in sysdb, but need to replace certain attribute names,

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Simo Sorce
On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: +if (e != NULL) { +dummy = talloc_strdup(talloc_parent(e-name), newname); The parent should be attrs, I would use that and not talloc_parent(), so even if the parent is something else, we get the new parent right. Simo. -- Simo

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Sumit Bose
On Wed, Nov 04, 2009 at 09:25:29AM -0500, Simo Sorce wrote: On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: +if (e != NULL) { +dummy = talloc_strdup(talloc_parent(e-name), newname); The parent should be attrs, I would use that and not talloc_parent(), so even if the

Re: [SSSD] what is sbus_timeout?

2009-11-04 Thread Jenny Galipeau
Simo Sorce wrote: On Wed, 2009-11-04 at 07:51 -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 06:05 AM, Jakub Hrozek wrote: On 11/04/2009 07:09 AM, David O'Brien wrote: David O'Brien wrote: This is in

Re: [SSSD] [PATCH] Fix for a seg fault during recursive delete

2009-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 10:43 AM, Sumit Bose wrote: Hi, this patch should fix #256. bye, Sumit ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Add sysdb_attrs_replace_name to sysdb API

2009-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 10:44 AM, Simo Sorce wrote: On Wed, 2009-11-04 at 16:11 +0100, Sumit Bose wrote: On Wed, Nov 04, 2009 at 09:25:29AM -0500, Simo Sorce wrote: On Wed, 2009-11-04 at 15:05 +0100, Sumit Bose wrote: +if (e != NULL) { +dummy =

[SSSD] Properly wrap #include krb5.h

2009-11-04 Thread Stephen Gallagher
Depending on the platform, krb5.h may be available as #include krb5.h or #include krb5/krb5.h We were properly testing for this in krb5_common.h, but not in sdap_async.c -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software

Re: [SSSD] [PATCHES] Fail over helper functions and reference counting wrappers

2009-11-04 Thread Martin Nagy
On Mon, 2009-11-02 at 16:02 -0500, Simo Sorce wrote: On Fri, 2009-10-30 at 14:07 +0100, Martin Nagy wrote: Hi, attached are patches needed for the fail over functionality. The service discovery is not there yet, I want to hold of with that until I have at least a basic SRV-based one so

Re: [SSSD] Properly wrap #include krb5.h

2009-11-04 Thread Sumit Bose
On Wed, Nov 04, 2009 at 12:24:40PM -0500, Stephen Gallagher wrote: Depending on the platform, krb5.h may be available as #include krb5.h or #include krb5/krb5.h We were properly testing for this in krb5_common.h, but not in sdap_async.c Sorry, I forgot to post the attached patch, it

[SSSD] [PATCH] Simplify debug_fn()

2009-11-04 Thread Stephen Gallagher
We don't need to be allocating an output string here. This was also causing a runtime bug when the output string contained characters that would be interpreted by fprintf as specifiers. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among

Re: [SSSD] [PATCH] Simplify debug_fn()

2009-11-04 Thread Sumit Bose
On Wed, Nov 04, 2009 at 02:01:44PM -0500, Stephen Gallagher wrote: We don't need to be allocating an output string here. This was also causing a runtime bug when the output string contained characters that would be interpreted by fprintf as specifiers. -- Stephen Gallagher RHCE

[SSSD] [PATCH] fix initgroups call

2009-11-04 Thread Simo Sorce
This set of patches ends up fixing the initgroups call. It still uses the slowest possible method, a future improvement is to use the deref (IPA/DS/OpenLDAP) or the ASQ (AD) controls to reduce the number of LDAP searches. Patches 0001 though 0004 are dependencies for 0005 0001: add way to get a

Re: [SSSD] [PATCH] Simplify debug_fn()

2009-11-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/2009 02:11 PM, Sumit Bose wrote: Please remove 'ret', too. Otherwise it is working well: ACK bye, Sumit Fixed and pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in