Re: [SSSD] [PATCHES] Convert the SSSD to config_file_version 2

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nack. See below On 09/25/2009 06:01 AM, Jakub Hrozek wrote: On 09/25/2009 10:48 AM, Sumit Bose wrote: Hi, here are my comments: On Thu, Sep 24, 2009 at 09:32:27PM -0400, Stephen Gallagher wrote: Patch 0001 (sgallagh): Convert the existing

Re: [SSSD] [PATCH] add new config options ldap_tls_cacert and ldap_tls_cacertdir

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 06:16 AM, Sumit Bose wrote: Hi, this patch adds the config option ldap_tls_cacert and ldap_tls_cacertdir to specify the location of CA certificates. If they are not used in sssd.conf the system defaults as defined in

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/24/2009 02:07 PM, Sumit Bose wrote: Hi, is it possible to open the debug file earlier in server_setup to catch all messages from server_setup? bye, Sumit As discussed on IRC, we cannot open the debug file until we initialize the confdb

Re: [SSSD] [PATCH] Temporarily disable automatic config file reread

2009-09-25 Thread Simo Sorce
On Thu, 2009-09-24 at 09:09 -0400, Stephen Gallagher wrote: The backends do not honor the reloadConfig SBUS message right now, so if an admin changes the sssd.conf file, it will update only the monitor, potentially leaving the SSSD as a whole in a bad state. This patch will simply comment

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Simo Sorce
On Fri, 2009-09-25 at 12:35 +0200, Jakub Hrozek wrote: /* set up things like debug , signals, daemonization, etc... */ +debug_log_file = talloc_strdup(NULL, sssd_pam); +if (debug_log_file == NULL) return 2; + debug_log_file is a process constant, it's useless to allocate memory

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 06:35 AM, Jakub Hrozek wrote: On 09/24/2009 02:07 PM, Sumit Bose wrote: Hi, is it possible to open the debug file earlier in server_setup to catch all messages from server_setup? bye, Sumit As discussed on IRC, we cannot

Re: [SSSD] [PATCHES] Convert the SSSD to config_file_version 2

2009-09-25 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 12:22 PM, Stephen Gallagher wrote: Actually, I would prefer that we use this tool for potential future upgrades (that I hope never to have...). It would be better for it to detect which version is currently in place and upgrade it

Re: [SSSD] [PATCH] extend sssd-krb5 man page

2009-09-25 Thread Jenny Galipeau
Sumit Bose wrote: Hi, this patch to the sssd-krb5 man page should clarify how the krb5 provider will find the right UPN. This hopefully fixes #204. Please fell free to correct any grammar or spelling mistakes. bye, Sumit

Re: [SSSD] [PATCH] extend sssd-krb5 man page

2009-09-25 Thread Simo Sorce
On Fri, 2009-09-25 at 15:09 +0200, Sumit Bose wrote: Hi, this patch to the sssd-krb5 man page should clarify how the krb5 provider will find the right UPN. This hopefully fixes #204. Please fell free to correct any grammar or spelling mistakes. Ack but I think some native english

Re: [SSSD] [PATCH] Send debug messages to logfile

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 09:48 AM, Jakub Hrozek wrote: On 09/25/2009 03:28 PM, Stephen Gallagher wrote: Nack /var/log/audit != /var/log/sssd Stupid copy'n'paste..sorry.. new patch attached Ack and pushed -

[SSSD] [PATCH] Convert the example config to v2 format, upgrade config on update only

2009-09-25 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Convert the example config to v2 format, upgrade config on update only Also, instead of having an LDAP proxy domain as an example, show a native LDAP config. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with

[SSSD] [PATCH] leave space to run fd events on long operations

2009-09-25 Thread Simo Sorce
This is actually a workaround as we don't have a way to create a low prio tevent queue that fires at a priority lower than file events. I'll work with upstream to fix this later on, meanwhile this patch will do. FYI: I haven't used timed_timeval_add() because it is buggy wrt microseconds in

[SSSD] [PATCH] add defines for large file support to standard CFLAGS

2009-09-25 Thread Sumit Bose
Hi, this patch fixes a compiler warning about the redefinition of SIZEOF_OFF_T on 32bit systems. It's not very elegant, but I don't know of a portable way to check if python was compiles with large file support. If anyone knows, please enlighten me. It might be possible the this patch leads to

Re: [SSSD] [PATCH] Convert the example config to v2 format, upgrade config on update only

2009-09-25 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 05:12 PM, Stephen Gallagher wrote: Nack The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched. I know there is a check in the script but

[SSSD] [PATCH] remove krb5_try_simple_upn option and make it a default fallback [was: [PATCH] extend sssd-krb5 man page]

2009-09-25 Thread Sumit Bose
On Fri, Sep 25, 2009 at 09:40:49AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 09:09 AM, Sumit Bose wrote: Hi, this patch to the sssd-krb5 man page should clarify how the krb5 provider will find the right UPN. This hopefully fixes

Re: [SSSD] [PATCH] Convert the example config to v2 format, upgrade config on update only

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 11:31 AM, Jakub Hrozek wrote: On 09/25/2009 05:12 PM, Stephen Gallagher wrote: Nack The changes to sssd.spec.in are unnecessary. The upgrade_config.py already does an internal check and bails out if the version is already matched.

Re: [SSSD] [PATCH] add defines for large file support to standard CFLAGS

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 11:23 AM, Sumit Bose wrote: Hi, this patch fixes a compiler warning about the redefinition of SIZEOF_OFF_T on 32bit systems. It's not very elegant, but I don't know of a portable way to check if python was compiles with large file

Re: [SSSD] [PATCH] leave space to run fd events on long operations

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 11:22 AM, Simo Sorce wrote: This is actually a workaround as we don't have a way to create a low prio tevent queue that fires at a priority lower than file events. I'll work with upstream to fix this later on, meanwhile this patch

Re: [SSSD] [PATCH] add defines for large file support to standard CFLAGS

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 12:23 PM, Stephen Gallagher wrote: On 09/25/2009 11:23 AM, Sumit Bose wrote: Hi, this patch fixes a compiler warning about the redefinition of SIZEOF_OFF_T on 32bit systems. It's not very elegant, but I don't know of a portable

Re: [SSSD] [PATCH] remove krb5_try_simple_upn option and make it a default fallback [was: [PATCH] extend sssd-krb5 man page]

2009-09-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 12:13 PM, Stephen Gallagher wrote: On 09/25/2009 11:40 AM, Sumit Bose wrote: On Fri, Sep 25, 2009 at 09:40:49AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/25/2009 09:09 AM, Sumit Bose wrote: