URL: https://github.com/SSSD/sssd/pull/730
Title: #730: confdb: sssd tools don't handle the implicit domain
alexey-tikhonov commented:
"""
Looks good.
The only remark I have: may be it would make sense to mark
`confdb_ensure_files_domain()` as `static` since it is not supp
URL: https://github.com/SSSD/sssd/pull/734
Author: alexey-tikhonov
Title: #734: sss_client: minor fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/734/head:pr734
git checkout pr734
From
URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
alexey-tikhonov commented:
"""
Re-pushed last patch: amended broken indentation
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/733
Author: alexey-tikhonov
Title: #733: providers/ldap: abort unsecure authentication requests
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/733/head:pr733
git checkout pr733
URL: https://github.com/SSSD/sssd/pull/733
Title: #733: providers/ldap: abort unsecure authentication requests
alexey-tikhonov commented:
"""
Re-pushed as a set of patches.
Also [added missed
`return`](https://github.com/SSSD/sssd/pull/733/commits/61e80b2d5e2c29328851479892
URL: https://github.com/SSSD/sssd/pull/734
Title: #734: sss_client: minor fixes
alexey-tikhonov commented:
"""
> each change, however cosmetic, _especially_ in the client code should be in
> its separate patch.
Re-pushed
"""
See the full comment at
h
URL: https://github.com/SSSD/sssd/pull/734
Author: alexey-tikhonov
Title: #734: sss_client: minor fixes
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/734/head:pr734
git checkout pr734
From
URL: https://github.com/SSSD/sssd/pull/734
Author: alexey-tikhonov
Title: #734: sss_client: minor fixes
Action: opened
PR body:
"""
A set of mostly cosmetic fixes with one notable exception:
fix of "mutex unlock without previous lock" bug in a couple of
nss_servic
URL: https://github.com/SSSD/sssd/pull/733
Author: alexey-tikhonov
Title: #733: providers/ldap: abort unsecure authentication requests
Action: opened
PR body:
"""
Abort LDAP authentication if the connection is not authenticated and
SDAP_DISABLE_AUTH_TLS is off.
Resolves: ht
URL: https://github.com/SSSD/sssd/pull/720
Title: #720: contrib/ci/deps.sh: added missing dependency
alexey-tikhonov commented:
"""
Thanks for explanations!
Does it mean that if test_pam_responder.py will be fixed properly then
libnss3-dev is not needed as well in Debian
URL: https://github.com/SSSD/sssd/pull/720
Author: alexey-tikhonov
Title: #720: contrib/ci/deps.sh: added missing dependency
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/720/head:pr720
git checkout pr720
URL: https://github.com/SSSD/sssd/pull/720
Title: #720: contrib/ci/deps.sh: added missing dependency
alexey-tikhonov commented:
"""
Created new issue https://pagure.io/SSSD/sssd/issue/3914
Closing this PR.
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/720
Title: #720: contrib/ci/deps.sh: added missing dependency
alexey-tikhonov commented:
"""
> Adding it as a dependency is ok, however if it is possible with pytest to run
> the related fixtures only for the NSS build this would be
URL: https://github.com/SSSD/sssd/pull/710
Author: alexey-tikhonov
Title: #710: data_provider_fo: fix error in hostname retrieval
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/710/head:pr710
git checkout pr710
From
URL: https://github.com/SSSD/sssd/pull/710
Author: alexey-tikhonov
Title: #710: data_provider_fo: fix error in hostname retrieval
Action: opened
PR body:
"""
Fixed off-by-one error in gethostname() param
Resolves:
https://pagure.io/SSSD/sssd/issue/3865
"""
To
URL: https://github.com/SSSD/sssd/pull/727
Author: alexey-tikhonov
Title: #727: COMPONENT: config validator rules & test
Action: opened
PR body:
"""
Add support of 'certmap' config section to validator rules
Resolves:
https://pagure.io/SSSD/sssd/issue/3845
""&q
URL: https://github.com/SSSD/sssd/pull/724
Title: #724: COMPONENT: util/tev_curl
alexey-tikhonov commented:
"""
> Could you please explain the double-free in more detail?
> Looking at tevent docs, they say that the tevent timer is freed automatically
That's correct.
>
URL: https://github.com/SSSD/sssd/pull/724
Title: #724: COMPONENT: util/tev_curl
alexey-tikhonov commented:
"""
> Could you please explain the double-free in more detail?
> Looking at tevent docs, they say that the tevent timer is freed automatically
That's correct.
>
URL: https://github.com/SSSD/sssd/pull/724
Author: alexey-tikhonov
Title: #724: COMPONENT: util/tev_curl
Action: opened
PR body:
"""
Fixes double free error in schedule_fd_processing()
(prevents deletion of already executed timer)
Resolves:
https://pagure.io/SSSD/sssd/issue/39
URL: https://github.com/SSSD/sssd/pull/732
Author: alexey-tikhonov
Title: #732: Issue 3841
Action: opened
PR body:
"""
sss_client/common.c: fix Coverity issue
Usage of strncpy(nssaddr.sun_path, socket_name, sizeof(nssaddr.sun_path))
1) confuses Coverity due to 3rd argum
URL: https://github.com/SSSD/sssd/pull/732
Author: alexey-tikhonov
Title: #732: sss_client/common.c: fix Coverity issue (issue 3841)
Action: edited
Changed field: title
Original value:
"""
Issue 3841
"""
___
sssd-de
URL: https://github.com/SSSD/sssd/pull/720
Author: alexey-tikhonov
Title: #720: contrib/ci/deps.sh: added missing dependency
Action: opened
PR body:
"""
Added libnss3-tools to list of debian dependencies:
certutil from this package is required by test_pam_responder.py.
&quo
URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch
alexey-tikhonov commented:
"""
> I have no idea why `test_ipa_subdom_server` fails with `99`:
> https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-796/2/fedora28/test-suite.log
99 mea
URL: https://github.com/SSSD/sssd/pull/796
Title: #796: ci: enable sssd-ci for 1-16 branch
alexey-tikhonov commented:
"""
> I have no idea why `test_ipa_subdom_server` fails with `99`:
> https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-796/2/fedora28/test-suite.log
99
URL: https://github.com/SSSD/sssd/pull/795
Title: #795: Issue 3964 (sssd-1-16 backport)
alexey-tikhonov commented:
"""
Amended PR to address regression in the test.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/797
Author: alexey-tikhonov
Title: #797: TESTS: fixed regression in cmocka/test_negcache_2.c
Action: opened
PR body:
"""
Fixed regression in test introduced in 2b564f8 (PR 786)
Test was relying on hardcoded values of non local users a
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: Issue 3964 (sssd-1-16 backport)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/795/head:pr795
git checkout pr795
From
URL: https://github.com/SSSD/sssd/pull/800
Author: alexey-tikhonov
Title: #800: data_provider_be: got rid of went_offline usage
Action: opened
PR body:
"""
Got rid of unused anymore `went_offline` variable
Resolves: https://pagure.io/SSSD/sssd/issue/3991
"""
URL: https://github.com/SSSD/sssd/pull/802
Author: alexey-tikhonov
Title: #802: TESTS: two `negcache` tests were merged
Action: opened
PR body:
"""
Resolves: https://pagure.io/SSSD/sssd/issue/3989
"""
To pull the PR as Git branch:
git remote add ghsssd https://
URL: https://github.com/SSSD/sssd/pull/801
Author: alexey-tikhonov
Title: #801: data_provider_be: fixed dereferencing of 'bad' ptr
Action: opened
PR body:
"""
In case of failed `dp_req_recv_ptr()` in `be_check_online_done()`
function, `reply` ptr was not initialized and it
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
> f26 is stuck on step next after "make-check-valgrind", so I will re-run it
JFYI, this time it passed.
"""
See the fu
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
> f26 is stuck on step next after "make-check-valgrind", so I will re-run it
JFYI, this time it passed successfully.
"&
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
Btw, this PR passes covscan and CI checks: internal (job number 9832; f26 is
stuck on step next after "
make-check-valgrind", so I wi
URL: https://github.com/SSSD/sssd/pull/786
Title: #786: Issue 3964
alexey-tikhonov commented:
"""
Thank you for review. I think I addressed all the comments.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/786
Title: #786: Issue 3964
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of
URL: https://github.com/SSSD/sssd/pull/786
Author: alexey-tikhonov
Title: #786: Issue 3964
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/786/head:pr786
git checkout pr786
From
URL: https://github.com/SSSD/sssd/pull/786
Author: alexey-tikhonov
Title: #786: Issue 3964
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/786/head:pr786
git checkout pr786
From
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
Well, all my comments were addressed somehow, so code-wise ack from my side.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
Well, all my comments were addressed somehow, so code-wise ack from my side.
Covscan passed.
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
> > btw reading the code, I don't understand why do we allow more than one
> > check_online request, do you understand the reason f
URL: https://github.com/SSSD/sssd/pull/788
Title: #788: Speed up check_ccache_files with large cache
alexey-tikhonov commented:
"""
> About the indexing patch, you can:
Thank you. All steps are verified.
Awaiting results of CI and covscan.
"""
See the full co
URL: https://github.com/SSSD/sssd/pull/788
Title: #788: Speed up check_ccache_files with large cache
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/788
Title: #788: Speed up check_ccache_files with large cache
alexey-tikhonov commented:
"""
> Awaiting results of CI and covscan.
Completed successfully. Ack.
"""
See the full comment at
https://github.com/SSSD/sss
URL: https://github.com/SSSD/sssd/pull/783
Title: #783: knownhostsproxy: friendly error msg for NXDOMAIN
alexey-tikhonov commented:
"""
OK to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/783#issuecomment-476186410
__
URL: https://github.com/SSSD/sssd/pull/783
Title: #783: knownhostsproxy: friendly error msg for NXDOMAIN
alexey-tikhonov commented:
"""
Looks fine.
But I wonder if it would be safer to use `sss_atomic_write_s(STDERR_FILENO,
...)` instead of `fprintf`
"""
URL: https://github.com/SSSD/sssd/pull/800
Author: alexey-tikhonov
Title: #800: data_provider_be: got rid of went_offline usage
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/800/head:pr800
git checkout pr800
From
URL: https://github.com/SSSD/sssd/pull/800
Title: #800: data_provider_be: got rid of went_offline usage
alexey-tikhonov commented:
"""
I agree. Patch is amended (and rebased).
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/797
Title: #797: TESTS: fixed regression in cmocka/test_negcache_2.c
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: Issue 3964 (sssd-1-16 backport)
Action: opened
PR body:
"""
Set of patches to resolve / related to https://pagure.io/SSSD/sssd/issue/3964
(sssd-1-16 backport)
"""
To pull the PR
URL: https://github.com/SSSD/sssd/pull/786
Title: #786: Issue 3964
alexey-tikhonov commented:
"""
> Can you please open a separate sssd-1-16 PR?
https://github.com/SSSD/sssd/pull/795
"""
See the full comment at
https://github.com/SSSD/sss
URL: https://github.com/SSSD/sssd/pull/785
Title: #785: Providers: Delay online check on startup
alexey-tikhonov commented:
"""
Internal CI run OK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/785#issuecomment-477497520
__
URL: https://github.com/SSSD/sssd/pull/794
Title: #794: Providers: Delay online check on startup (sssd-1-16 backport)
alexey-tikhonov commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/794
Title: #794: Providers: Delay online check on startup (sssd-1-16 backport)
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/797
Author: alexey-tikhonov
Title: #797: WIP: TESTS: fixed regression in cmocka/test_negcache_2.c
Action: edited
Changed field: title
Original value:
"""
TESTS: fixed regression in cmocka/te
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: WIP: Issue 3964 (sssd-1-16 backport)
Action: edited
Changed field: title
Original value:
"""
Issue 3964 (sssd-1-16 backport)
"""
___
s
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: WIP: Issue 3964 (sssd-1-16 backport)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/795/head:pr795
git checkout pr795
From
URL: https://github.com/SSSD/sssd/pull/797
Author: alexey-tikhonov
Title: #797: WIP: TESTS: fixed regression in cmocka/test_negcache_2.c
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/797/head:pr797
git checkout
URL: https://github.com/SSSD/sssd/pull/797
Author: alexey-tikhonov
Title: #797: WIP: TESTS: fixed regression in cmocka/test_negcache_2.c
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/797/head:pr797
git checkout
URL: https://github.com/SSSD/sssd/pull/798
Title: #798: ipa: ipa_getkeytab don't call libnss_sss
alexey-tikhonov commented:
"""
From my point of view, this is very neat solution for the
https://pagure.io/SSSD/sssd/issue/3972
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: WIP: Issue 3964 (sssd-1-16 backport)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/795/head:pr795
git checkout pr795
From
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: WIP: Issue 3964 (sssd-1-16 backport)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/795/head:pr795
git checkout pr795
From
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: WIP: Issue 3964 (sssd-1-16 backport)
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/795/head:pr795
git checkout pr795
From
URL: https://github.com/SSSD/sssd/pull/795
Author: alexey-tikhonov
Title: #795: Issue 3964 (sssd-1-16 backport)
Action: edited
Changed field: title
Original value:
"""
WIP: Issue 3964 (sssd-1-16 backport)
"""
___
s
URL: https://github.com/SSSD/sssd/pull/797
Author: alexey-tikhonov
Title: #797: TESTS: fixed regression in cmocka/test_negcache_2.c
Action: edited
Changed field: title
Original value:
"""
WIP: TESTS: fixed regression in cmocka/te
URL: https://github.com/SSSD/sssd/pull/803
Author: alexey-tikhonov
Title: #803: TESTS: ability to run unit tests under valgrind
Action: opened
PR body:
"""
Adds ability to run unit tests under valgrind with handy makefile
targets. Enabled with --enable-valgrind passed to ./c
URL: https://github.com/SSSD/sssd/pull/752
Title: #752: sbus: terminated active ongoing request when reconnecting
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/752
Title: #752: sbus: terminated active ongoing request when reconnecting
alexey-tikhonov commented:
"""
LGTM.
Passes covscan and internal CI: {debian, f28, f29, rawhide, rhel7}
ACK
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/752
Title: #752: sbus: terminated active ongoing request when reconnecting
alexey-tikhonov commented:
"""
I only wonder what was the reason to move definition of `struct
sbus_active_requests` to header.
But this really doesn't hurt a
URL: https://github.com/SSSD/sssd/pull/759
Title: #759: CONFIG: add missing ldap attributes for validation
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/759
Title: #759: CONFIG: add missing ldap attributes for validation
alexey-tikhonov commented:
"""
LGTM. Passes covscan and internal CI.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/768
Author: alexey-tikhonov
Title: #768: providers/ipa: Changed default service search base
Action: opened
PR body:
"""
Changed default value of `ldap_service_search_base` config option
to `cn=ipservices,cn=accounts,$BASE` to follow
URL: https://github.com/SSSD/sssd/pull/752
Title: #752: sbus: terminated active ongoing request when reconnecting
alexey-tikhonov commented:
"""
> So I can access it in `sbus_dispatch_reconnect`.
Oh, right, thank you for clarifying.
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/779
Author: alexey-tikhonov
Title: #779: negcache: avoid "is_*_local" calls in some cases
Action: opened
PR body:
"""
"use_local_negative" argument of `sss_ncache_set_str()` function
only makes sense in case of non
URL: https://github.com/SSSD/sssd/pull/771
Author: alexey-tikhonov
Title: #771: Monitor: changed provider startup timeout
Action: opened
PR body:
"""
`monitor_service_init()` allows 10 secs for any connected sbus client
to proceed with registration.
It makes sense to allow o
> What I'm proposing is:
> - you submit PR for master
> - I review it and push to master, close the original PR
> - I also apply the patches locally to sssd-1-16 and open another PR
> - if the backport PR passes CI, I also push it
... or author of PR can simply open both PRs at
URL: https://github.com/SSSD/sssd/pull/774
Author: alexey-tikhonov
Title: #774: ci/sssd.supp: fixed c-ares-suppress-leak-from-init
Action: opened
PR body:
"""
Valgrind suppression pattern was adjusted to prevent
fails on some target OS.
"""
To pull the PR as Git
+1 for separate PRs for backports (for CI checks)
On Fri, Mar 15, 2019 at 12:15 PM Jakub Hrozek wrote:
>
> Hi,
>
> I was thinking about $SUBJECT and had a chat with Alexey about backports
> recently as well.
>
> Mostly I'm wondering whether it would be better to do either or both of:
> -
URL: https://github.com/SSSD/sssd/pull/786
Author: alexey-tikhonov
Title: #786: Issue 3964
Action: opened
PR body:
"""
Set of patches to resolve / related to https://pagure.io/SSSD/sssd/issue/3964
"""
To pull the PR as Git branch:
git remote add ghsssd https://
URL: https://github.com/SSSD/sssd/pull/754
Title: #754: Util: fixed mistype in error string representation
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/750
Title: #750: Monitor: minor fixes
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/750#issuecomment-463188853
_
URL: https://github.com/SSSD/sssd/pull/750
Author: alexey-tikhonov
Title: #750: Monitor: minor fixes
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/750/head
URL: https://github.com/SSSD/sssd/pull/751
Author: alexey-tikhonov
Title: #751: TESTS: fixed bug in guests startup function
Action: opened
PR body:
"""
`start-guest()` function always started `client` machine ignoring supplied
argument.
"""
To pull the PR
URL: https://github.com/SSSD/sssd/pull/754
Author: alexey-tikhonov
Title: #754: Util: fixed mistype in error string representation
Action: opened
PR body:
"""
Resolves: https://pagure.io/SSSD/sssd/issue/3916
"""
To pull the PR as Git branch:
git remote add ghsss
URL: https://github.com/SSSD/sssd/pull/745
Author: alexey-tikhonov
Title: #745: providers/ldap: minor fixes
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/745/head
URL: https://github.com/SSSD/sssd/pull/737
Author: alexey-tikhonov
Title: #737: providers/proxy: fixed issue 3931
Action: opened
PR body:
"""
Set of patches related with https://pagure.io/SSSD/sssd/issue/3931
"""
To pull the PR as Git branch:
git remote add
URL: https://github.com/SSSD/sssd/pull/740
Title: #740: sbus: avoid using invalid stack point in SBUS_INTERFACE
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/740
Title: #740: sbus: avoid using invalid stack point in SBUS_INTERFACE
alexey-tikhonov commented:
"""
> *) there is an error in implementations of
> `sbus_method_copy/sbus_signal_copy/sbus_property_copy`:
> ```
> memcpy
URL: https://github.com/SSSD/sssd/pull/740
Title: #740: sbus: avoid using invalid stack point in SBUS_INTERFACE
alexey-tikhonov commented:
"""
> * Consider following snippet:
> ```
> struct sbus_interface dbus;
> {
> /* ... some code ... *
URL: https://github.com/SSSD/sssd/pull/741
Author: alexey-tikhonov
Title: #741: sbus/interface: fixed interface copy helpers
Action: opened
PR body:
"""
In `sbus_method_copy()` and other copy helpers there was code like:
```
copy = talloc_zero_array(mem_ctx, struct sbus_me
URL: https://github.com/SSSD/sssd/pull/743
Author: alexey-tikhonov
Title: #743: lib/cifs_idmap_sss: fixed unaligned mem access
Action: opened
PR body:
"""
Fixed following warning:
```
lib/cifs_idmap_sss/cifs_idmap_sss.c: In function ‘sss_sid_to_id’:
lib/cifs_idmap_sss/cifs_idm
URL: https://github.com/SSSD/sssd/pull/803
Title: #803: TESTS: ability to run unit tests under valgrind
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/p
> > +1 for separate PRs for backports (for CI checks)
> Do you think it would be acceptable for whoever pushes the patch to
> master to also create the backport PR?
It depends on who decides if patch should be backported at all.
If PR author is pretty sure patch needs to be backported, then why
URL: https://github.com/SSSD/sssd/pull/730
Title: #730: confdb: sssd tools don't handle the implicit domain
alexey-tikhonov commented:
"""
> @alexey-tikhonov, ping, would you like to continue the review or shall I?
At that moment I was not sure I could ACK the patch, so
URL: https://github.com/SSSD/sssd/pull/826
Title: #826: util/crypto/libcrypto: changed sss_hmac_sha1()
alexey-tikhonov commented:
"""
> @jhrozek do you know if the PR CI uses libcrypto or nss?
If I get things right,
`contrib/ci/configure.sh`:
```
if [[ "$DISTRO_BRANC
URL: https://github.com/SSSD/sssd/pull/826
Author: alexey-tikhonov
Title: #826: util/crypto/libcrypto: changed sss_hmac_sha1()
Action: opened
PR body:
"""
Changed libcrypto/sss_hmac_sha1 implementation to be FIPS140 compliant.
Resolves: https://pagure.io/SSSD/sssd/issue/40
URL: https://github.com/SSSD/sssd/pull/835
Title: #835: LDAP: failover does not work on non-responsive ldaps
alexey-tikhonov commented:
"""
Now patch LGTM. But I didn't test it manually.
"""
See the full comment at
https://github.com/SSSD/sssd/p
URL: https://github.com/SSSD/sssd/pull/838
Author: alexey-tikhonov
Title: #838: FIPS140 compliant usage of PRNG
Action: opened
PR body:
"""
Resolves https://pagure.io/SSSD/sssd/issue/4024
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.
URL: https://github.com/SSSD/sssd/pull/827
Author: alexey-tikhonov
Title: #827: ldap/sdap_idmap.c: removed unnecessary include
Action: edited
Changed field: body
Original value:
"""
"""
___
sssd-de
URL: https://github.com/SSSD/sssd/pull/827
Author: alexey-tikhonov
Title: #827: ldap/sdap_idmap.c: removed unnecessary include
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pu
URL: https://github.com/SSSD/sssd/pull/833
Title: #833: util/crypto/libcrypto: changed sss_hmac_sha1()
alexey-tikhonov commented:
"""
@jhrozek, could you please check if this works on your F-28 based VM now?
It was ok on internal CI F-27 with enforced OpenSSL.
"&quo
1 - 100 of 2072 matches
Mail list logo
