The Validator was designed to work this way so there
could different groupings of validation rules.
Because some times it may not make sense to continue
with certain validations until the form is in a
certain state. The depends attribute in the pluggable
validator definitions is what controls
1.1 release. I'll think if
there are any other ways to do this and keep it
backwards compatible.
David
--- James Turner [EMAIL PROTECTED] wrote:
At 03:57 PM 7/15/2002, David Winterfeldt wrote:
The Validator was designed to work this way so
there
could different groupings of validation rules
--- Ted Husted [EMAIL PROTECTED] wrote:
I added the documentation/comments for the new
validator DTDs, but have
a question:
Do we really want two DTDs?
Orginally, there was just one configuration file,
but we saw it would be
convenient to have a master rules file and one or
more
on the same property. Internally the name is
being set to the
same as the rest of the tags, is this simply being
ignored to go fetch
the messages on a standard name?...
Arron.
On Fri, 2002-06-21 at 05:45, David Winterfeldt
wrote:
I'm not 100% I'm sure I'm following what the
problem
I'm not 100% I'm sure I'm following what the problem
is (probably missed some other e-mails). I was going
to talk to you Aaron when I went to do these, but it
seemed very simple so I went ahead and made them. I
just wanted the nested messages and errors tags to be
able to get the property name
The latest nightly builds let you get a Map of any
objects (except booleans) returned from a validation
method. The latest configuration of the Validator xml
rules (conf/share/validator-rules.xml) calls some
methods that return the correctly typed object
(primitives, date, and credit card). So
This has not been changed. Some features have been
added, but I was trying not to make any major changes
since there needs to be a Commons Validator release to
correspond with a Struts 1.1 release.
David
--- Dave J Dandeneau [EMAIL PROTECTED] wrote:
I noticed that the validator (pre 1.1)
--- Jing Zhou [EMAIL PROTECTED] wrote:
I am trying to normalize hundreds of screen objects
in
a struts related tool, so when the validator page
number
came into the picture, I feel I am not fully
understand its
implications from the perspective of business
scenarios.
Basically I
The page attriubte for a field element is optional.
David
--- Jing Zhou [EMAIL PROTECTED] wrote:
When looking into the validator codes, the page no.
of a wizard
like application is needed for validator to work. It
looks to me
that the validator will validate the current page
plus all
The Struts Validator was recently moved (right before
beta 1) from contrib/validator to the main source
tree. I don't know why the build isn't working for
you. Those classes are in cvs. Maybe your checkout
failed? The ValidatorPlugIn is in the
org.apache.struts.validator package (along with
for this
situation...
--
Martin Cooper
- Original Message -
From: David Winterfeldt [EMAIL PROTECTED]
To: Struts Developers List
[EMAIL PROTECTED]
Sent: Saturday, March 30, 2002 6:08 PM
Subject: Re: PlugIn (Craig)
I just wanted to know if this change was on
purpose.
I
to choose. It
would be confusing to
the user, and also to us when trying to track down
problems and subtle
differences in behaviour.
--
Martin Cooper
- Original Message -
From: David Winterfeldt [EMAIL PROTECTED]
To: Struts Developers List
[EMAIL PROTECTED]
Sent: Friday, March 22
It looks like when you made changes to the PlugIn
Craig that it broke the ValidatorPlugIn. Having
multiple set-property elements under the plug-in used
to work, but now it looks like only the last one is
being kept. It looks like the addition of
PlugInSetPropertyRule in ConfigRuleSet broke
at least on the xml
side.
David
--- Craig R. McClanahan [EMAIL PROTECTED] wrote:
On Sat, 30 Mar 2002, David Winterfeldt wrote:
Date: Sat, 30 Mar 2002 11:44:43 -0800 (PST)
From: David Winterfeldt [EMAIL PROTECTED]
Reply-To: Struts Developers List
[EMAIL PROTECTED]
To: Struts Developers
On this same note, I forgot to copy the Jakarta Regexp
jar to the dist/lib directory and into the validator
example webapp. I'll file bugs for things like this
and fix them.
David
--- Couball, James [EMAIL PROTECTED]
wrote:
I think the gump build failed because the
jakarta-struts.xml project
Email Validation doesn't allow '-' in address. This
is an error in the Jakarta Regexp package. It also
has trouble with large max values.
ex: ^\d{2,1000}$
Does anyone think we should just switch to ORO? I'm
leaning that way, but I used Jakarta Regexp because it
was considered 'lighter'.
The Struts Validator has been moved from
contrib/validator to the Struts core. Also the last
references to Struts related code from the Commons
Validator has been removed. So to get this error you
are probably using a newer Commons Validator with an
old Struts Validator version. The new config
+1
But could we wait until at least tonight or tomorrow
to retag and lock down. If that is OK with everyone.
I have the Validator example webapp incorporated into
Struts, but I need to add a couple of things to it.
Although I could check it in as is depending on how
soon you want to get the
There are comments in the build.properties.sample file
indicating which version of any jars to use. If we
are out of sync at all, this is an easy place to
update. And the binary download of Struts has these
jars in the lib directory which were used when
compiling the Struts binary.
David
---
v1.3 of
src/share/org/apache/struts/taglib/nested/html/NestedFormTag.java
won't compile for me.
[javac] symbol : method doAfterBody ()
[javac] location: class
org.apache.struts.taglib.html.FormTag
[javac] int temp = super.doAfterBody();
Anyone else having this problem?
David
. The NestedIterate does the
same thing with its
super.doAfterBody() method use also, it's a
surprise that it would only
fail on this one.
Arron.
David Winterfeldt wrote:
v1.3 of
src/share/org/apache/struts/taglib/nested/html/NestedFormTag.java
won't compile for me.
[javac] symbol
I have all the main code I wanted to do checked in
except for documentation, but you said that was ok to
get in later Martin. I'll file bugs for any other
things I know that are issues. So you can tag
whenever Craig says it is ok. I changed on thing in
the Commons Validator tonight in case you
I'm going to check this in later tonight if there are
no objections to the packages I've placed things
under. I'll add the webapp example and documentation
next. The Jakarta Regexp jar will need to get added
to the properties file for the nightly builds.
added to org.apache.struts.action
of
org.apache.struts.action for the
five main classes.
I will update the nightly builds to include
jakarta-regexp (which we'll
also need to ship in the lib directory), and tell
Gump about it as well,
once I see the check-ins.
Craig
On Sun, 17 Mar 2002, David Winterfeldt wrote:
Date: Sun, 17
I closed out bug 6685 last night.
David
--- Craig R. McClanahan [EMAIL PROTECTED] wrote:
FYI, I have cleaned up all the outstanding bug
reports for Commons
components that the HEAD branch of Struts relies on
except for:
3893 - Digester - Enhancement to handling for
body text that
Vote: Struts 1.1b1 Release Plan
[x] +1 I am in favor of the release, and will help
support it
[ ] +0 I am in favor of the release, but am unable
to help support it
[ ] -0 I am not in favor of the release
[ ] -1 I am against this proposal (must include a
reason).
Your property isn't really 'blah'. It is 'blah[0]',
'blah[1]', etc. So if you use the full property for a
field for the ActionErrors key, then you can retrieve
it next to each field.
ActionErrors errors = new ActionErrors();
errors.add(blah[0], new ActionError(error.msg));
html:error
Log4J recently added some new classes. I would check
that you have a version of Log4J and Commons Logging
from the same time. I had some trouble too until I
went and downloaded the latest version of each.
David
--- Chris Hane [EMAIL PROTECTED] wrote:
I'm trying to get a Struts 1.0
I wasn't sure if it was good to encourage someone
using another classes logger because it might make the
logs harder to read and control. So I didn't add
access for the logger. And you do still have access
to the servlet log.
I agree with Craig. I think it is good form to define
your own
I have no problems with moving what's left of the
Validator to src/share. My top goal right now is to
go over all the javadoc comments for the Commons
Validator and Struts Validator and work on
documentation. Then to apply any bug fixes that
people have sent me e-mails about that I haven't
I checked in what I've done so far. Commons Logging
issues.
1. Do we want to just add console logging to the
example web apps or log to a file? Are you still
running the nightly build Craig? Log4J would need to
be added to the properties file so it can be included
in the webapps for the
--- Craig R. McClanahan [EMAIL PROTECTED] wrote:
On Mon, 25 Feb 2002, David Winterfeldt wrote:
Date: Mon, 25 Feb 2002 19:49:05 -0800 (PST)
From: David Winterfeldt [EMAIL PROTECTED]
Reply-To: Struts Developers List
[EMAIL PROTECTED]
To: Struts Developers List
[EMAIL PROTECTED
I can help over the weekend with switching to Commons
Logging since I suggested it. Unless someone else
really wants to. :)
I assume most things will become LOG.debug unless they
are obviously referring to an error.
I see that the Digester class does the following.
I've been doing the latter
Is the Commons Validator jar in your WEB-INF/lib
directory? I need to get it setup in commons so it is
building with everything else, but I did leave a
binary of it in the lib directory of the download from
my site.
David
--- Ted Husted [EMAIL PROTECTED] wrote:
So, I'm trying to update an
I think it would be nice if the service manager was
moved to proper. I was going to use it and move away
from the ValidatorServlet, but I needed to use the
Tiles extension of ActionServlet so I left the
Validator loading alone. If the service manager was
built in, then this wouldn't have been
+1
David
--- Ted Husted [EMAIL PROTECTED] wrote:
Arron has developed an interesting and popular
extension to the Struts
taglibs. He has been distributing the extension in a
very complete and
accessible package, and has offered to donate it to
Struts. Arron has
also been helping out on
I just wanted to comment that I did look at it a
little, run the examples, and look at the source. It
seems nice, clean, and easy to use. I haven't used it
in a project yet though.
David
--- Ted Husted [EMAIL PROTECTED] wrote:
Arron,
Once Craig's implementation of the multi-servlet
I like literal out of the three listed. A static or
staticText field would be the only other ideas I have
for naming.
David
--- Oleg V Alexeev [EMAIL PROTECTED] wrote:
Hello Ted,
So, votes for naming of free style attribute for
html tags -
literal - 2
freetext - 1.5 (already extst)
Alan and I already talked offline, but I told him this
might be a good place to get other opinions. I think
that all validation errors are fatal. If it isn't
fatal it is really a message, so you could use
ActionMessages instead of ActionErrors. The
equivalents of all the error methods could be
I think Ted was just saying that the core of Struts
should remain small and that there can be lots of
add-ons and extensions for plug and play
functionality. It makes the core easier to manage and
then people can add in whatever functionality they
need by just dropping in a jar and/or tld. It
Ted,
I just wanted to mention that any of the resource
links to http://husted.com/about/struts are bad since
everything was moved to http://husted.com/struts, but
even if you take out the about from the url it still
does't go to the resource.
The validator:errors tag header and footer are
optional. So you can do something like this below.
ul
validator:errors id=error property=name
libean:write name=error//li
/validator:errors
/ul
or
validator:errorsExist property=name
bean:message
+1
Sounds like a good way to give more visibility to all
the bugs.
David
--- Ted Husted [EMAIL PROTECTED] wrote:
Originally, I think we did that just to leverage
bugilla's automatic
mail feature. Posting them to DEV and leaving them
unassigned would seem
to be a better fit with the
The string you pass into ActionError must be a key
from your message resource property file. Otherwise
the property for error messages is just a key to look
up messages and the convention is to make it match the
property name.
html:errors name=fooBean property=bar.foo[3].xyz
errors.add
://www.husted.com/about/struts/codemaker.htm
Struts Generator by David Winterfeldt - Based on the
generator.xml and a table/query an xml file is
generated. Based on the generated xml file a primary
key class, data bean class, jdbc class, and an
ActionForm (Struts) can be generated.
General link to other
The main link for the digester on the
jakarta.apache.org/struts is 404ing.
http://jakarta.apache.org/struts/api/org/apache/struts/digester/package-summary.html
David
__
Terrorist Attacks on U.S. - How can you help?
Donate cash, emergency relief
I want to add the ability to have validation for
people that are using 'indexed=true' on forms for
indexed properties. I'm thinking about this for the
validation.xml file. It would only handle a single
level of indexing. Does the 'indexed=true' handle
more than one level? I don't think it
Are you going directly to the JSP page or are you
going through an action? I suspect you are going
through an action and you have 'validate=true'.
This would cause the page to be validated before it
was actually submitted. So you could either go
directly to a JSP or have 'validate=false' and
Dumoulin [EMAIL PROTECTED] wrote:
I have checkout project on my local pc. I have do
checkout again in a
clean place, but error remain ;-(
What is strange is that module import has worked
without error.
Cedric
David Winterfeldt wrote:
Where do you have the project checked out
Please let me know,
Thanks,
Ravi
David Winterfeldt wrote:
I started on something simple that autogenerates
primary key class, data bean class, jdbc class,
and an
ActionForm based off an xml file that can be
generated
from a table in a database. I'm not sure it is
worth
the New Struts Codemaker code.
Modifications Made
1. Attached the header template with apache
information
2. Package name with org.apache.struts.codemaker
3. Modifications in the validation.xml generation
Please let me know,
Thanks,
Ravi
David Winterfeldt wrote:
I started
the RowSet. The Helper
is then inserted
into the context for access by the presentation
layer. The Helper gives
you a place to put special output methods for the
presentation layer (or
report layer, for that matter). Neither the Helper
nor the DAO are
linked to HTTP or a Web application.
David
What is the status of having something to load a
service in Struts? If it is going to be a while, I
would suggest at least adding something that could at
least handle initialization of resources that would
fit in with the future plans. I was waiting for
something like this before I added the
I thought this was going to be a core feature (or is
it not ready for the core yet, Oleg?).
David
--- Ted Husted [EMAIL PROTECTED] wrote:
I believe Oleg committed a package to contrib, and
is looking for help
with sample code, general testing and documentation.
David Winterfeldt wrote
+1
--- Craig R. McClanahan [EMAIL PROTECTED] wrote:
As I cc'd to this list, the 1.0 versions of the
beanutils, collections,
and digester packages have been released under the
Commons project. Now
that these are official 1.0 releases, I propose to
modify the Struts 1.1
environment to
I use the Digester in this class. It loads the
validation.xml in web/example/WEB-INF.
com.wintecinc.struts.validation.ValidatorResourcesInitializer
I have it posted here.
http://home.earthlink.net/~dwinterfeldt
David
--- Rey Francois [EMAIL PROTECTED] wrote:
Look at the mapper
where it belongs. All the logic tags are
very generic. Maybe it belongs in a taglib/validator
package. If you read this Craig, maybe you could
comment.
David
--- Ted Husted [EMAIL PROTECTED] wrote:
David Winterfeldt wrote:
This would work, but would it be confusing for a
general message tag
Maybe the token that can be generated in an action be
used or make a workflow token.
David
--- Robbin L. Gratz [EMAIL PROTECTED]
wrote:
With the return stack concept, I'm assuming this
will be a session scope
variable. What happens when the user clicks the
back button rather than
Sorry. I apologize. I got frustrated with the
problems I'm having and just wanted to get it checked
in. I've tried doing it on the server, with Cygwin,
and with WinCvs for a few days. I can't check
anything in on the server and if I commit more than a
few files Cygwin's cvs and WinCvs never
I still seem to be having some trouble, but I'll keep
trying. The other errors I was getting were from the
cvs checkout I did on the server in my home directory.
I'll try doing it again, but explicitly login to
cvs as Craig suggested in another e-mail. I managed
to get these files checked in
Thanks.
--- Craig R. McClanahan [EMAIL PROTECTED] wrote:
On Wed, 4 Jul 2001, David Winterfeldt wrote:
I started to check everything into a validator
directory under contrib. It looks like I
successfully
added directories, but I get this error when
checking
in a file. I checked
. Or the new
one could be html:errorsIterator.
David
David Winterfeldt wrote:
I started to check everything into a validator
directory under contrib. It looks like I
successfully
added directories, but I get this error when
checking
in a file. I checked in one of the documentation
xsl
--- Ted Husted [EMAIL PROTECTED] wrote:
Craig R. McClanahan wrote:
Following this philosophy, we'd create a new tag
(perhaps
html:messages?) for the new functionality, and
deprecate
html:errors. In addition, we'd need to change
the 1.1 implementation of
html:errors so that it did
This sounds good. I adding 'messages=true'. That
makes it easier to use than have to put in a long key
each time.
David
--- Ted Husted [EMAIL PROTECTED] wrote:
David Winterfeldt wrote:
This would work, but would it be confusing for a
general message tag to default to errors?
Originally
I have couple of issues with the best way to handle
the possible incorporation of the validator custom JSP
tags into Struts. I'll go through each of the issues.
I made two custom jsp tags for errors based off of the
Struts' tags. One was validator:errors which is the
equivalent of html:errors
[commit aborted]: correct above errors first!
The status shows it checked in locally, but not into
the main repository.
David
--- Ted Husted [EMAIL PROTECTED] wrote:
Sure, if that works for you. It's just that it might
be simplier to
update and maintain under CVS.
David Winterfeldt wrote:
Do
Oleg,
What is the status of your work on this?
David
--- Oleg V Alexeev [EMAIL PROTECTED] wrote:
Hello Ted,
Friday, June 29, 2001, 2:33:29 PM, you wrote:
TH If there is no other way ;-(
TH We just need to think about what happens if
someone wants to use the
TH Bean Factory and
When you are doing regular expressions you can
basically just cut and paste them from an example and
escape out the few XML sensitive characters, but you
have to escape out the escape characters in a java
properties file which I think makes something that is
already hard to read even more
Regular expressions should be:
^quot;\(?(\d{3})\)?[-| ]?(\d{3})[-| ]?(\d{4})$quot;
Properties file version
^\\\(?(\\d{3})\\)?[-| ]?(\\d{3})[-| ]?(\\d{4})\$
David
--- David Winterfeldt [EMAIL PROTECTED] wrote:
When you are doing regular expressions you can
basically just cut and paste them
offering a nice solution in order to preserve the
real look of a reg. exp.
in an XML file?
Fr.
-Original Message-
From: David Winterfeldt
[mailto:[EMAIL PROTECTED]]
Sent: 25 June 2001 18:11
To: [EMAIL PROTECTED]
Subject: RE: server-side, java-based validation
rules for struts
I'm intersted in seeing the code too. If my
validation framework does more, maybe we can make them
work in tandem.
I've actually been working on making the validation
framework work independant of Struts. A friend of
mine wants to be able to configure a different set of
rules just to run on
I haven't had time yet to reorganize the code to
separate out validations into pure boolean validation
methods. The interface that is there now wasn't the
original one and has evolved over time. When I have
free time, I've normally focused on adding
functionality over reorganizing the source
-Original Message-
From: David Winterfeldt
[mailto:[EMAIL PROTECTED]]
Sent: Thursday, June 21, 2001 11:17 AM
To: [EMAIL PROTECTED]
Subject: Re: server-side, java-based validation
rules for struts..
I haven't had time yet to reorganize the code to
separate out validations
I don't think there would be anything wrong with your
idea, but I think it is a little more flexible keeping
the validation separate from the ActionForm. I
started working on a validation framework, but I put
the info in an xml file. I would rather change a
value in an xml file than having to
have to do validations for a zillion
different permutations
of
possibilities
What do you think?
- Original Message -
From: David Winterfeldt
[EMAIL PROTECTED]
To: [EMAIL PROTECTED]; Jonathan
Asbell
[EMAIL PROTECTED]
Sent: Monday, June 18, 2001 11:01 PM
Subject
framework?
Fr.
-Original Message-
From: David Winterfeldt
[mailto:[EMAIL PROTECTED]]
Sent: 15 June 2001 14:31
To: [EMAIL PROTECTED]
Subject: RE: Client/Server Side Validation for
Struts 1.1
I just wanted to put this out there to see what
people
think since I took the time
.
- Original Message -
From: David Winterfeldt [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Monday, June 18, 2001 2:26 PM
Subject: RE: Client/Server Side Validation for
Struts 1.1
I've still been continuing work on the Struts
Validator
(http://home.earthlink.net/~dwinterfeldt
I think it is a matter of planning for the future.
Changing 10 pages of HTML may not be a big deal or
even a hundred, but as the site's documentation keeps
expanding it's easier to keep the documentation in XML
so Struts and other Jakarta projects can easily be
reformatted and released with a
the ActionForm, where the validate method calls
the mapper associated
with the form and produces an ActionError for each
validation/transformation
failure.
Fr.
-Original Message-
From: David Winterfeldt
[mailto:[EMAIL PROTECTED]]
Sent: 14 June 2001 06:32
To: [EMAIL PROTECTED
I just saw the type conversion thread going on in the
user list, but I've thought about this for a bit and
you mentioned possibly modeling or taking code from an
existing framework.
How closely have you looked at Barracuda Ted? Some of
what they do is interesting. I think we could make an
It might be nice if there was a way to register an
interface with the ActionServlet in the config file
for it to initialize a service. All the
ValidatorServlet I made does is parse the xml file
with the Digester and put an object into application
scope. If a class could be registered, then a
I agree with Nick that a lot of these scenarios can't
be known until the user enters the country that the
address info belongs to. What if someone in Britain
is sending a gift to someone in France? What if your
home address is in one country and you work in another
so you put down your business
the '.' operator mean
anything we want it to mean
for a given target class. Kind of cool. This kind of
thing can also be seen
in the Python programming language where the
developer can override the
imlementation of '.' and is also similar to 'tie' in
Perl .
-will
David Winterfeldt writes
For an array you can do this for a property
type[index]. I don't know if this has been
suggested before, but what if you could also do this
for a Hashmap. I was thinking something like
form{name}. I'm sure there are lots of other uses,
but it could let you make a bean/form class that just
used
I would like to volunteer to create Cactus unit tests
for the logic tags.
David Winterfeldt
__
Do You Yahoo!?
Yahoo! Auctions - buy the things you want at great prices
http://auctions.yahoo.com/
Type attribute
type - Fully qualified Java class name of the element
to be exposed through the JSP bean named from the id
attribute. If not present, no type conversions will be
performed. NOTE: The actual elements of the collection
must be assignment-compatible with this class, or a
request time
The disabled attribute sounds best if enought browsers
support it, but if they don't what if readonly wasn't
an html attribute, but a Struts one and if it was
'true' the field could written out as text? I don't
know know if this has already been suggested or not.
David
--- "Craig R.
was to generate code based on
the validation rules.
However, David Winterfeldt has written an
interesting validator that runs
off an XML spec directly. This may be a better
approach, in that you can
modify the rules later without recreating the
bean, among other things.
I was considering
88 matches
Mail list logo
