[Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-07-24 Thread anishmangal2002
This patch adds support to create multiple tabbed windows in Browse. A tab may be added by either clicking the add tab ('+') icon in the activity toolbar or by pressing 'ctrl+t'. HACK: Currently, the multiple tabs feature crashes the Browse activity on cairo versions 1.8.10 or later. The exact

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-07-22 Thread Lucian Branescu
Could you please attach a patch against mainline master HEAD? (not inline in the email) Also, does it still crash? On 1 July 2010 21:02, anishmangal2002 anishmangal2...@gmail.com wrote: This patch adds support to create multiple tabbed windows in Browse. A tab may be added by either clicking

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-07-01 Thread Bernie Innocenti
El Wed, 30-06-2010 a las 11:13 +0200, Benjamin Otte escribió: I believe this is a Mozilla bug, to be exact: https://bugzilla.mozilla.org/show_bug.cgi?id=522635 Thanks! I asked if someone could point me at the patch, so I can apply it to the F11 version of xulrunner. (damn, I wish we did not

[Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-06-29 Thread anishmangal2002
This patch adds support to create multiple tabbed windows in Browse. A tab may be added by either clicking the add tab ('+') icon in the activity toolbar or by pressing 'ctrl+t'. Signed-off-by: anishmangal2002 anishmangal2...@gmail.com --- icons/add-tab.svg | 86

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-06-29 Thread Anish Mangal
Note: 1. On f13 based sugar environments (such as soas3, jhbuild-0.88), this patch will occasionally cause Browse to crash when closing tabs. This probably happens because of a bug [1] (or something very similar to this). As a workaround, one can downgrade the cairo package from cairo-1.8.10 to

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-06-29 Thread Anish Mangal
1. On f13 based sugar environments (such as soas3, jhbuild-0.88), this Oops, I meant soas3 and jhbuild-0.88 running on f13. On Wed, Jun 30, 2010 at 2:46 AM, Anish Mangal anishmangal2...@gmail.com wrote: Note: 1. On f13 based sugar environments (such as soas3, jhbuild-0.88), this patch will

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-06-29 Thread Lucian Branescu
I'm not sure it's a good idea to merge this if it causes Browse (vital app) to occasionally crash on SoaS (very popular Sugar environment). At the very least, the tabs feature should be disabled if that certain version of cairo is detected. Also, it would be more convenient if you put your work

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-06-29 Thread Walter Bender
On Tue, Jun 29, 2010 at 4:58 PM, anishmangal2002 anishmangal2...@gmail.com wrote: This patch adds support to create multiple tabbed windows in Browse. A tab may be added by either clicking the add tab ('+') icon in the activity toolbar or by pressing 'ctrl+t'. Signed-off-by: anishmangal2002

Re: [Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

2010-06-29 Thread Bernie Innocenti
El Tue, 29-06-2010 a las 22:26 +0100, Lucian Branescu escribió: I'm not sure it's a good idea to merge this if it causes Browse (vital app) to occasionally crash on SoaS (very popular Sugar environment). At the very least, the tabs feature should be disabled if that certain version of cairo is