Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091 -v2

2011-10-09 Thread Simon Schampijer
On 10/07/2011 08:47 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiardgodi...@gmail.com The neighboard view use alpha to show the applied filter. When the state of a ap change the graphic representation is updated and the alpha should be restored acording the filter value. v2 - As suggested

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-10-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2011-10-07 18:19:18 +0200: The design is strange, but this is how the neighborhood view has worked for as long as I have been involved with the project. Each icon subscribes to all of its possible event sources (the search box, the network device it is

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-10-07 Thread Simon Schampijer
On 09/26/2011 02:29 PM, Sascha Silbe wrote: Excerpts from godiard's message of 2011-09-22 21:11:42 +0200: [src/jarabe/desktop/networkviews.py] @@ -149,6 +149,7 @@ class WirelessNetworkView(CanvasPulsingIcon): self._update_state() self._update_icon()

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-10-07 Thread Daniel Drake
On Fri, Oct 7, 2011 at 5:08 PM, Simon Schampijer si...@schampijer.de wrote: The WirelessNetworkView listens on the State signal of the device, so it is true that all the icons are updated when the device state changes. This could be optimized in general. Yes, I agree with this. The design is

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-10-07 Thread Daniel Drake
On Fri, Oct 7, 2011 at 5:19 PM, Daniel Drake d...@laptop.org wrote: For now Gonzalo's patch looks reasonable to me as well. Apart from the fact that it has no commit message. Thats not good. Daniel ___ Sugar-devel mailing list

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-09-28 Thread Gonzalo Odiard
On Mon, Sep 26, 2011 at 9:29 AM, Sascha Silbe si...@activitycentral.comwrote: Excerpts from godiard's message of 2011-09-22 21:11:42 +0200: [src/jarabe/desktop/networkviews.py] @@ -149,6 +149,7 @@ class WirelessNetworkView(CanvasPulsingIcon): self._update_state()

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-09-26 Thread Sascha Silbe
Excerpts from godiard's message of 2011-09-22 21:11:42 +0200: [src/jarabe/desktop/networkviews.py] @@ -149,6 +149,7 @@ class WirelessNetworkView(CanvasPulsingIcon): self._update_state() self._update_icon() self._update_badge() +self._update_color() [...]

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-09-23 Thread Simon Schampijer
On 09/22/2011 09:11 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiardgodi...@gmail.com Signed-off-by: Gonzalo Odiardgonz...@laptop.org Patch looks good and tested here on os6. Acked-by: Simon Schampijer si...@laptop.org Tested-by: Simon Schampijer si...@laptop.org Regards, Simon