Re: [Sugar-devel] [PATCH v2] Free space displayed for Journal Button in Volumes Toolbar. (Ticket #2318)

2010-10-18 Thread James Cameron
On Mon, Oct 18, 2010 at 12:14:59AM +0530, Ishan Bansal wrote: Pallete added to calculate and display free journal space when we write click. Two errors. s/Pallete/Palette s/write click/right click --- a/src/jarabe/journal/volumestoolbar.py +++ b/src/jarabe/journal/volumestoolbar.py [...]

Re: [Sugar-devel] [PATCH v4 sugar] Shutdown (and Logout) menuitems should activate

2010-10-18 Thread James Cameron
On Mon, Oct 18, 2010 at 06:36:16AM +0530, Anurag Chowdhury wrote: We changed the cursor in home window to a busy cursor when the shutdown menu is activated and used glib.idle_add( ) to call the shut funtion when pygtk is idle to shutdown or logout the sugar session properly , hence letting the

Re: [Sugar-devel] [PATCH v2 Paint] Changes made to save the last added text item. (OLPC #5917)

2010-10-18 Thread Gonzalo Odiard
I want to add to the review made from James: * the text tool from Paint is in bad state. I want to change it to support text styles and the actual approach don't allow it. * there are variables with names in portuguese like janela and estadoTexto. estadoTexto means text_status :( * estadoTexto

Re: [Sugar-devel] Home button in browse - toolbar images

2010-10-18 Thread Gary Martin
On 14 Oct 2010, at 23:35, Lucian Branescu wrote: On 14 October 2010 19:47, Gary Martin garycmar...@googlemail.com wrote: Hi Gonzalo, On 5 Oct 2010, at 20:32, Gonzalo Odiard wrote: Gary: Here are the screenshots. I comented a check of cairo version to add the tabs button.

Re: [Sugar-devel] [PATCH PaintActivity] Paint - Rect. Marquee icon changes erratically(OLPC #5882)

2010-10-18 Thread Gonzalo Odiard
I thing is better do: if self.tool['name'] in cursors: name = cursors[self.tool['name']] cursor = gtk.gdk.cursor_new_from_name(display, name) +elif tool['name'] == 'marquee-rectangular': +cursor =

Re: [Sugar-devel] [PATCH] Enable save as PDF from Write. SL #1458

2010-10-18 Thread Gonzalo Odiard
This patch was added to the ticket 13 months ago, but is a diff patch, no a git format-patch. I don't know how is iwikiwi, please if he/she is in the list and want to redo the patch. tell me and I will try to help to make it land in the repository. The patch is ok. I have tried it and works. It

Re: [Sugar-devel] Home button in browse - toolbar images

2010-10-18 Thread Bernie Innocenti
On Mon, 2010-10-18 at 14:20 +0100, Gary Martin wrote: I'd swap them anyway, Home makes sense to be next to Back/Forward. However, I'm really not satisfied with the amount of space left for the URL bar. Yes agreed, toolbar complexity is my other worry (too many tool icons at the top

Re: [Sugar-devel] [PATCH Paint Activity] Added Invert Color Effect to Paint Activity (OLPC #2495)

2010-10-18 Thread Gonzalo Odiard
Ayush, please run pylint and pep8 over your code and attach to the ticket. Thanks. Gonzalo On Sat, Oct 16, 2010 at 7:10 PM, Ayush Goyal ay...@seeta.in wrote: Signed-off-by: Ayush Goyal ay...@seeta.in --- Area.py | 40 + icons/invert-colors.svg | 387

Re: [Sugar-devel] [PATCH Paint Activity] Added Invert Color Effect to Paint Activity (OLPC #2495)

2010-10-18 Thread Manusheel Gupta
Gonzalo, Thank you for the feedback. This mistake was identified in Ayush's patch. He has configured sugar-lint and will run pep8 over the code. I have also asked him to attach the patch at the ticket. Do you want him to open a separate ticket at Sugarlabs bug tracker, and upload the patch over

Re: [Sugar-devel] [PATCH v4 sugar] Disable Start menu item for entries that can't be opened(Bug#328)

2010-10-18 Thread Aleksey Lim
On Sun, Oct 17, 2010 at 11:11:41PM +0530, Mukul Gupta wrote: The patch disables the Start and Start With menu items for files which can't be opened by any installed activity and instead replace it with a hover dropdown with a menu item 'No activity installed to start entry' Commited, thanks.

Re: [Sugar-devel] [PATCH v4 sugar] Shutdown (and Logout) menuitems should activate

2010-10-18 Thread Aleksey Lim
On Wed, Oct 06, 2010 at 04:42:41AM +0530, Anurag Chowdhury wrote: We changed the cursor in home window to a busy cursor when the shutdown menu is activated and used glib.idle_add( ) to call the shut funtion when pygtk is idle to shutdown or logout the sugar session properly , hence letting the

Re: [Sugar-devel] [Dextrose] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080

2010-10-18 Thread Aleksey Lim
On Mon, Oct 18, 2010 at 12:43:49AM +0530, Anurag Chowdhury wrote: Team I had submitted the patch for the http://bugs.sugarlabs.org/ticket/2080 You can check the patch at http://lists.sugarlabs.org/archive/sugar-devel/2010-October/027748.html Wish if you could review it and provide me

Re: [Sugar-devel] [PATCH Paint Activity] Added Invert Color Effect to Paint Activity (OLPC #2495)

2010-10-18 Thread Ayush Goyal
Gonzalo, Thank you for the review and feedback. Please find the revised patch attached at http://dev.laptop.org/ticket/2495. The icon developed can be found at http://seeta.in/dextrose/olpc2495/. Looking forward to your review on the revised patch. Appreciate your support. Regards, Ayush

Re: [Sugar-devel] [PATCH Paint Activity] Added Invert Color Effect to Paint Activity (OLPC #2495)

2010-10-18 Thread Manusheel Gupta
FYI -- Forwarded message -- From: Ayush Goyal ay...@seeta.in Date: Tue, Oct 19, 2010 at 1:28 AM Subject: Re: [Sugar-devel] [PATCH Paint Activity] Added Invert Color Effect to Paint Activity (OLPC #2495) To: Cc: sugar-devel sugar-devel@lists.sugarlabs.org Gonzalo, Thank you for

Re: [Sugar-devel] [PATCH Paint Activity] Added Invert Color Effect to Paint Activity (OLPC #2495)

2010-10-18 Thread Manusheel Gupta
Ayush, Kindly maintain the same thread while sending the response. Thank you. Regards, Manu On Tue, Oct 19, 2010 at 1:28 AM, Ayush Goyal ay...@seeta.in wrote: Gonzalo, Thank you for the review and feedback. Please find the revised patch attached at http://dev.laptop.org/ticket/2495.

[Sugar-devel] [Design]: OLPC#2493 [Implement a scale in paint Activity]

2010-10-18 Thread Ayush Goyal
Team, Kindly share your feedback on the two approaches I have arrived at for this issue. Thank you Gonzalo for your positive feedback on them. 1.Use selection tool(Marquee tool) for scale using its boundary as dimensions ,printing it out on either toolbox ,or on a temporary status bar at

Re: [Sugar-devel] [PATCH v2 Paint] Changes made to save the last added text item. (OLPC #5917)

2010-10-18 Thread James Cameron
On Mon, Oct 18, 2010 at 08:55:52AM -0300, Gonzalo Odiard wrote: * Create the constants and replace in the use with estadoTexto. * rename estadoTexto to text_status. * put the part of Desenho.text where the text is printed in the image in a new method. At the start of

Re: [Sugar-devel] [PATCH v5 sugar] Shutdown (and Logout) menuitems should activate

2010-10-18 Thread James Cameron
Reviewed-by: James Cameron qu...@laptop.org -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] Home button in browse - toolbar images

2010-10-18 Thread Gary Martin
On 18 Oct 2010, at 16:42, Bernie Innocenti ber...@codewiz.org wrote: On Mon, 2010-10-18 at 14:20 +0100, Gary Martin wrote: I'd swap them anyway, Home makes sense to be next to Back/Forward. However, I'm really not satisfied with the amount of space left for the URL bar. Yes agreed, toolbar

Re: [Sugar-devel] wordgroupz ( A vocabulary building app) ported to sugar

2010-10-18 Thread Ratnadeep Debnath
Thanks Gary. The icons are really good. The original wordgroupz icon was taken from openclipart.com. Instead of the random words, it would be very nice if you could put the word wordgroupz in a similar fashion. I would like to update the icon for wordgroupz. Regards, rtnpro On Sun, Oct 17, 2010